Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqs/queue: Make ISO-friendly tags #22516

Merged
merged 8 commits into from Jan 12, 2022
Merged

sqs/queue: Make ISO-friendly tags #22516

merged 8 commits into from Jan 12, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18135
Relates #18593
Relates #22532

Output from acceptance testing (us-west-2):

% make testacc TESTS='TestAccSQSQueue_|TestAccSQSQueueDataSource_' PKG=sqs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20 -run='TestAccSQSQueue_|TestAccSQSQueueDataSource_'  -timeout 180m
--- PASS: TestAccSQSQueue_FIFOQueue_expectNameError (4.43s)
--- PASS: TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError (4.58s)
--- PASS: TestAccSQSQueueDataSource_basic (60.23s)
--- PASS: TestAccSQSQueue_namePrefix (62.87s)
--- PASS: TestAccSQSQueue_Name_generated (58.80s)
--- PASS: TestAccSQSQueue_FIFOQueue_contentBasedDeduplication (63.35s)
--- PASS: TestAccSQSQueue_fifoQueue (63.47s)
--- PASS: TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds (63.57s)
--- PASS: TestAccSQSQueue_NameGenerated_fifoQueue (63.59s)
--- PASS: TestAccSQSQueue_basic (59.01s)
--- PASS: TestAccSQSQueue_NamePrefix_fifoQueue (63.59s)
--- PASS: TestAccSQSQueue_zeroVisibilityTimeoutSeconds (63.61s)
--- PASS: TestAccSQSQueue_disappears (73.49s)
--- PASS: TestAccSQSQueue_tags (84.71s)
--- PASS: TestAccSQSQueue_FIFOQueue_highThroughputMode (101.13s)
--- PASS: TestAccSQSQueue_update (101.49s)
--- PASS: TestAccSQSQueue_Policy_ignoreEquivalent (109.12s)
--- PASS: TestAccSQSQueueDataSource_tags (49.80s)
--- PASS: TestAccSQSQueue_Policy_basic (112.63s)
--- PASS: TestAccSQSQueue_redriveAllowPolicy (136.23s)
--- PASS: TestAccSQSQueue_encryption (136.97s)
--- PASS: TestAccSQSQueue_redrivePolicy (140.99s)
--- PASS: TestAccSQSQueue_recentlyDeleted (211.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	212.978s

GovCloud:

  % make testacc TESTS='TestAccSQSQueue_|TestAccSQSQueueDataSource_' PKG=sqs    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20 -run='TestAccSQSQueue_|TestAccSQSQueueDataSource_'  -timeout 180m
--- PASS: TestAccSQSQueue_FIFOQueue_expectNameError (6.48s)
--- PASS: TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError (6.59s)
--- PASS: TestAccSQSQueue_tags (94.58s)
--- PASS: TestAccSQSQueue_NameGenerated_fifoQueue (106.12s)
--- PASS: TestAccSQSQueue_Name_generated (103.52s)
--- PASS: TestAccSQSQueue_zeroVisibilityTimeoutSeconds (111.81s)
--- PASS: TestAccSQSQueue_namePrefix (112.42s)
--- PASS: TestAccSQSQueue_Policy_ignoreEquivalent (113.71s)
--- PASS: TestAccSQSQueue_Policy_basic (115.58s)
--- PASS: TestAccSQSQueue_update (153.36s)
--- PASS: TestAccSQSQueue_FIFOQueue_contentBasedDeduplication (156.87s)
--- PASS: TestAccSQSQueue_NamePrefix_fifoQueue (158.29s)
--- PASS: TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds (162.00s)
--- PASS: TestAccSQSQueue_fifoQueue (162.47s)
--- PASS: TestAccSQSQueue_basic (155.99s)
--- SKIP: TestAccSQSQueue_redriveAllowPolicy (163.41s)
--- PASS: TestAccSQSQueue_redrivePolicy (189.21s)
--- PASS: TestAccSQSQueueDataSource_tags (99.62s)
--- PASS: TestAccSQSQueue_FIFOQueue_highThroughputMode (203.82s)
--- PASS: TestAccSQSQueueDataSource_basic (224.29s)
--- PASS: TestAccSQSQueue_disappears (234.13s)
--- PASS: TestAccSQSQueue_encryption (248.37s)
--- PASS: TestAccSQSQueue_recentlyDeleted (275.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	277.168s

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/sqs Issues and PRs that pertain to the sqs service. labels Jan 11, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 11, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSQSQueue_\|TestAccSQSQueueDataSource_' PKG=sqs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20  -run=TestAccSQSQueue_\|TestAccSQSQueueDataSource_ -timeout 180m
=== RUN   TestAccSQSQueueDataSource_basic
=== PAUSE TestAccSQSQueueDataSource_basic
=== RUN   TestAccSQSQueueDataSource_tags
=== PAUSE TestAccSQSQueueDataSource_tags
=== RUN   TestAccSQSQueue_basic
=== PAUSE TestAccSQSQueue_basic
=== RUN   TestAccSQSQueue_disappears
=== PAUSE TestAccSQSQueue_disappears
=== RUN   TestAccSQSQueue_Name_generated
=== PAUSE TestAccSQSQueue_Name_generated
=== RUN   TestAccSQSQueue_NameGenerated_fifoQueue
=== PAUSE TestAccSQSQueue_NameGenerated_fifoQueue
=== RUN   TestAccSQSQueue_namePrefix
=== PAUSE TestAccSQSQueue_namePrefix
=== RUN   TestAccSQSQueue_NamePrefix_fifoQueue
=== PAUSE TestAccSQSQueue_NamePrefix_fifoQueue
=== RUN   TestAccSQSQueue_tags
=== PAUSE TestAccSQSQueue_tags
=== RUN   TestAccSQSQueue_update
=== PAUSE TestAccSQSQueue_update
=== RUN   TestAccSQSQueue_Policy_basic
=== PAUSE TestAccSQSQueue_Policy_basic
=== RUN   TestAccSQSQueue_Policy_ignoreEquivalent
=== PAUSE TestAccSQSQueue_Policy_ignoreEquivalent
=== RUN   TestAccSQSQueue_recentlyDeleted
=== PAUSE TestAccSQSQueue_recentlyDeleted
=== RUN   TestAccSQSQueue_redrivePolicy
=== PAUSE TestAccSQSQueue_redrivePolicy
=== RUN   TestAccSQSQueue_redriveAllowPolicy
=== PAUSE TestAccSQSQueue_redriveAllowPolicy
=== RUN   TestAccSQSQueue_fifoQueue
=== PAUSE TestAccSQSQueue_fifoQueue
=== RUN   TestAccSQSQueue_FIFOQueue_expectNameError
=== PAUSE TestAccSQSQueue_FIFOQueue_expectNameError
=== RUN   TestAccSQSQueue_FIFOQueue_contentBasedDeduplication
=== PAUSE TestAccSQSQueue_FIFOQueue_contentBasedDeduplication
=== RUN   TestAccSQSQueue_FIFOQueue_highThroughputMode
=== PAUSE TestAccSQSQueue_FIFOQueue_highThroughputMode
=== RUN   TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError
=== PAUSE TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError
=== RUN   TestAccSQSQueue_encryption
=== PAUSE TestAccSQSQueue_encryption
=== RUN   TestAccSQSQueue_zeroVisibilityTimeoutSeconds
=== PAUSE TestAccSQSQueue_zeroVisibilityTimeoutSeconds
=== RUN   TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds
=== PAUSE TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds
=== CONT  TestAccSQSQueueDataSource_basic
=== CONT  TestAccSQSQueue_redriveAllowPolicy
=== CONT  TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds
=== CONT  TestAccSQSQueue_tags
=== CONT  TestAccSQSQueue_NamePrefix_fifoQueue
=== CONT  TestAccSQSQueue_redrivePolicy
=== CONT  TestAccSQSQueue_recentlyDeleted
=== CONT  TestAccSQSQueue_Policy_ignoreEquivalent
=== CONT  TestAccSQSQueue_Policy_basic
=== CONT  TestAccSQSQueue_update
=== CONT  TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError
=== CONT  TestAccSQSQueue_FIFOQueue_highThroughputMode
=== CONT  TestAccSQSQueue_FIFOQueue_contentBasedDeduplication
=== CONT  TestAccSQSQueue_FIFOQueue_expectNameError
=== CONT  TestAccSQSQueue_Name_generated
=== CONT  TestAccSQSQueue_namePrefix
=== CONT  TestAccSQSQueue_fifoQueue
=== CONT  TestAccSQSQueue_basic
=== CONT  TestAccSQSQueue_NameGenerated_fifoQueue
=== CONT  TestAccSQSQueue_disappears
--- PASS: TestAccSQSQueue_FIFOQueue_expectNameError (11.54s)
=== CONT  TestAccSQSQueueDataSource_tags
--- PASS: TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError (12.60s)
=== CONT  TestAccSQSQueue_encryption
--- PASS: TestAccSQSQueue_disappears (110.04s)
=== CONT  TestAccSQSQueue_zeroVisibilityTimeoutSeconds
--- PASS: TestAccSQSQueueDataSource_basic (112.44s)
--- PASS: TestAccSQSQueue_Name_generated (115.51s)
--- PASS: TestAccSQSQueue_NamePrefix_fifoQueue (116.06s)
--- PASS: TestAccSQSQueue_fifoQueue (116.08s)
--- PASS: TestAccSQSQueue_FIFOQueue_contentBasedDeduplication (116.36s)
--- PASS: TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds (116.38s)
--- PASS: TestAccSQSQueue_namePrefix (116.54s)
--- PASS: TestAccSQSQueue_NameGenerated_fifoQueue (116.55s)
--- PASS: TestAccSQSQueue_basic (117.03s)
--- PASS: TestAccSQSQueueDataSource_tags (106.37s)
--- PASS: TestAccSQSQueue_redriveAllowPolicy (136.67s)
--- PASS: TestAccSQSQueue_redrivePolicy (136.73s)
--- PASS: TestAccSQSQueue_tags (146.61s)
--- PASS: TestAccSQSQueue_update (157.38s)
--- PASS: TestAccSQSQueue_recentlyDeleted (167.09s)
--- PASS: TestAccSQSQueue_zeroVisibilityTimeoutSeconds (59.05s)
--- PASS: TestAccSQSQueue_Policy_basic (182.76s)
--- PASS: TestAccSQSQueue_Policy_ignoreEquivalent (183.81s)
--- PASS: TestAccSQSQueue_FIFOQueue_highThroughputMode (203.83s)
--- PASS: TestAccSQSQueue_encryption (238.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	256.893s

@YakDriver YakDriver mentioned this pull request Jan 11, 2022
27 tasks
@YakDriver YakDriver merged commit 24468db into main Jan 12, 2022
@YakDriver YakDriver deleted the f-iso-sqs-tagging branch January 12, 2022 15:28
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 12, 2022
github-actions bot pushed a commit that referenced this pull request Jan 12, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sqs Issues and PRs that pertain to the sqs service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag error for SQS in iso partitions
2 participants