iam: ISO-friendly tagging #22544
Merged
iam: ISO-friendly tagging #22544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
27 tasks
github-actions
bot
added
size/L
ewbankkit
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIAMRoleDataSource_\|TestAccIAMRole_\|TestAccIAMUserDataSource_\|TestAccIAMUser_' PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run=TestAccIAMRoleDataSource_\|TestAccIAMRole_\|TestAccIAMUserDataSource_\|TestAccIAMUser_ -timeout 180m
=== RUN TestAccIAMRoleDataSource_basic
=== PAUSE TestAccIAMRoleDataSource_basic
=== RUN TestAccIAMRoleDataSource_tags
=== PAUSE TestAccIAMRoleDataSource_tags
=== RUN TestAccIAMRole_basic
=== PAUSE TestAccIAMRole_basic
=== RUN TestAccIAMRole_basicWithDescription
=== PAUSE TestAccIAMRole_basicWithDescription
=== RUN TestAccIAMRole_nameGenerated
=== PAUSE TestAccIAMRole_nameGenerated
=== RUN TestAccIAMRole_namePrefix
=== PAUSE TestAccIAMRole_namePrefix
=== RUN TestAccIAMRole_testNameChange
=== PAUSE TestAccIAMRole_testNameChange
=== RUN TestAccIAMRole_badJSON
=== PAUSE TestAccIAMRole_badJSON
=== RUN TestAccIAMRole_disappears
=== PAUSE TestAccIAMRole_disappears
=== RUN TestAccIAMRole_policiesForceDetach
=== PAUSE TestAccIAMRole_policiesForceDetach
=== RUN TestAccIAMRole_maxSessionDuration
=== PAUSE TestAccIAMRole_maxSessionDuration
=== RUN TestAccIAMRole_permissionsBoundary
=== PAUSE TestAccIAMRole_permissionsBoundary
=== RUN TestAccIAMRole_tags
=== PAUSE TestAccIAMRole_tags
=== RUN TestAccIAMRole_InlinePolicy_basic
=== PAUSE TestAccIAMRole_InlinePolicy_basic
=== RUN TestAccIAMRole_InlinePolicy_ignoreOrder
=== PAUSE TestAccIAMRole_InlinePolicy_ignoreOrder
=== RUN TestAccIAMRole_InlinePolicy_empty
=== PAUSE TestAccIAMRole_InlinePolicy_empty
=== RUN TestAccIAMRole_ManagedPolicy_basic
=== PAUSE TestAccIAMRole_ManagedPolicy_basic
=== RUN TestAccIAMRole_ManagedPolicy_outOfBandRemovalAddedBack
=== PAUSE TestAccIAMRole_ManagedPolicy_outOfBandRemovalAddedBack
=== RUN TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack
=== PAUSE TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack
=== RUN TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemoved
=== PAUSE TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemoved
=== RUN TestAccIAMRole_InlinePolicy_outOfBandAdditionRemoved
=== PAUSE TestAccIAMRole_InlinePolicy_outOfBandAdditionRemoved
=== RUN TestAccIAMRole_InlinePolicy_outOfBandAdditionIgnored
=== PAUSE TestAccIAMRole_InlinePolicy_outOfBandAdditionIgnored
=== RUN TestAccIAMRole_ManagedPolicy_outOfBandAdditionIgnored
=== PAUSE TestAccIAMRole_ManagedPolicy_outOfBandAdditionIgnored
=== RUN TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty
=== PAUSE TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty
=== RUN TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemovedEmpty
=== PAUSE TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemovedEmpty
=== RUN TestAccIAMUserDataSource_basic
=== PAUSE TestAccIAMUserDataSource_basic
=== RUN TestAccIAMUserDataSource_tags
=== PAUSE TestAccIAMUserDataSource_tags
=== RUN TestAccIAMUser_basic
=== PAUSE TestAccIAMUser_basic
=== RUN TestAccIAMUser_disappears
=== PAUSE TestAccIAMUser_disappears
=== RUN TestAccIAMUser_ForceDestroy_accessKey
=== PAUSE TestAccIAMUser_ForceDestroy_accessKey
=== RUN TestAccIAMUser_ForceDestroy_loginProfile
=== PAUSE TestAccIAMUser_ForceDestroy_loginProfile
=== RUN TestAccIAMUser_ForceDestroy_mfaDevice
=== PAUSE TestAccIAMUser_ForceDestroy_mfaDevice
=== RUN TestAccIAMUser_ForceDestroy_sshKey
=== PAUSE TestAccIAMUser_ForceDestroy_sshKey
=== RUN TestAccIAMUser_ForceDestroy_signingCertificate
=== PAUSE TestAccIAMUser_ForceDestroy_signingCertificate
=== RUN TestAccIAMUser_nameChange
=== PAUSE TestAccIAMUser_nameChange
=== RUN TestAccIAMUser_pathChange
=== PAUSE TestAccIAMUser_pathChange
=== RUN TestAccIAMUser_permissionsBoundary
=== PAUSE TestAccIAMUser_permissionsBoundary
=== RUN TestAccIAMUser_tags
=== PAUSE TestAccIAMUser_tags
=== CONT TestAccIAMRoleDataSource_basic
=== CONT TestAccIAMRole_InlinePolicy_outOfBandAdditionRemoved
=== CONT TestAccIAMUser_ForceDestroy_mfaDevice
=== CONT TestAccIAMRole_ManagedPolicy_outOfBandAdditionIgnored
=== CONT TestAccIAMUserDataSource_tags
=== CONT TestAccIAMUser_ForceDestroy_loginProfile
=== CONT TestAccIAMUser_tags
=== CONT TestAccIAMUser_permissionsBoundary
=== CONT TestAccIAMUser_pathChange
=== CONT TestAccIAMUser_nameChange
=== CONT TestAccIAMUser_ForceDestroy_signingCertificate
=== CONT TestAccIAMUser_ForceDestroy_sshKey
=== CONT TestAccIAMUserDataSource_basic
=== CONT TestAccIAMUser_ForceDestroy_accessKey
=== CONT TestAccIAMUser_disappears
=== CONT TestAccIAMUser_basic
=== CONT TestAccIAMRole_InlinePolicy_outOfBandAdditionIgnored
=== CONT TestAccIAMRole_maxSessionDuration
=== CONT TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemoved
=== CONT TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty
--- PASS: TestAccIAMUser_disappears (39.25s)
=== CONT TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack
--- PASS: TestAccIAMUserDataSource_basic (45.25s)
=== CONT TestAccIAMRole_ManagedPolicy_outOfBandRemovalAddedBack
--- PASS: TestAccIAMUserDataSource_tags (46.39s)
=== CONT TestAccIAMRole_ManagedPolicy_basic
--- PASS: TestAccIAMRoleDataSource_basic (48.25s)
=== CONT TestAccIAMRole_InlinePolicy_empty
--- PASS: TestAccIAMUser_ForceDestroy_accessKey (48.78s)
=== CONT TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemovedEmpty
--- PASS: TestAccIAMUser_ForceDestroy_signingCertificate (51.61s)
=== CONT TestAccIAMRole_InlinePolicy_ignoreOrder
--- PASS: TestAccIAMUser_ForceDestroy_loginProfile (52.82s)
=== CONT TestAccIAMRole_InlinePolicy_basic
--- PASS: TestAccIAMUser_ForceDestroy_mfaDevice (53.23s)
=== CONT TestAccIAMRole_namePrefix
--- PASS: TestAccIAMUser_ForceDestroy_sshKey (53.52s)
=== CONT TestAccIAMRole_permissionsBoundary
=== CONT TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty
role_test.go:774: Step 2/2 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_iam_role.test will be updated in-place
~ resource "aws_iam_role" "test" {
id = "tf-acc-test-3803235688671085725"
name = "tf-acc-test-3803235688671085725"
tags = {}
# (9 unchanged attributes hidden)
+ inline_policy {}
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
=== CONT TestAccIAMRole_InlinePolicy_empty
role_test.go:497: Step 1/1 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_iam_role.test will be updated in-place
~ resource "aws_iam_role" "test" {
id = "tf-acc-test-6545782902331658310"
name = "tf-acc-test-6545782902331658310"
# (9 unchanged attributes hidden)
+ inline_policy {}
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty (72.34s)
=== CONT TestAccIAMRole_policiesForceDetach
--- FAIL: TestAccIAMRole_InlinePolicy_empty (30.90s)
=== CONT TestAccIAMRole_tags
--- PASS: TestAccIAMUser_basic (79.15s)
=== CONT TestAccIAMRole_badJSON
--- PASS: TestAccIAMRole_ManagedPolicy_outOfBandAdditionIgnored (79.24s)
=== CONT TestAccIAMRole_disappears
--- PASS: TestAccIAMUser_pathChange (85.14s)
=== CONT TestAccIAMRole_basicWithDescription
--- PASS: TestAccIAMUser_nameChange (86.49s)
=== CONT TestAccIAMRole_nameGenerated
--- PASS: TestAccIAMUser_tags (86.53s)
=== CONT TestAccIAMRole_basic
--- PASS: TestAccIAMRole_badJSON (8.80s)
=== CONT TestAccIAMRoleDataSource_tags
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandAdditionRemoved (91.73s)
=== CONT TestAccIAMRole_testNameChange
--- PASS: TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemoved (92.14s)
=== CONT TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack
role_test.go:599: Step 2/2 error: Check failed: Check 2/2 error: aws_iam_role.test: Attribute 'inline_policy.#' expected "1", got "2"
--- PASS: TestAccIAMRole_maxSessionDuration (101.77s)
--- FAIL: TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack (67.07s)
--- PASS: TestAccIAMRole_namePrefix (59.71s)
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandAdditionIgnored (122.37s)
--- PASS: TestAccIAMRole_disappears (45.62s)
--- PASS: TestAccIAMRole_policiesForceDetach (63.63s)
--- PASS: TestAccIAMRoleDataSource_tags (54.08s)
--- PASS: TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemovedEmpty (93.35s)
--- PASS: TestAccIAMRole_ManagedPolicy_outOfBandRemovalAddedBack (96.90s)
--- PASS: TestAccIAMRole_basic (64.82s)
--- PASS: TestAccIAMRole_nameGenerated (64.97s)
--- PASS: TestAccIAMRole_tags (104.41s)
--- PASS: TestAccIAMRole_InlinePolicy_ignoreOrder (136.15s)
--- PASS: TestAccIAMRole_ManagedPolicy_basic (142.66s)
--- PASS: TestAccIAMRole_testNameChange (101.54s)
--- PASS: TestAccIAMRole_InlinePolicy_basic (140.47s)
--- PASS: TestAccIAMUser_permissionsBoundary (196.73s)
--- PASS: TestAccIAMRole_basicWithDescription (125.57s)
--- PASS: TestAccIAMRole_permissionsBoundary (173.84s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/iam 230.973s
FAIL
make: *** [testacc] Error 1Failures are unrelated to this change.
See:
|
This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #18898
Relates #18593
Relates #22532
Output from acceptance testing (
us-west-2):(* 3 pre-existing failures)
Output from acceptance testing (GovCloud):
(* 3 pre-existing failures)