Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO-Friendly tagging fixups #22559

Merged
merged 9 commits into from Jan 13, 2022
Merged

ISO-Friendly tagging fixups #22559

merged 9 commits into from Jan 13, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 13, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22532

Output from acceptance testing:

% make testacc TESTS=TestAccEventsBus_ PKG=events TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_' -short -timeout 180m
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
--- PASS: TestAccEventsBus_default (2.11s)
--- PASS: TestAccEventsBus_disappears (12.89s)
--- PASS: TestAccEventsBus_basic (42.01s)
--- PASS: TestAccEventsBus_tags (53.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	54.893s
% make testacc TESTS=TestAccEventsRule_ PKG=events TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsRule_' -short -timeout 180m
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
--- PASS: TestAccEventsRule_Name_generated (26.41s)
--- PASS: TestAccEventsRule_namePrefix (26.59s)
--- PASS: TestAccEventsRule_scheduleAndPattern (26.62s)
--- PASS: TestAccEventsRule_eventBusARN (27.14s)
--- PASS: TestAccEventsRule_role (35.24s)
--- PASS: TestAccEventsRule_pattern (40.56s)
--- PASS: TestAccEventsRule_description (40.56s)
--- PASS: TestAccEventsRule_isEnabled (53.39s)
--- PASS: TestAccEventsRule_basic (53.94s)
--- PASS: TestAccEventsRule_eventBusName (58.05s)
--- PASS: TestAccEventsRule_tags (65.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	68.385s
% make testacc TESTS=TestAccECRRepository_ PKG=events TESTARGS=-short 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccECRRepository_' -short -timeout 180m
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	2.290s [no tests to run]
% make testacc TESTS=TestAccECRRepository_ PKG=ecr TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepository_' -short -timeout 180m
--- PASS: TestAccECRRepository_immutability (20.88s)
--- PASS: TestAccECRRepository_basic (20.94s)
--- PASS: TestAccECRRepository_tags (31.44s)
--- PASS: TestAccECRRepository_Encryption_aes256 (39.62s)
--- PASS: TestAccECRRepository_Encryption_kms (41.88s)
--- PASS: TestAccECRRepository_Image_scanning (48.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	50.416s
% make testacc TESTS=TestAccECSCapacityProvider_ PKG=ecs TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSCapacityProvider_' -short -timeout 180m
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (61.96s)
--- PASS: TestAccECSCapacityProvider_disappears (63.19s)
--- PASS: TestAccECSCapacityProvider_basic (75.44s)
--- PASS: TestAccECSCapacityProvider_tags (92.01s)
--- PASS: TestAccECSCapacityProvider_managedScaling (111.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	113.326s
% make testacc TESTS=TestAccECSTaskDefinition_ PKG=ecs TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinition_' -short -timeout 180m
--- SKIP: TestAccECSTaskDefinition_fsxWinFileSystem (0.00s)
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (39.63s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (40.34s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (40.48s)
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (41.05s)
--- PASS: TestAccECSTaskDefinition_constraint (41.23s)
--- PASS: TestAccECSTaskDefinition_pidMode (41.49s)
--- PASS: TestAccECSTaskDefinition_arrays (41.49s)
--- PASS: TestAccECSTaskDefinition_ipcMode (41.69s)
--- PASS: TestAccECSTaskDefinition_taskRoleARN (41.88s)
--- PASS: TestAccECSTaskDefinition_executionRole (42.00s)
--- PASS: TestAccECSTaskDefinition_networkMode (42.11s)
--- PASS: TestAccECSTaskDefinition_proxy (49.61s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (51.28s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (51.65s)
--- PASS: TestAccECSTaskDefinition_Fargate_basic (52.44s)
--- PASS: TestAccECSTaskDefinition_disappears (54.19s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (58.75s)
--- PASS: TestAccECSTaskDefinition_basic (58.77s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (24.41s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (23.79s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (23.62s)
--- PASS: TestAccECSTaskDefinition_runtimePlatform (24.11s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (24.86s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (34.41s)
--- PASS: TestAccECSTaskDefinition_tags (76.01s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (37.20s)
--- PASS: TestAccECSTaskDefinition_service (133.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	134.775s
% make testacc TESTS=TestAccECSTaskSet_ PKG=ecs TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskSet_' -short -timeout 180m
--- PASS: TestAccECSTaskSet_withExternalId (63.07s)
--- PASS: TestAccECSTaskSet_withScale (66.69s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargate (67.74s)
--- PASS: TestAccECSTaskSet_disappears (68.85s)
--- PASS: TestAccECSTaskSet_basic (73.30s)
--- PASS: TestAccECSTaskSet_withMultipleCapacityProviderStrategies (92.34s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion (97.34s)
--- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (102.21s)
--- PASS: TestAccECSTaskSet_Tags (107.00s)
--- PASS: TestAccECSTaskSet_withServiceRegistries (148.95s)
--- PASS: TestAccECSTaskSet_withAlb (236.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	237.783s
% make testacc TESTS=TestAccWAFV2RuleGroup_ PKG=wafv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafv2/... -v -count 1 -parallel 20 -run='TestAccWAFV2RuleGroup_'  -timeout 180m
--- PASS: TestAccWAFV2RuleGroup_minimal (27.97s)
--- PASS: TestAccWAFV2RuleGroup_disappears (28.25s)
--- PASS: TestAccWAFV2RuleGroup_regexPatternSetReferenceStatement (44.85s)
--- PASS: TestAccWAFV2RuleGroup_GeoMatchStatement_forwardedIP (63.95s)
--- PASS: TestAccWAFV2RuleGroup_changeNameForceNew (45.29s)
--- PASS: TestAccWAFV2RuleGroup_xssMatchStatement (108.89s)
--- PASS: TestAccWAFV2RuleGroup_sizeConstraintStatement (111.06s)
--- PASS: TestAccWAFV2RuleGroup_basic (111.07s)
--- PASS: TestAccWAFV2RuleGroup_RuleAction_customResponse (118.50s)
--- PASS: TestAccWAFV2RuleGroup_geoMatchStatement (122.70s)
--- PASS: TestAccWAFV2RuleGroup_sqliMatchStatement (130.81s)
--- PASS: TestAccWAFV2RuleGroup_logicalRuleStatements (133.35s)
--- PASS: TestAccWAFV2RuleGroup_updateRuleProperties (101.66s)
--- PASS: TestAccWAFV2RuleGroup_IPSetReferenceStatement_ipsetForwardedIP (146.52s)
--- PASS: TestAccWAFV2RuleGroup_RuleAction_customRequestHandling (159.56s)
--- PASS: TestAccWAFV2RuleGroup_byteMatchStatement (96.19s)
--- PASS: TestAccWAFV2RuleGroup_updateRule (98.76s)
--- PASS: TestAccWAFV2RuleGroup_LabelMatchStatement (175.94s)
--- PASS: TestAccWAFV2RuleGroup_tags (184.07s)
--- PASS: TestAccWAFV2RuleGroup_ruleAction (186.21s)
--- PASS: TestAccWAFV2RuleGroup_ByteMatchStatement_fieldToMatch (191.30s)
--- PASS: TestAccWAFV2RuleGroup_changeCapacityForceNew (166.06s)
--- PASS: TestAccWAFV2RuleGroup_changeMetricNameForceNew (209.16s)
--- PASS: TestAccWAFV2RuleGroup_RuleLabels (259.53s)
--- PASS: TestAccWAFV2RuleGroup_ipSetReferenceStatement (275.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	277.840s
% make testacc TESTS=TestAccS3BucketNotification_ PKG=s3    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketNotification_'  -timeout 180m
--- PASS: TestAccS3BucketNotification_topic (34.34s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (34.52s)
--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (53.01s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (57.48s)
--- PASS: TestAccS3BucketNotification_queue (66.37s)
--- PASS: TestAccS3BucketNotification_update (88.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	90.527s

@github-actions github-actions bot added service/events Issues and PRs that pertain to the events service. size/XS Managed by automation to categorize the size of a PR. service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 13, 2022
@YakDriver YakDriver added this to the v3.72.0 milestone Jan 13, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. linter Pertains to changes to or issues with the various linters. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/iam Issues and PRs that pertain to the iam service. service/s3 Issues and PRs that pertain to the s3 service. service/wafv2 Issues and PRs that pertain to the wafv2 service. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 13, 2022
ewbankkit
ewbankkit approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccEventsBus_ PKG=events TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_' -short -timeout 180m
=== RUN   TestAccEventsBus_basic
=== PAUSE TestAccEventsBus_basic
=== RUN   TestAccEventsBus_tags
=== PAUSE TestAccEventsBus_tags
=== RUN   TestAccEventsBus_default
=== PAUSE TestAccEventsBus_default
=== RUN   TestAccEventsBus_disappears
=== PAUSE TestAccEventsBus_disappears
=== RUN   TestAccEventsBus_partnerEventSource
    bus_test.go:170: Environment variable EVENT_BRIDGE_PARTNER_EVENT_SOURCE_NAME is not set
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
=== CONT  TestAccEventsBus_basic
=== CONT  TestAccEventsBus_disappears
=== CONT  TestAccEventsBus_default
=== CONT  TestAccEventsBus_tags
--- PASS: TestAccEventsBus_default (2.28s)
--- PASS: TestAccEventsBus_disappears (13.04s)
--- PASS: TestAccEventsBus_basic (45.37s)
--- PASS: TestAccEventsBus_tags (54.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	57.585s
% make testacc TESTS=TestAccEventsRule_ PKG=events TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsRule_' -short -timeout 180m
=== RUN   TestAccEventsRule_basic
=== PAUSE TestAccEventsRule_basic
=== RUN   TestAccEventsRule_eventBusName
=== PAUSE TestAccEventsRule_eventBusName
=== RUN   TestAccEventsRule_role
=== PAUSE TestAccEventsRule_role
=== RUN   TestAccEventsRule_description
=== PAUSE TestAccEventsRule_description
=== RUN   TestAccEventsRule_pattern
=== PAUSE TestAccEventsRule_pattern
=== RUN   TestAccEventsRule_scheduleAndPattern
=== PAUSE TestAccEventsRule_scheduleAndPattern
=== RUN   TestAccEventsRule_namePrefix
=== PAUSE TestAccEventsRule_namePrefix
=== RUN   TestAccEventsRule_Name_generated
=== PAUSE TestAccEventsRule_Name_generated
=== RUN   TestAccEventsRule_tags
=== PAUSE TestAccEventsRule_tags
=== RUN   TestAccEventsRule_isEnabled
=== PAUSE TestAccEventsRule_isEnabled
=== RUN   TestAccEventsRule_partnerEventBus
    rule_test.go:440: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
=== RUN   TestAccEventsRule_eventBusARN
=== PAUSE TestAccEventsRule_eventBusARN
=== CONT  TestAccEventsRule_basic
=== CONT  TestAccEventsRule_Name_generated
=== CONT  TestAccEventsRule_scheduleAndPattern
=== CONT  TestAccEventsRule_role
=== CONT  TestAccEventsRule_namePrefix
=== CONT  TestAccEventsRule_eventBusARN
=== CONT  TestAccEventsRule_isEnabled
=== CONT  TestAccEventsRule_eventBusName
=== CONT  TestAccEventsRule_tags
=== CONT  TestAccEventsRule_pattern
=== CONT  TestAccEventsRule_description
--- PASS: TestAccEventsRule_scheduleAndPattern (32.38s)
--- PASS: TestAccEventsRule_namePrefix (33.98s)
--- PASS: TestAccEventsRule_Name_generated (34.29s)
--- PASS: TestAccEventsRule_eventBusARN (34.51s)
--- PASS: TestAccEventsRule_role (41.46s)
--- PASS: TestAccEventsRule_pattern (47.17s)
--- PASS: TestAccEventsRule_description (48.14s)
--- PASS: TestAccEventsRule_basic (63.72s)
--- PASS: TestAccEventsRule_isEnabled (63.87s)
--- PASS: TestAccEventsRule_eventBusName (66.78s)
--- PASS: TestAccEventsRule_tags (75.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	79.351s
% make testacc TESTS=TestAccECRRepository_ PKG=ecr TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepository_' -short -timeout 180m
=== RUN   TestAccECRRepository_basic
=== PAUSE TestAccECRRepository_basic
=== RUN   TestAccECRRepository_tags
=== PAUSE TestAccECRRepository_tags
=== RUN   TestAccECRRepository_immutability
=== PAUSE TestAccECRRepository_immutability
=== RUN   TestAccECRRepository_Image_scanning
=== PAUSE TestAccECRRepository_Image_scanning
=== RUN   TestAccECRRepository_Encryption_kms
=== PAUSE TestAccECRRepository_Encryption_kms
=== RUN   TestAccECRRepository_Encryption_aes256
=== PAUSE TestAccECRRepository_Encryption_aes256
=== CONT  TestAccECRRepository_basic
=== CONT  TestAccECRRepository_Encryption_kms
=== CONT  TestAccECRRepository_Image_scanning
=== CONT  TestAccECRRepository_immutability
=== CONT  TestAccECRRepository_tags
=== CONT  TestAccECRRepository_Encryption_aes256
--- PASS: TestAccECRRepository_immutability (24.58s)
--- PASS: TestAccECRRepository_basic (24.59s)
--- PASS: TestAccECRRepository_tags (33.67s)
--- PASS: TestAccECRRepository_Encryption_aes256 (41.10s)
--- PASS: TestAccECRRepository_Encryption_kms (43.45s)
--- PASS: TestAccECRRepository_Image_scanning (49.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	53.036s
% make testacc TESTS=TestAccECSCapacityProvider_ PKG=ecs TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSCapacityProvider_' -short -timeout 180m
=== RUN   TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN   TestAccECSCapacityProvider_disappears
=== PAUSE TestAccECSCapacityProvider_disappears
=== RUN   TestAccECSCapacityProvider_managedScaling
=== PAUSE TestAccECSCapacityProvider_managedScaling
=== RUN   TestAccECSCapacityProvider_managedScalingPartial
=== PAUSE TestAccECSCapacityProvider_managedScalingPartial
=== RUN   TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== CONT  TestAccECSCapacityProvider_basic
=== CONT  TestAccECSCapacityProvider_managedScalingPartial
=== CONT  TestAccECSCapacityProvider_tags
=== CONT  TestAccECSCapacityProvider_disappears
=== CONT  TestAccECSCapacityProvider_managedScaling
--- PASS: TestAccECSCapacityProvider_basic (69.58s)
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (79.08s)
--- PASS: TestAccECSCapacityProvider_disappears (81.79s)
--- PASS: TestAccECSCapacityProvider_managedScaling (132.93s)
--- PASS: TestAccECSCapacityProvider_tags (151.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	155.569s
% make testacc TESTS=TestAccECSTaskDefinition_ PKG=ecs TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinition_' -short -timeout 180m
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_scratchVolume
=== PAUSE TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_minimal
=== PAUSE TestAccECSTaskDefinition_DockerVolume_minimal
=== RUN   TestAccECSTaskDefinition_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== RUN   TestAccECSTaskDefinition_EFSVolume_minimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_minimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== RUN   TestAccECSTaskDefinition_fsxWinFileSystem
    task_definition_test.go:433: skipping long-running test in short mode
--- SKIP: TestAccECSTaskDefinition_fsxWinFileSystem (0.00s)
=== RUN   TestAccECSTaskDefinition_DockerVolume_taskScoped
=== PAUSE TestAccECSTaskDefinition_DockerVolume_taskScoped
=== RUN   TestAccECSTaskDefinition_service
=== PAUSE TestAccECSTaskDefinition_service
=== RUN   TestAccECSTaskDefinition_taskRoleARN
=== PAUSE TestAccECSTaskDefinition_taskRoleARN
=== RUN   TestAccECSTaskDefinition_networkMode
=== PAUSE TestAccECSTaskDefinition_networkMode
=== RUN   TestAccECSTaskDefinition_ipcMode
=== PAUSE TestAccECSTaskDefinition_ipcMode
=== RUN   TestAccECSTaskDefinition_pidMode
=== PAUSE TestAccECSTaskDefinition_pidMode
=== RUN   TestAccECSTaskDefinition_constraint
=== PAUSE TestAccECSTaskDefinition_constraint
=== RUN   TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccECSTaskDefinition_arrays
=== PAUSE TestAccECSTaskDefinition_arrays
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccECSTaskDefinition_executionRole
=== PAUSE TestAccECSTaskDefinition_executionRole
=== RUN   TestAccECSTaskDefinition_disappears
=== PAUSE TestAccECSTaskDefinition_disappears
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskDefinition_proxy
=== PAUSE TestAccECSTaskDefinition_proxy
=== RUN   TestAccECSTaskDefinition_inferenceAccelerator
=== PAUSE TestAccECSTaskDefinition_inferenceAccelerator
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSTaskDefinition_networkMode
=== CONT  TestAccECSTaskDefinition_DockerVolume_taskScoped
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
=== CONT  TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== CONT  TestAccECSTaskDefinition_constraint
=== CONT  TestAccECSTaskDefinition_pidMode
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== CONT  TestAccECSTaskDefinition_ipcMode
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
=== CONT  TestAccECSTaskDefinition_proxy
=== CONT  TestAccECSTaskDefinition_disappears
=== CONT  TestAccECSTaskDefinition_taskRoleARN
=== CONT  TestAccECSTaskDefinition_runtimePlatform
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== CONT  TestAccECSTaskDefinition_executionRole
=== CONT  TestAccECSTaskDefinition_tags
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (33.10s)
=== CONT  TestAccECSTaskDefinition_service
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (36.29s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (37.72s)
=== CONT  TestAccECSTaskDefinition_Fargate_basic
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (38.09s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (38.21s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskDefinition_runtimePlatform (38.42s)
=== CONT  TestAccECSTaskDefinition_scratchVolume
--- PASS: TestAccECSTaskDefinition_constraint (39.00s)
=== CONT  TestAccECSTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccECSTaskDefinition_proxy (52.73s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (53.38s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (53.74s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (53.88s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (57.45s)
--- PASS: TestAccECSTaskDefinition_taskRoleARN (58.83s)
--- PASS: TestAccECSTaskDefinition_networkMode (58.87s)
--- PASS: TestAccECSTaskDefinition_disappears (59.07s)
--- PASS: TestAccECSTaskDefinition_basic (62.05s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (32.28s)
--- PASS: TestAccECSTaskDefinition_executionRole (68.57s)
--- PASS: TestAccECSTaskDefinition_ipcMode (69.08s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (33.46s)
--- PASS: TestAccECSTaskDefinition_arrays (33.36s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (33.29s)
--- PASS: TestAccECSTaskDefinition_Fargate_basic (40.19s)
--- PASS: TestAccECSTaskDefinition_pidMode (80.70s)
--- PASS: TestAccECSTaskDefinition_tags (82.03s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (43.08s)
--- PASS: TestAccECSTaskDefinition_service (100.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	136.997s
% make testacc TESTS=TestAccECSTaskSet_ PKG=ecs TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskSet_' -short -timeout 180m
=== RUN   TestAccECSTaskSet_basic
=== PAUSE TestAccECSTaskSet_basic
=== RUN   TestAccECSTaskSet_withExternalId
=== PAUSE TestAccECSTaskSet_withExternalId
=== RUN   TestAccECSTaskSet_withScale
=== PAUSE TestAccECSTaskSet_withScale
=== RUN   TestAccECSTaskSet_disappears
=== PAUSE TestAccECSTaskSet_disappears
=== RUN   TestAccECSTaskSet_withCapacityProviderStrategy
=== PAUSE TestAccECSTaskSet_withCapacityProviderStrategy
=== RUN   TestAccECSTaskSet_withMultipleCapacityProviderStrategies
=== PAUSE TestAccECSTaskSet_withMultipleCapacityProviderStrategies
=== RUN   TestAccECSTaskSet_withAlb
=== PAUSE TestAccECSTaskSet_withAlb
=== RUN   TestAccECSTaskSet_withLaunchTypeFargate
=== PAUSE TestAccECSTaskSet_withLaunchTypeFargate
=== RUN   TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion
=== PAUSE TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion
=== RUN   TestAccECSTaskSet_withServiceRegistries
=== PAUSE TestAccECSTaskSet_withServiceRegistries
=== RUN   TestAccECSTaskSet_Tags
=== PAUSE TestAccECSTaskSet_Tags
=== CONT  TestAccECSTaskSet_basic
=== CONT  TestAccECSTaskSet_withAlb
=== CONT  TestAccECSTaskSet_Tags
=== CONT  TestAccECSTaskSet_withLaunchTypeFargate
=== CONT  TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion
=== CONT  TestAccECSTaskSet_withServiceRegistries
=== CONT  TestAccECSTaskSet_disappears
=== CONT  TestAccECSTaskSet_withMultipleCapacityProviderStrategies
=== CONT  TestAccECSTaskSet_withScale
=== CONT  TestAccECSTaskSet_withCapacityProviderStrategy
=== CONT  TestAccECSTaskSet_withExternalId
--- PASS: TestAccECSTaskSet_withLaunchTypeFargate (60.10s)
--- PASS: TestAccECSTaskSet_withExternalId (61.75s)
--- PASS: TestAccECSTaskSet_basic (68.30s)
--- PASS: TestAccECSTaskSet_disappears (70.07s)
--- PASS: TestAccECSTaskSet_withScale (72.02s)
--- PASS: TestAccECSTaskSet_Tags (86.63s)
--- PASS: TestAccECSTaskSet_withMultipleCapacityProviderStrategies (97.42s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion (116.86s)
--- PASS: TestAccECSTaskSet_withServiceRegistries (144.15s)
--- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (146.01s)
--- PASS: TestAccECSTaskSet_withAlb (169.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	173.408s

@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jan 13, 2022
@YakDriver YakDriver merged commit b89bb54 into main Jan 13, 2022
@YakDriver YakDriver deleted the f-iso-tagging-fixups branch January 13, 2022 14:12
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. service/events Issues and PRs that pertain to the events service. service/iam Issues and PRs that pertain to the iam service. service/s3 Issues and PRs that pertain to the s3 service. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YakDriver @ewbankkit