Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO Tags: Improve error handling #22717

Merged
merged 13 commits into from Jan 21, 2022
Merged

ISO Tags: Improve error handling #22717

merged 13 commits into from Jan 21, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 21, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22532

Output from acceptance testing:

% make testacc TESTS='TestAccCloudWatchCompositeAlarm|TestAccCloudWatchMetricAlarm|TestAccCloudWatchMetricStream' PKG=cloudwatch TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchCompositeAlarm|TestAccCloudWatchMetricAlarm|TestAccCloudWatchMetricStream' -short -timeout 180m
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (18.39s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (36.47s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (43.57s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (44.07s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (51.55s)
--- PASS: TestAccCloudWatchCompositeAlarm_basic (52.38s)
--- PASS: TestAccCloudWatchMetricStream_namePrefix (53.16s)
--- PASS: TestAccCloudWatchMetricStream_noName (53.37s)
--- PASS: TestAccCloudWatchMetricStream_excludeFilters (53.54s)
--- PASS: TestAccCloudWatchMetricStream_tags (53.55s)
--- PASS: TestAccCloudWatchMetricStream_includeFilters (53.74s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (54.16s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (68.23s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (36.11s)
--- PASS: TestAccCloudWatchCompositeAlarm_disappears (27.79s)
--- PASS: TestAccCloudWatchCompositeAlarm_updateAlarmRule (82.38s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (93.01s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (93.52s)
--- PASS: TestAccCloudWatchCompositeAlarm_description (60.70s)
--- PASS: TestAccCloudWatchCompositeAlarm_allActions (64.18s)
--- PASS: TestAccCloudWatchCompositeAlarm_actionsEnabled (58.28s)
--- PASS: TestAccCloudWatchCompositeAlarm_okActions (80.02s)
--- PASS: TestAccCloudWatchMetricStream_basic (132.29s)
--- PASS: TestAccCloudWatchCompositeAlarm_alarmActions (83.20s)
--- PASS: TestAccCloudWatchCompositeAlarm_insufficientDataActions (84.51s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (154.63s)
--- PASS: TestAccCloudWatchMetricStream_update (191.27s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (220.64s)
--- PASS: TestAccCloudWatchMetricStream_updateName (312.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	314.169s
% make testacc TESTS='TestAccEventsBus|TestAccEventsRule' PKG=events TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus|TestAccEventsRule' -short -timeout 180m
    bus_test.go:170: Environment variable EVENT_BRIDGE_PARTNER_EVENT_SOURCE_NAME is not set
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
    rule_test.go:440: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
--- PASS: TestAccEventsBus_default (4.14s)
--- PASS: TestAccEventsBus_disappears (28.61s)
--- PASS: TestAccEventsRule_Name_generated (37.77s)
--- PASS: TestAccEventsRule_namePrefix (37.93s)
--- PASS: TestAccEventsRule_scheduleAndPattern (38.62s)
--- PASS: TestAccEventsRule_eventBusARN (39.02s)
--- PASS: TestAccEventsRule_role (45.68s)
--- PASS: TestAccEventsBusPolicy_ignoreEquivalent (47.73s)
--- PASS: TestAccEventsRule_pattern (56.80s)
--- PASS: TestAccEventsRule_description (57.03s)
--- PASS: TestAccEventsBusPolicy_basic (57.13s)
--- PASS: TestAccEventsRule_basic (69.74s)
--- PASS: TestAccEventsBus_basic (70.71s)
--- PASS: TestAccEventsRule_isEnabled (70.92s)
--- PASS: TestAccEventsRule_eventBusName (73.83s)
--- PASS: TestAccEventsBus_tags (82.67s)
--- PASS: TestAccEventsRule_tags (83.56s)
--- PASS: TestAccEventsBusPolicy_disappears (147.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	148.813s
% make testacc TESTS='TestAccELBV2Listener|TestAccELBV2LoadBalancer|TestAccELBV2TargetGroup' PKG=elbv2 TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2Listener|TestAccELBV2LoadBalancer|TestAccELBV2TargetGroup' -short -timeout 180m
--- SKIP: TestAccELBV2ListenerRule_priority (0.00s)
--- SKIP: TestAccELBV2ListenerRule_conditionUpdateMixed (0.00s)
--- SKIP: TestAccELBV2Listener_LoadBalancerARN_gatewayLoadBalancer (0.00s)
--- SKIP: TestAccELBV2Listener_Protocol_tls (0.05s)
--- SKIP: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2 (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWafFailOpen (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_updatedSecurityGroups (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_updatedSubnets (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_ALB_accessLogs (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_ALBAccessLogs_prefix (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_NLB_accessLogs (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_NLBAccessLogs_prefix (0.00s)
--- SKIP: TestAccELBV2LoadBalancer_updateDesyncMitigationMode (0.00s)
--- PASS: TestAccELBV2TargetGroup_withoutHealthCheck (24.26s)
--- PASS: TestAccELBV2TargetGroup_namePrefix (36.01s)
--- PASS: TestAccELBV2TargetGroup_protocolGeneve (37.42s)
--- PASS: TestAccELBV2TargetGroup_stickinessDefaultALB (39.37s)
--- PASS: TestAccELBV2TargetGroup_stickinessInvalidNLB (42.74s)
--- PASS: TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination (52.30s)
--- PASS: TestAccELBV2TargetGroup_updateHealthCheck (53.19s)
--- PASS: TestAccELBV2TargetGroup_stickinessInvalidALB (55.75s)
--- PASS: TestAccELBV2TargetGroup_stickinessValidALB (55.75s)
--- PASS: TestAccELBV2TargetGroup_preserveClientIPValid (56.47s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy (59.55s)
--- PASS: TestAccELBV2TargetGroup_protocolGeneveNotSticky (60.60s)
--- PASS: TestAccELBV2TargetGroup_A_lambdaMultiValueHeadersEnabled (61.87s)
--- PASS: TestAccELBV2TargetGroup_updateAppStickinessEnabled (75.82s)
--- PASS: TestAccELBV2TargetGroup_updateStickinessEnabled (75.87s)
--- PASS: TestAccELBV2TargetGroup_stickinessDefaultNLB (78.95s)
--- PASS: TestAccELBV2TargetGroup_A_namePrefix (29.17s)
--- PASS: TestAccELBV2TargetGroup_tags (81.82s)
--- PASS: TestAccELBV2TargetGroup_A_missingPortProtocolVPC (30.17s)
--- PASS: TestAccELBV2TargetGroup_generatedName (29.00s)
--- PASS: TestAccELBV2TargetGroup_A_updateHealthCheck (49.99s)
--- PASS: TestAccELBV2TargetGroup_Defaults_application (27.36s)
--- PASS: TestAccELBV2TargetGroup_A_tags (51.18s)
--- PASS: TestAccELBV2TargetGroup_enableHealthCheck (34.69s)
--- PASS: TestAccELBV2TargetGroup_A_setAndUpdateSlowStart (51.37s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroup (94.28s)
--- PASS: TestAccELBV2TargetGroup_Defaults_network (35.05s)
--- PASS: TestAccELBV2TargetGroup_A_updateStickinessEnabled (73.11s)
--- PASS: TestAccELBV2TargetGroup_A_updateLoadBalancingAlgorithmType (71.39s)
--- PASS: TestAccELBV2TargetGroup_basic (32.32s)
--- PASS: TestAccELBV2TargetGroup_Protocol_tls (26.92s)
--- PASS: TestAccELBV2TargetGroup_changeVPCForceNew (52.59s)
--- PASS: TestAccELBV2TargetGroup_basicUdp (34.87s)
--- PASS: TestAccELBV2TargetGroup_protocolVersion (27.58s)
--- PASS: TestAccELBV2TargetGroup_backwardsCompatibility (29.69s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersionGRPC_healthCheck (34.41s)
--- PASS: TestAccELBV2TargetGroup_stickinessValidNLB (126.32s)
--- PASS: TestAccELBV2TargetGroup_changePortForceNew (50.73s)
--- PASS: TestAccELBV2TargetGroup_attrsOnCreate (48.75s)
--- PASS: TestAccELBV2TargetGroup_TCP_httpHealthCheck (48.52s)
--- PASS: TestAccELBV2TargetGroup_A_lambda (17.42s)
--- PASS: TestAccELBV2TargetGroup_changeProtocolForceNew (60.90s)
--- PASS: TestAccELBV2TargetGroup_ProtocolTCPHealthCheck_protocol (48.89s)
--- PASS: TestAccELBV2TargetGroup_changeNameForceNew (59.06s)
--- SKIP: TestAccELBV2LoadBalancerDataSource_outpost (0.72s)
--- PASS: TestAccELBV2TargetGroup_A_generatedName (23.07s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersionHTTPGRPC_update (58.52s)
--- PASS: TestAccELBV2TargetGroupAttachment_lambda (35.86s)
--- PASS: TestAccELBV2TargetGroup_A_basic (23.65s)
--- PASS: TestAccELBV2TargetGroup_A_changeVPCForceNew (39.58s)
--- PASS: TestAccELBV2TargetGroup_A_changePortForceNew (43.69s)
--- PASS: TestAccELBV2TargetGroup_A_changeProtocolForceNew (46.89s)
--- PASS: TestAccELBV2TargetGroup_A_changeNameForceNew (46.80s)
--- PASS: TestAccELBV2ListenerCertificate_basic (202.90s)
--- PASS: TestAccELBV2TargetGroupAttachment_port (121.42s)
--- PASS: TestAccELBV2TargetGroupAttachment_ipAddress (126.46s)
--- PASS: TestAccELBV2TargetGroupAttachment_disappears (120.81s)
--- PASS: TestAccELBV2TargetGroupAttachment_backwardsCompatibility (133.67s)
--- PASS: TestAccELBV2TargetGroupAttachment_basic (120.74s)
--- PASS: TestAccELBV2LoadBalancerDataSource_backwardsCompatibility (271.74s)
--- PASS: TestAccELBV2ListenerRule_conditionHTTPHeader (198.89s)
--- SKIP: TestAccELBV2LoadBalancer_ALB_outpost (0.66s)
--- PASS: TestAccELBV2TargetGroupDataSource_basic (237.51s)
--- PASS: TestAccELBV2TargetGroupDataSource_appCookie (249.29s)
--- PASS: TestAccELBV2Listener_DefaultAction_orderRecreates (210.04s)
--- PASS: TestAccELBV2LoadBalancer_backwardsCompatibility (213.27s)
--- PASS: TestAccELBV2Listener_DefaultAction_order (232.26s)
--- PASS: TestAccELBV2LoadBalancer_NLB_privateIPv4Address (247.99s)
--- PASS: TestAccELBV2LoadBalancer_noSecurityGroup (212.91s)
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancerSubnet_change (221.80s)
--- PASS: TestAccELBV2TargetGroupDataSource_backwardsCompatibility (301.83s)
--- PASS: TestAccELBV2LoadBalancer_networkLoadBalancerEIP (242.33s)
--- PASS: TestAccELBV2LoadBalancerDataSource_basic (266.84s)
--- PASS: TestAccELBV2Listener_oidc (243.96s)
--- PASS: TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid (0.80s)
--- PASS: TestAccELBV2Listener_cognito (220.78s)
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerType_gateway (109.10s)
--- PASS: TestAccELBV2Listener_fixedResponse (222.29s)
--- PASS: TestAccELBV2LoadBalancer_namePrefix (224.37s)
--- PASS: TestAccELBV2LoadBalancer_generatesNameForZeroValue (222.77s)
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (183.52s)
--- PASS: TestAccELBV2LoadBalancer_updatedIPAddressType (294.65s)
--- PASS: TestAccELBV2LoadBalancer_generatedName (203.20s)
--- PASS: TestAccELBV2Listener_redirect (181.16s)
--- PASS: TestAccELBV2ListenerRule_conditionAttributesCount (18.91s)
--- PASS: TestAccELBV2Listener_Protocol_https (171.02s)
--- PASS: TestAccELBV2LoadBalancer_tags (325.08s)
--- PASS: TestAccELBV2ListenerRule_conditionMultiple (186.61s)
--- PASS: TestAccELBV2ListenerRule_conditionSourceIP (186.16s)
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMultiple (231.81s)
--- PASS: TestAccELBV2Listener_backwardsCompatibility (189.47s)
--- PASS: TestAccELBV2ListenerRule_conditionQueryString (198.83s)
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (263.29s)
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing (161.16s)
--- PASS: TestAccELBV2Listener_tags (214.30s)
--- PASS: TestAccELBV2Listener_forwardWeighted (228.14s)
--- PASS: TestAccELBV2LoadBalancer_ipv6SubnetMapping (224.18s)
--- PASS: TestAccELBV2ListenerRule_conditionPathPattern (173.32s)
--- PASS: TestAccELBV2ListenerRule_redirect (231.60s)
--- PASS: TestAccELBV2ListenerRule_ActionOrder_recreates (173.64s)
--- PASS: TestAccELBV2ListenerRule_conditionHTTPRequestMethod (179.73s)
--- PASS: TestAccELBV2Listener_Protocol_upd (340.78s)
--- PASS: TestAccELBV2Listener_basic (231.16s)
--- PASS: TestAccELBV2ListenerRule_basic (178.44s)
--- PASS: TestAccELBV2ListenerRule_tags (244.12s)
--- PASS: TestAccELBV2ListenerDataSource_https (223.58s)
--- PASS: TestAccELBV2ListenerRule_conditionHostHeader (249.25s)
--- PASS: TestAccELBV2ListenerRule_Action_order (188.12s)
--- PASS: TestAccELBV2ListenerDataSource_DefaultAction_forward (227.20s)
--- PASS: TestAccELBV2ListenerRule_forwardWeighted (225.45s)
--- PASS: TestAccELBV2ListenerRule_backwardsCompatibility (229.78s)
--- PASS: TestAccELBV2ListenerCertificate_multiple (237.61s)
--- PASS: TestAccELBV2ListenerRule_cognito (179.48s)
--- PASS: TestAccELBV2ListenerDataSource_backwardsCompatibility (243.20s)
--- PASS: TestAccELBV2ListenerRule_updateRulePriority (246.24s)
--- PASS: TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew (266.55s)
--- PASS: TestAccELBV2ListenerRule_oidc (271.72s)
--- PASS: TestAccELBV2ListenerRule_fixedResponse (197.34s)
--- PASS: TestAccELBV2ListenerCertificate_CertificateARN_underscores (198.06s)
--- PASS: TestAccELBV2ListenerCertificate_disappears (185.84s)
--- PASS: TestAccELBV2ListenerDataSource_basic (325.33s)
--- PASS: TestAccELBV2ListenerRule_updateFixedResponse (272.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	999.621s

@github-actions github-actions bot added verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/XS Managed by automation to categorize the size of a PR. labels Jan 21, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/events Issues and PRs that pertain to the events service. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 21, 2022
@YakDriver YakDriver added the partition/aws-iso Pertains to the aws-iso partition. label Jan 21, 2022
@YakDriver YakDriver merged commit 0a67faa into main Jan 21, 2022
@YakDriver YakDriver deleted the b-add-iso-tag-fixes branch January 21, 2022 17:12
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 21, 2022
github-actions bot pushed a commit that referenced this pull request Jan 21, 2022
@YakDriver YakDriver mentioned this pull request Jan 21, 2022
27 tasks
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-iso Pertains to the aws-iso partition. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/events Issues and PRs that pertain to the events service. size/L Managed by automation to categorize the size of a PR. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant