Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO tagging: Further refine error handling #22780

Merged
merged 22 commits into from Jan 27, 2022
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 26, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22532

Output from acceptance testing (us-west-2):

% make testacc TESTS='TestAccCloudWatchCompositeAlarm_|TestAccCloudWatchMetricAlarm_|TestAccCloudWatchMetricStream_' PKG=cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchCompositeAlarm_|TestAccCloudWatchMetricAlarm_|TestAccCloudWatchMetricStream_'  -timeout 180m
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (13.01s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (26.72s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (33.42s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (33.52s)
--- PASS: TestAccCloudWatchMetricStream_excludeFilters (42.16s)
--- PASS: TestAccCloudWatchMetricStream_includeFilters (42.32s)
--- PASS: TestAccCloudWatchMetricStream_noName (42.53s)
--- PASS: TestAccCloudWatchMetricStream_namePrefix (42.53s)
--- PASS: TestAccCloudWatchMetricStream_tags (42.72s)
--- PASS: TestAccCloudWatchCompositeAlarm_basic (43.08s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (43.55s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (34.45s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (55.60s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (32.65s)
--- PASS: TestAccCloudWatchCompositeAlarm_disappears (27.78s)
--- PASS: TestAccCloudWatchCompositeAlarm_updateAlarmRule (71.71s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (80.98s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (81.15s)
--- PASS: TestAccCloudWatchCompositeAlarm_description (57.67s)
--- PASS: TestAccCloudWatchCompositeAlarm_actionsEnabled (55.29s)
--- PASS: TestAccCloudWatchCompositeAlarm_allActions (58.41s)
--- PASS: TestAccCloudWatchCompositeAlarm_insufficientDataActions (83.96s)
--- PASS: TestAccCloudWatchCompositeAlarm_alarmActions (76.09s)
--- PASS: TestAccCloudWatchCompositeAlarm_okActions (76.05s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (129.37s)
--- PASS: TestAccCloudWatchMetricStream_basic (142.02s)
--- PASS: TestAccCloudWatchMetricStream_update (148.51s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (215.26s)
--- PASS: TestAccCloudWatchMetricStream_updateName (220.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	221.785s
% make testacc TESTS='TestAccECRRepository_|TestAccECRRepositoryDataSource_' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepository_|TestAccECRRepositoryDataSource_'  -timeout 180m
--- PASS: TestAccECRRepositoryDataSource_nonExistent (3.94s)
--- PASS: TestAccECRRepositoryDataSource_basic (21.01s)
--- PASS: TestAccECRRepository_immutability (21.38s)
--- PASS: TestAccECRRepository_basic (21.44s)
--- PASS: TestAccECRRepositoryDataSource_encryption (24.15s)
--- PASS: TestAccECRRepository_tags (31.58s)
--- PASS: TestAccECRRepository_Encryption_aes256 (39.39s)
--- PASS: TestAccECRRepository_Encryption_kms (40.86s)
--- PASS: TestAccECRRepository_Image_scanning (47.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	49.566s
% make testacc TESTS=TestAccSNSTopic_ PKG=sns
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopic_'  -timeout 180m
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (7.09s)
--- PASS: TestAccSNSTopic_disappears (35.10s)
--- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (46.06s)
--- PASS: TestAccSNSTopic_policy (46.37s)
--- PASS: TestAccSNSTopic_Name_fifoTopic (46.61s)
--- PASS: TestAccSNSTopic_namePrefix (46.62s)
--- PASS: TestAccSNSTopic_name (46.73s)
--- PASS: TestAccSNSTopic_withDeliveryPolicy (46.82s)
--- PASS: TestAccSNSTopic_basic (46.83s)
--- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (46.90s)
--- PASS: TestAccSNSTopic_withIAMRole (54.01s)
--- PASS: TestAccSNSTopic_deliveryStatus (57.76s)
--- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (65.13s)
--- PASS: TestAccSNSTopic_encryption (65.19s)
--- PASS: TestAccSNSTopic_tags (79.63s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (138.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	140.953s
% make testacc TESTS=TestAccSQSQueue PKG=sqs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20 -run='TestAccSQSQueue'  -timeout 180m
--- PASS: TestAccSQSQueue_FIFOQueue_expectNameError (5.57s)
--- PASS: TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError (5.74s)
--- PASS: TestAccSQSQueueDataSource_basic (72.77s)
--- PASS: TestAccSQSQueue_FIFOQueue_contentBasedDeduplication (77.75s)
--- PASS: TestAccSQSQueue_fifoQueue (77.75s)
--- PASS: TestAccSQSQueue_NamePrefix_fifoQueue (77.79s)
--- PASS: TestAccSQSQueue_namePrefix (77.93s)
--- PASS: TestAccSQSQueue_zeroVisibilityTimeoutSeconds (77.93s)
--- PASS: TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds (77.96s)
--- PASS: TestAccSQSQueue_basic (72.24s)
--- PASS: TestAccSQSQueue_NameGenerated_fifoQueue (78.03s)
--- PASS: TestAccSQSQueue_disappears (86.67s)
--- PASS: TestAccSQSQueue_Policy_ignoreEquivalent (98.05s)
--- PASS: TestAccSQSQueue_redriveAllowPolicy (106.47s)
--- PASS: TestAccSQSQueue_redrivePolicy (108.07s)
--- PASS: TestAccSQSQueue_Policy_basic (108.73s)
--- PASS: TestAccSQSQueue_tags (116.71s)
--- PASS: TestAccSQSQueue_update (122.72s)
--- PASS: TestAccSQSQueue_FIFOQueue_highThroughputMode (123.73s)
--- PASS: TestAccSQSQueuePolicy_disappears (131.10s)
--- PASS: TestAccSQSQueue_Name_generated (58.80s)
--- PASS: TestAccSQSQueueDataSource_tags (60.49s)
--- PASS: TestAccSQSQueue_recentlyDeleted (146.98s)
--- PASS: TestAccSQSQueue_encryption (162.85s)
--- PASS: TestAccSQSQueuePolicy_Disappears_queue (118.68s)
--- PASS: TestAccSQSQueuePolicy_basic (118.83s)
--- PASS: TestAccSQSQueuePolicy_update (146.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	220.440s
% make testacc TESTS='TestAccECSCapacityProvider_|TestAccECSCluster_|TestAccECSClusterDataSource_|TestAccECSService_|TestAccECSTaskDefinition_|TestAccECSTaskSet_' PKG=ecs TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSCapacityProvider_|TestAccECSCluster_|TestAccECSClusterDataSource_|TestAccECSService_|TestAccECSTaskDefinition_|TestAccECSTaskSet_' -short -timeout 180m
--- SKIP: TestAccECSService_healthCheckGracePeriodSeconds (0.00s)
--- SKIP: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (0.00s)
--- SKIP: TestAccECSService_ServiceRegistries_changes (0.00s)
--- SKIP: TestAccECSTaskDefinition_fsxWinFileSystem (0.00s)
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (23.53s)
--- PASS: TestAccECSTaskDefinition_disappears (38.20s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (39.01s)
--- PASS: TestAccECSTaskDefinition_proxy (40.83s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (45.58s)
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (26.56s)
--- PASS: TestAccECSTaskDefinition_executionRole (29.29s)
--- PASS: TestAccECSTaskSet_basic (68.02s)
--- PASS: TestAccECSTaskSet_withExternalId (71.83s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargate (75.50s)
--- PASS: TestAccECSTaskDefinition_tags (75.51s)
--- PASS: TestAccECSTaskDefinition_Fargate_basic (35.66s)
--- PASS: TestAccECSCapacityProvider_basic (77.48s)
--- PASS: TestAccECSTaskDefinition_basic (39.50s)
--- PASS: TestAccECSTaskSet_withScale (89.27s)
--- PASS: TestAccECSTaskSet_withMultipleCapacityProviderStrategies (90.06s)
--- PASS: TestAccECSTaskSet_disappears (98.97s)
--- PASS: TestAccECSTaskSet_Tags (104.05s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (39.78s)
--- PASS: TestAccECSTaskDefinition_arrays (31.61s)
--- PASS: TestAccECSTaskDefinition_constraint (34.18s)
--- PASS: TestAccECSService_executeCommand (112.75s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (44.31s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (37.37s)
--- PASS: TestAccECSService_LaunchTypeEC2_network (122.55s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (39.62s)
--- PASS: TestAccECSTaskDefinition_runtimePlatform (40.03s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (61.63s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (38.23s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion (137.75s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (38.10s)
--- PASS: TestAccECSTaskSet_withServiceRegistries (144.73s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (39.45s)
--- PASS: TestAccECSTaskDefinition_pidMode (39.36s)
--- PASS: TestAccECSTaskDefinition_ipcMode (37.79s)
--- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (153.31s)
--- PASS: TestAccECSService_Tags_managed (86.60s)
--- PASS: TestAccECSService_PlacementStrategy_missing (1.96s)
--- PASS: TestAccECSTaskDefinition_networkMode (35.18s)
--- PASS: TestAccECSTaskDefinition_taskRoleARN (31.97s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (59.90s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (48.21s)
--- PASS: TestAccECSService_replicaSchedulingStrategy (86.77s)
--- PASS: TestAccECSService_PlacementConstraints_basic (58.21s)
--- PASS: TestAccECSTaskSet_withAlb (209.03s)
--- PASS: TestAccECSService_Tags_basic (142.67s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (13.67s)
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (78.95s)
--- PASS: TestAccECSTaskDefinition_service (105.60s)
--- PASS: TestAccECSService_forceNewDeployment (86.07s)
--- PASS: TestAccECSService_Tags_propagate (223.44s)
--- PASS: TestAccECSService_ServiceRegistries_container (177.85s)
--- PASS: TestAccECSService_clusterName (89.50s)
--- PASS: TestAccECSService_PlacementStrategy_basic (107.94s)
--- PASS: TestAccECSService_basicImport (75.22s)
--- PASS: TestAccECSClusterDataSource_ecsCluster (25.77s)
--- PASS: TestAccECSCluster_containerInsights (63.77s)
--- PASS: TestAccECSCluster_configuration (53.89s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (154.52s)
--- PASS: TestAccECSService_ServiceRegistries_basic (174.34s)
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (87.28s)
--- PASS: TestAccECSService_basic (81.73s)
--- PASS: TestAccECSCluster_disappears (21.87s)
--- PASS: TestAccECSService_deploymentCircuitBreaker (71.72s)
--- PASS: TestAccECSService_loadBalancerChanges (135.27s)
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (178.80s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (188.10s)
--- PASS: TestAccECSService_DeploymentValues_basic (72.72s)
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (87.60s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (195.95s)
--- PASS: TestAccECSCluster_basic (35.01s)
--- PASS: TestAccECSService_DeploymentControllerType_external (47.98s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (138.72s)
--- PASS: TestAccECSService_disappears (70.48s)
--- PASS: TestAccECSClusterDataSource_ecsClusterContainerInsights (39.72s)
--- PASS: TestAccECSCluster_tags (68.52s)
--- PASS: TestAccECSService_iamRole (66.08s)
--- PASS: TestAccECSCluster_singleCapacityProvider (89.53s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (190.41s)
--- PASS: TestAccECSService_alb (243.57s)
--- PASS: TestAccECSCapacityProvider_disappears (61.22s)
--- PASS: TestAccECSCluster_capacityProviders (64.77s)
--- PASS: TestAccECSCluster_capacityProvidersNoStrategy (66.60s)
--- PASS: TestAccECSCapacityProvider_managedScaling (119.68s)
--- PASS: TestAccECSCluster_capacityProvidersUpdate (95.73s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (297.65s)
--- PASS: TestAccECSService_renamedCluster (122.01s)
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (119.45s)
--- PASS: TestAccECSService_familyAndRevision (118.90s)
--- PASS: TestAccECSCapacityProvider_tags (135.24s)
--- PASS: TestAccECSService_CapacityProviderStrategy_multiple (139.52s)
--- PASS: TestAccECSService_multipleTargetGroups (329.27s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (239.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	550.733s
% make testacc TESTS='TestAccEventsBus_|TestAccEventsRule_' PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_|TestAccEventsRule_'  -timeout 180m
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
--- PASS: TestAccEventsBus_default (2.79s)
--- PASS: TestAccEventsBus_disappears (16.55s)
--- PASS: TestAccEventsRule_namePrefix (23.30s)
--- PASS: TestAccEventsRule_Name_generated (23.37s)
--- PASS: TestAccEventsRule_scheduleAndPattern (23.38s)
--- PASS: TestAccEventsRule_eventBusARN (24.05s)
--- PASS: TestAccEventsRule_role (31.35s)
--- PASS: TestAccEventsRule_pattern (34.31s)
--- PASS: TestAccEventsRule_description (34.49s)
--- PASS: TestAccEventsBus_basic (45.64s)
--- PASS: TestAccEventsRule_basic (46.64s)
--- PASS: TestAccEventsRule_isEnabled (46.71s)
--- PASS: TestAccEventsRule_eventBusName (51.31s)
--- PASS: TestAccEventsBus_tags (53.54s)
--- PASS: TestAccEventsRule_tags (56.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	57.958s

@github-actions github-actions bot added verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/S Managed by automation to categorize the size of a PR. labels Jan 26, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@github-actions github-actions bot added service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 26, 2022
@github-actions github-actions bot added service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 27, 2022
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jan 27, 2022
@github-actions github-actions bot added the service/cloudwatch Issues and PRs that pertain to the cloudwatch service. label Jan 27, 2022
@github-actions github-actions bot added service/events Issues and PRs that pertain to the events service. and removed service/events Issues and PRs that pertain to the events service. labels Jan 27, 2022
@YakDriver YakDriver merged commit a7ab48c into main Jan 27, 2022
@YakDriver YakDriver deleted the b-iso-tagging-cleanup2 branch January 27, 2022 02:01
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 27, 2022
github-actions bot pushed a commit that referenced this pull request Jan 27, 2022
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. service/iam Issues and PRs that pertain to the iam service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants