Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_elasticsearch_domain: Add log_publishing_options #2285

Merged
merged 4 commits into from
Dec 11, 2017
Merged

r/aws_elasticsearch_domain: Add log_publishing_options #2285

merged 4 commits into from
Dec 11, 2017

Conversation

atsushi-ishibashi
Copy link
Contributor

@atsushi-ishibashi atsushi-ishibashi commented Nov 14, 2017 •
edited by radeksimko
Loading

Closes #1953
Closes #2280

@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. size/M Managed by automation to categorize the size of a PR. labels Nov 15, 2017
@atsushi-ishibashi
Copy link
Contributor Author

atsushi-ishibashi commented Nov 17, 2017 •
edited
Loading

Require #2337
After #2337 will be merged, I'll proceed to implement.

@radeksimko
Copy link
Member

Hey @atsushi-ishibashi
FYI - I just merged #2243 so there should be no more blockers here. 😺

@atsushi-ishibashi
Copy link
Contributor Author

Ok👍 @radeksimko

TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticSearchDomain_LogPublishingOptions -timeout 120m
=== RUN   TestAccAWSElasticSearchDomain_LogPublishingOptions
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (868.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	868.977s

@atsushi-ishibashi atsushi-ishibashi changed the title [WIP]r/aws_elasticsearch_domain: Add LogPublishingOption r/aws_elasticsearch_domain: Add LogPublishingOption Dec 7, 2017
radeksimko
radeksimko reviewed Dec 8, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except one comment this is looking good.

I'm running all ES acceptance tests from your branch just to be sure - I'll let you know if anything pops up. 😉

aws/resource_aws_elasticsearch_domain.go Outdated
return
},
},
"cloud_watch_logs_log_group_arn": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Can you make this cloudwatch_log_group_arn?

We use cloudwatch (written together) in other resources and aws_cloudwatch_log_group is a resource name too. I'm aware we'll drift from the API here, but I think it's 👌 to make an exception as the name they use there is really odd.

@radeksimko radeksimko added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 8, 2017
@atsushi-ishibashi
Copy link
Contributor Author

Ok👍 @radeksimko

@radeksimko radeksimko removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 11, 2017
@radeksimko radeksimko merged commit f413876 into hashicorp:master Dec 11, 2017
@radeksimko radeksimko changed the title r/aws_elasticsearch_domain: Add LogPublishingOption r/aws_elasticsearch_domain: Add log_publishing_options Dec 11, 2017
psyvision added a commit to psyvision/terraform-provider-aws that referenced this pull request Dec 12, 2017
@psyvision
Update from terraform master (#13)
0a085fb 
* Add Data Source: aws_elb

* Fix dataSourceAwsElb typo

* Fix dataSourceAwsElb Schema name field to not include Computed

* Remove dataSourceAwsElb schema defaults for computed fields

* Remove dataSourceAwsElb schema defaults for nested computed fields too

* Corrected depends_on entry for EIP

  depends_on                = ["aws_internet_gateway.gw"] is the correct syntax

* Add sweeper for IAM Server Certificates

* test/aws_config_delivery_channel: Add missing dependencies

* d/aws_elb r/aws_elb: hashicorp#2004 review comments

* Remove enable_deletion_protection from testAccDataSourceAWSELBConfigBasic
* Replace unnecessary errwrap.Wrapf with fmt.Errorf
* Reduce flattenAwsELbResource to ec2conn and elbconn instead of meta
* Properly name TestAccDataSourceAWSELB_basic resources
* Use t.Name() for description and TestName tags

* d/aws_elb: Fix documentation sidebar ordering after merging master with new d/aws_elasticache_replication_group

* Makefile: Add sweep target

* Update cognito_user_pool.markdown

* Update CHANGELOG.md

* r/aws_elasticache_security_group: add import support (hashicorp#2277)

* r/aws_elasticache_security_group: add import support

* r/aws_elasticache_security_group: hashicorp#2277 review updates

* Use d.Id() instead of d.Get("name") on read, which allows using schema.ImportStatePassthrough
* d.Set("security_group_names") on read
* Set AWS_DEFAULT_REGION to us-east-1 on import testing

* Update CHANGELOG.md

* documentation: remove antislashes in page titles

* Added missing WARN debug lines when reading a non-existing resource

* Removed <wbr> from documentation titles

* vendor: Bump aws-sdk-go to v.1.12.44

* Add logs for iam server certificate delete conflict (hashicorp#2533)

* Query elb API for load balancer arn causing delete conflict

- For IAM server certificate.

* Use regex for lb name.

* Edits for hashicorp#2533

* r/aws_sqs_queue_policy: Support import by queue URL (hashicorp#2544)

* Update CHANGELOG.md

* r/aws_elasticsearch_domain: Add LogPublishingOption (hashicorp#2285)

* WIP

* Add enabled

* Use cwl policy

* Reflect reviews

* Update CHANGELOG.md

* Add force_destroy field to aws_athena_database (hashicorp#2363)

* Add force_destroy field to aws_athena_database.

Fixes hashicorp#2362.

* Remove unnecessary import.

* Code review feedback

* Update CHANGELOG.md

* Add more example and missing field

* New Resource: aws_media_store_container (hashicorp#2448)

* New Resource: aws_media_store_container

* Reflect reviews

* remove policy

* Update CHANGELOG.md

* Add Redis AUTH, in-transit and at-rest encryption (hashicorp#2090)

* add AUTH, at-rest and in-transit encryption to Elasticache replication groups

* add _enabled to transit/at_rest encyrption parameters

* added one more _enabled

* move validateAwsElastiCacheReplicationGroupAuthToken to aws/validators.go, as well as tests

* set auth_token to nil during Reads

* update Replication Group encryption acceptance tests to use config functions instead of vars

* Fix whitespacing (tabs -> spaces)

* docs/elasticache_replication_group: Add missing fields

* Update CHANGELOG.md

* r/aws_dynamodb_table: Ensure ttl is properly read (hashicorp#2452)

* r/aws_dynamodb_table: Ensure ttl is properly read

* r/aws_dynamodb_table: hashicorp#2452 review updates

* Add timeToLiveOutput.TimeToLiveDescription nil check
* Simplify logic to d.Set ttl

* Update CHANGELOG.md

* Bump aws-sdk-go to v.1.12.45

* New Resource: PublicDnsNamespace (hashicorp#2569)

* WIP

* Add test, docs

* Reflect reviews

* Modify error handling

* Update CHANGELOG.md

* New Resource: ServiceDiscovery PrivateDNS Namespace (hashicorp#2589)

* New Resource: service_discovery_private_dns_namespace

* Reflect reviews

* Update CHANGELOG.md
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko left review comments

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
2 participants
@atsushi-ishibashi @radeksimko