Fix ECS semgrep prefer-aws-go-sdk-pointer-conversion-conditional errors

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #12992.

Fixes:

Findings:

  internal/service/ecs/task_definition.go 
     prefer-aws-go-sdk-pointer-conversion-conditional
        Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g.
        aws.StringValue()

        963┆ if scope == nil || *scope != ecs.ScopeTask || v.(bool) {


  internal/service/ecs/task_definition_equivalency.go 
     prefer-aws-go-sdk-pointer-conversion-conditional
        Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g.
        aws.StringValue()

         64┆ if def.Cpu != nil && *def.Cpu == 0 {
          ⋮┆----------------------------------------
         71┆ if pm.Protocol != nil && *pm.Protocol == "tcp" {
          ⋮┆----------------------------------------
         74┆ if pm.HostPort != nil && *pm.HostPort == 0 {

% make testacc TESTARGS='-short -run=TestAccECSTaskDefinition_' PKG=ecs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 2  -short -run=TestAccECSTaskDefinition_ -timeout 180m
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_scratchVolume
=== PAUSE TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_minimal
=== PAUSE TestAccECSTaskDefinition_DockerVolume_minimal
=== RUN   TestAccECSTaskDefinition_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== RUN   TestAccECSTaskDefinition_EFSVolume_minimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_minimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== RUN   TestAccECSTaskDefinition_fsxWinFileSystem
    task_definition_test.go:433: skipping long-running test in short mode
--- SKIP: TestAccECSTaskDefinition_fsxWinFileSystem (0.00s)
=== RUN   TestAccECSTaskDefinition_DockerVolume_taskScoped
=== PAUSE TestAccECSTaskDefinition_DockerVolume_taskScoped
=== RUN   TestAccECSTaskDefinition_service
=== PAUSE TestAccECSTaskDefinition_service
=== RUN   TestAccECSTaskDefinition_taskRoleARN
=== PAUSE TestAccECSTaskDefinition_taskRoleARN
=== RUN   TestAccECSTaskDefinition_networkMode
=== PAUSE TestAccECSTaskDefinition_networkMode
=== RUN   TestAccECSTaskDefinition_ipcMode
=== PAUSE TestAccECSTaskDefinition_ipcMode
=== RUN   TestAccECSTaskDefinition_pidMode
=== PAUSE TestAccECSTaskDefinition_pidMode
=== RUN   TestAccECSTaskDefinition_constraint
=== PAUSE TestAccECSTaskDefinition_constraint
=== RUN   TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccECSTaskDefinition_arrays
=== PAUSE TestAccECSTaskDefinition_arrays
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccECSTaskDefinition_executionRole
=== PAUSE TestAccECSTaskDefinition_executionRole
=== RUN   TestAccECSTaskDefinition_disappears
=== PAUSE TestAccECSTaskDefinition_disappears
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskDefinition_proxy
=== PAUSE TestAccECSTaskDefinition_proxy
=== RUN   TestAccECSTaskDefinition_inferenceAccelerator
=== PAUSE TestAccECSTaskDefinition_inferenceAccelerator
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSTaskDefinition_networkMode
--- PASS: TestAccECSTaskDefinition_networkMode (24.30s)
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
--- PASS: TestAccECSTaskDefinition_basic (34.05s)
=== CONT  TestAccECSTaskDefinition_proxy
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (17.00s)
=== CONT  TestAccECSTaskDefinition_tags
--- PASS: TestAccECSTaskDefinition_proxy (28.28s)
=== CONT  TestAccECSTaskDefinition_disappears
--- PASS: TestAccECSTaskDefinition_disappears (27.63s)
=== CONT  TestAccECSTaskDefinition_executionRole
--- PASS: TestAccECSTaskDefinition_tags (53.63s)
=== CONT  TestAccECSTaskDefinition_Fargate_ephemeralStorage
--- PASS: TestAccECSTaskDefinition_executionRole (18.56s)
=== CONT  TestAccECSTaskDefinition_Fargate_basic
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (17.42s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskDefinition_arrays (18.23s)
=== CONT  TestAccECSTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccECSTaskDefinition_Fargate_basic (26.24s)
=== CONT  TestAccECSTaskDefinition_constraint
--- PASS: TestAccECSTaskDefinition_constraint (16.22s)
=== CONT  TestAccECSTaskDefinition_pidMode
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (27.63s)
=== CONT  TestAccECSTaskDefinition_ipcMode
--- PASS: TestAccECSTaskDefinition_pidMode (17.85s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
--- PASS: TestAccECSTaskDefinition_ipcMode (17.80s)
=== CONT  TestAccECSTaskDefinition_taskRoleARN
--- PASS: TestAccECSTaskDefinition_taskRoleARN (19.53s)
=== CONT  TestAccECSTaskDefinition_service
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (27.38s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_taskScoped
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (15.94s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (36.33s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (24.90s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
--- PASS: TestAccECSTaskDefinition_service (96.49s)
=== CONT  TestAccECSTaskDefinition_runtimePlatform
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (25.73s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
--- PASS: TestAccECSTaskDefinition_runtimePlatform (17.55s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (18.16s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (17.31s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (16.98s)
=== CONT  TestAccECSTaskDefinition_scratchVolume
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (16.69s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (16.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	361.254s

[bschaatsbergen]

LGTM

[gdavison]

Looks good. One comment, but not a blocker. 🚀

--- PASS: TestContainerDefinitionsAreEquivalent_basic (0.00s)
--- PASS: TestContainerDefinitionsAreEquivalent_portMappings (0.00s)
--- PASS: TestContainerDefinitionsAreEquivalent_portMappingsIgnoreHostPort (0.00s)
--- PASS: TestContainerDefinitionsAreEquivalent_arrays (0.00s)
--- PASS: TestContainerDefinitionsAreEquivalent_negative (0.00s)
--- PASS: TestContainerDefinitionsAreEquivalent_missingEnvironmentName (0.00s)
--- PASS: TestValidTaskDefinitionContainerDefinitions (0.00s)
--- PASS: TestAccECSTaskDefinitionDataSource_ecsTaskDefinition (143.62s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (145.74s)
--- PASS: TestAccECSTaskDefinition_arrays (145.91s)
--- PASS: TestAccECSTaskDefinition_constraint (146.90s)
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (147.80s)
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (149.56s)
--- PASS: TestAccECSTaskDefinition_networkMode (150.06s)
--- PASS: TestAccECSTaskDefinition_pidMode (150.18s)
--- PASS: TestAccECSTaskDefinition_taskRoleARN (151.35s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (152.46s)
--- PASS: TestAccECSTaskDefinition_executionRole (155.93s)
--- PASS: TestAccECSTaskDefinition_ipcMode (156.35s)
--- PASS: TestAccECSTaskDefinition_proxy (159.58s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (161.90s)
--- PASS: TestAccECSTaskDefinition_Fargate_basic (190.49s)
--- PASS: TestAccECSTaskDefinition_disappears (204.32s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (210.58s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (93.29s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (96.02s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (93.75s)
--- PASS: TestAccECSTaskDefinition_runtimePlatform (96.30s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (94.07s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (98.44s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (103.14s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (102.02s)
--- PASS: TestAccECSTaskDefinition_tags (252.94s)
--- PASS: TestAccECSTaskDefinition_basic (108.19s)
--- PASS: TestAccECSTaskDefinition_service (266.94s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (3489.53s)

[github-actions]

This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.