Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: add DataSourceCliToken + Read #25559

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] feat: add DataSourceCliToken + Read #25559

wants to merge 2 commits into from

Conversation

ErwinRakoto
Copy link

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/mwaa Issues and PRs that pertain to the mwaa service. size/S Managed by automation to categorize the size of a PR. labels Jun 24, 2022
@ErwinRakoto
Copy link
Author

Hello !
I don't know about aceptance test. Could anyone send me some informations about that.
Erwin

github-actions[bot]
github-actions bot reviewed Jun 24, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ErwinRakoto 馃憢

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven鈥檛 already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 馃槂

@ErwinRakoto ErwinRakoto force-pushed the feature-add_datasource_cli_mwaa_token branch from b245654 to 54fb356 Compare June 24, 2022 13:45
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jun 24, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jun 28, 2022
@justinretzolk
Copy link
Member

Hey @ErwinRakoto 馃憢 Thank you for your contribution! We have a guide on acceptance test in our contribution guide. If you're having troubles with them, let us know, and one of our maintainers can help work on them when this is prioritized.

@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/mwaa Issues and PRs that pertain to the mwaa service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ErwinRakoto @justinretzolk