Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oversize_Handling to AWS WAF v2 Web ACL #25589

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Jun 27, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25545

Output from acceptance testing:

bruno@pop-os ~/G/terraform-provider-aws (enhancement/#25545-add-oversize-handling-to-wafv2-web-acl)> make testacc TESTS=TestAccWAFV2WebACL_ PKG=wafv2                                                                                        (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafv2/... -v -count 1 -parallel 20 -run='TestAccWAFV2WebACL_'  -timeout 180m
=== RUN   TestAccWAFV2WebACL_basic
=== PAUSE TestAccWAFV2WebACL_basic
=== RUN   TestAccWAFV2WebACL_Update_rule
=== PAUSE TestAccWAFV2WebACL_Update_rule
=== RUN   TestAccWAFV2WebACL_Update_ruleProperties
=== PAUSE TestAccWAFV2WebACL_Update_ruleProperties
=== RUN   TestAccWAFV2WebACL_Update_nameForceNew
=== PAUSE TestAccWAFV2WebACL_Update_nameForceNew
=== RUN   TestAccWAFV2WebACL_disappears
=== PAUSE TestAccWAFV2WebACL_disappears
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_basic
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_basic
=== RUN   TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion
=== PAUSE TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion
=== RUN   TestAccWAFV2WebACL_minimal
=== PAUSE TestAccWAFV2WebACL_minimal
=== RUN   TestAccWAFV2WebACL_RateBased_basic
=== PAUSE TestAccWAFV2WebACL_RateBased_basic
=== RUN   TestAccWAFV2WebACL_GeoMatch_basic
=== PAUSE TestAccWAFV2WebACL_GeoMatch_basic
=== RUN   TestAccWAFV2WebACL_GeoMatch_forwardedIP
=== PAUSE TestAccWAFV2WebACL_GeoMatch_forwardedIP
=== RUN   TestAccWAFV2WebACL_LabelMatchStatement
=== PAUSE TestAccWAFV2WebACL_LabelMatchStatement
=== RUN   TestAccWAFV2WebACL_RuleLabels
=== PAUSE TestAccWAFV2WebACL_RuleLabels
=== RUN   TestAccWAFV2WebACL_IPSetReference_basic
=== PAUSE TestAccWAFV2WebACL_IPSetReference_basic
=== RUN   TestAccWAFV2WebACL_IPSetReference_forwardedIP
=== PAUSE TestAccWAFV2WebACL_IPSetReference_forwardedIP
=== RUN   TestAccWAFV2WebACL_RateBased_forwardedIP
=== PAUSE TestAccWAFV2WebACL_RateBased_forwardedIP
=== RUN   TestAccWAFV2WebACL_RuleGroupReference_basic
=== PAUSE TestAccWAFV2WebACL_RuleGroupReference_basic
=== RUN   TestAccWAFV2WebACL_Custom_requestHandling
=== PAUSE TestAccWAFV2WebACL_Custom_requestHandling
=== RUN   TestAccWAFV2WebACL_Custom_response
=== PAUSE TestAccWAFV2WebACL_Custom_response
=== RUN   TestAccWAFV2WebACL_tags
=== PAUSE TestAccWAFV2WebACL_tags
=== RUN   TestAccWAFV2WebACL_RateBased_maxNested
=== PAUSE TestAccWAFV2WebACL_RateBased_maxNested
=== RUN   TestAccWAFV2WebACL_Operators_maxNested
=== PAUSE TestAccWAFV2WebACL_Operators_maxNested
=== CONT  TestAccWAFV2WebACL_basic
=== CONT  TestAccWAFV2WebACL_Operators_maxNested
=== CONT  TestAccWAFV2WebACL_RuleLabels
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_basic
=== CONT  TestAccWAFV2WebACL_Update_nameForceNew
=== CONT  TestAccWAFV2WebACL_RateBased_forwardedIP
=== CONT  TestAccWAFV2WebACL_IPSetReference_forwardedIP
=== CONT  TestAccWAFV2WebACL_IPSetReference_basic
=== CONT  TestAccWAFV2WebACL_LabelMatchStatement
=== CONT  TestAccWAFV2WebACL_RuleGroupReference_basic
=== CONT  TestAccWAFV2WebACL_Custom_response
=== CONT  TestAccWAFV2WebACL_Custom_requestHandling
=== CONT  TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion
=== CONT  TestAccWAFV2WebACL_RateBased_maxNested
=== CONT  TestAccWAFV2WebACL_GeoMatch_forwardedIP
=== CONT  TestAccWAFV2WebACL_GeoMatch_basic
=== CONT  TestAccWAFV2WebACL_tags
=== CONT  TestAccWAFV2WebACL_RateBased_basic
=== CONT  TestAccWAFV2WebACL_Update_ruleProperties
=== CONT  TestAccWAFV2WebACL_minimal
--- PASS: TestAccWAFV2WebACL_basic (32.87s)
=== CONT  TestAccWAFV2WebACL_disappears
--- PASS: TestAccWAFV2WebACL_Operators_maxNested (40.49s)
=== CONT  TestAccWAFV2WebACL_Update_rule
--- PASS: TestAccWAFV2WebACL_minimal (44.94s)
--- PASS: TestAccWAFV2WebACL_RateBased_maxNested (51.33s)
--- PASS: TestAccWAFV2WebACL_disappears (21.80s)
--- PASS: TestAccWAFV2WebACL_Custom_requestHandling (56.39s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_basic (58.23s)
--- PASS: TestAccWAFV2WebACL_GeoMatch_forwardedIP (61.44s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_specifyVersion (61.66s)
--- PASS: TestAccWAFV2WebACL_RuleLabels (63.78s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_basic (63.99s)
--- PASS: TestAccWAFV2WebACL_RateBased_basic (66.80s)
--- PASS: TestAccWAFV2WebACL_RateBased_forwardedIP (69.81s)
--- PASS: TestAccWAFV2WebACL_RuleGroupReference_basic (74.75s)
--- PASS: TestAccWAFV2WebACL_Update_nameForceNew (81.59s)
--- PASS: TestAccWAFV2WebACL_ManagedRuleGroup_basic (86.50s)
--- PASS: TestAccWAFV2WebACL_tags (89.92s)
--- PASS: TestAccWAFV2WebACL_Update_ruleProperties (90.36s)
--- PASS: TestAccWAFV2WebACL_Update_rule (51.43s)
--- PASS: TestAccWAFV2WebACL_LabelMatchStatement (107.49s)
--- PASS: TestAccWAFV2WebACL_Custom_response (108.44s)
--- PASS: TestAccWAFV2WebACL_IPSetReference_forwardedIP (112.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafv2      112.679s

@github-actions github-actions bot added service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed service/wafv2 Issues and PRs that pertain to the wafv2 service. labels Jun 27, 2022
@github-actions github-actions bot added the service/wafv2 Issues and PRs that pertain to the wafv2 service. label Jun 27, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 27, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review June 27, 2022 20:59
@bschaatsbergen bschaatsbergen marked this pull request as draft June 28, 2022 20:11
@bschaatsbergen
Copy link
Member Author

apparently the placement of the oversize_handling in this PR isn't correctly. I'm going to sort out where it should be part of the schema...

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jun 30, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review June 30, 2022 18:26
@bschaatsbergen
Copy link
Member Author

bschaatsbergen commented Jun 30, 2022

By looking at the documentation there's also OverSizeHandling properties for Cookies and Headers but we don't have the 'cookies' and 'headers' attributes as of now as part of the field_to_match attribute configuration block.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 8, 2022
@bschaatsbergen bschaatsbergen marked this pull request as draft July 12, 2022 21:27
@bschaatsbergen
Copy link
Member Author

Closing this, someone else can pick it up if she/he wants to.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Oversize_Handling to AWS WAF v2
2 participants