Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider multiplexing - Phase 0 #25606

Merged
merged 9 commits into from
Jul 5, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 28, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23948.

Introduces a minimal first step for combining (using terraform-plugin-mux) into a single binary the current resource and data sources implemented using Terraform Plugin SDK v2 with other future implementations (such as using Terraform Plugin Framework).

This PR

  • Adds to internal/provider a muxed provider factory that combines the current Terraform Plugin SDK v2 Provider implementation with 0 additional providers
  • Invokes this muxed provider factory from the provider's main function

All existing acceptance tests will run unchanged. For example:

% make testacc TESTARGS='-run=TestAccVPC_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_basic -timeout 180m
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== CONT  TestAccVPC_basic
--- PASS: TestAccVPC_basic (28.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	35.228s

Subsequent Phases

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/cur Issues and PRs that pertain to the cur service. service/fms Issues and PRs that pertain to the fms service. service/lightsail Issues and PRs that pertain to the lightsail service. service/pricing Issues and PRs that pertain to the pricing service. service/route53 Issues and PRs that pertain to the route53 service. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jun 28, 2022
@ewbankkit ewbankkit changed the title [WIP] Provider muxing - Phase 0 Provider multiplexing - Phase 0 Jun 28, 2022
@ewbankkit

This comment was marked as outdated.

@github-actions github-actions bot removed service/cur Issues and PRs that pertain to the cur service. service/route53 Issues and PRs that pertain to the route53 service. service/fms Issues and PRs that pertain to the fms service. service/waf Issues and PRs that pertain to the waf service. service/lightsail Issues and PRs that pertain to the lightsail service. service/apigateway Issues and PRs that pertain to the apigateway service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/pricing Issues and PRs that pertain to the pricing service. size/L Managed by automation to categorize the size of a PR. labels Jul 1, 2022
@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Jul 1, 2022
@ewbankkit

This comment was marked as resolved.

@ewbankkit ewbankkit merged commit 7211783 into main Jul 5, 2022
@ewbankkit ewbankkit deleted the f-protov5-mux-terraform-plugin-framework-phase0 branch July 5, 2022 23:07
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 5, 2022
github-actions bot pushed a commit that referenced this pull request Jul 5, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant