Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: aws_fms_protocol to support fms protocol lists #25773

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

New resource: aws_fms_protocol to support fms protocol lists #25773

wants to merge 3 commits into from

Conversation

fdmsantos
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25323

Output from acceptance testing:

$ make testacc TESTS=TestAccProtocolList PKG=fms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fms/... -v -count 1 -parallel 20 -run='TestAccProtocolList'  -timeout 180m
=== RUN   TestAccProtocolList_basic
--- PASS: TestAccProtocolList_basic (38.77s)
=== RUN   TestAccProtocolList_update
--- PASS: TestAccProtocolList_update (75.78s)
=== RUN   TestAccProtocolList_tags
--- PASS: TestAccProtocolList_tags (50.15s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fms        164.791s

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. provider Pertains to the provider itself, rather than any interaction with AWS. service/fms Issues and PRs that pertain to the fms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 11, 2022
@fdmsantos fdmsantos changed the title Firewall Manager (FMS): Add Support to Protocol Lists New resource: aws_fms_protocol to support fms protocol lists Jul 13, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2022
@fdmsantos
Copy link
Contributor Author

Any news about this PR?

1 similar comment
@fdmsantos
Copy link
Contributor Author

Any news about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/fms Issues and PRs that pertain to the fms service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firewall Manager (FMS): Support Protocol Lists
2 participants
@fdmsantos @justinretzolk