Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_ssoadmin_customer_managed_policy_attachment #25915

Merged
merged 34 commits into from
Sep 8, 2022
Merged
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
0163939
Rough draft of customer managed policy
rebecca-liveeo Jul 21, 2022
3c260a8
WIP update on customer managed policy attachment
rebecca-liveeo Jul 21, 2022
fffa657
Update customer managed policy attach and add policy find function
rebecca-liveeo Jul 21, 2022
e069e34
Add resource to provider and format
rebecca-liveeo Jul 21, 2022
3958870
Add ForceNew in resource schema
rebecca-liveeo Jul 21, 2022
f45770d
Add first working tests for customer managed policy attachment
rebecca-liveeo Jul 21, 2022
0d0a441
Add remaining acceptance tests for customer managed policy attachment
rebecca-liveeo Jul 21, 2022
518d85b
Add documentation for customer managed polict attachment
rebecca-liveeo Jul 22, 2022
2e0dda9
Remove comments and add changelog
rebecca-liveeo Jul 22, 2022
5e92a9d
Update changelog
rebecca-liveeo Jul 25, 2022
e43b8fe
Add retry conditions to customer managed policy attach and detach
rebecca-liveeo Jul 25, 2022
755452c
Change schema to use config block for policy reference
rebecca-liveeo Jul 26, 2022
d6646b3
Update import and tests for policy ref config block
rebecca-liveeo Jul 27, 2022
6e699c6
Ensure policy find function matches on both path and name
rebecca-liveeo Jul 27, 2022
4cef97f
Ensure alphabetical order of resources
rebecca-liveeo Jul 27, 2022
85658f6
Update documentation
rebecca-liveeo Jul 28, 2022
0ee775a
Minor formatting update to documentation
rebecca-liveeo Jul 28, 2022
4e96ce6
Simplify helper functions
rebecca-liveeo Jul 28, 2022
1c21b26
Update formatting on markdown
rebecca-liveeo Aug 2, 2022
c7e814a
Update deprecated acctest vars
rebecca-liveeo Aug 2, 2022
3c9aab8
Add TimedOut to Retry and remove unnecessary conversion
rebecca-liveeo Aug 2, 2022
731d43e
Format terraform code in tests
rebecca-liveeo Aug 2, 2022
8f3daa1
Update test formatting with terrafmt
rebecca-liveeo Aug 3, 2022
9069530
Correct import statement in docs as per tfproviderdocs error
rebecca-liveeo Aug 3, 2022
e4a3253
Add automatic changes from terrafmt fmt
rebecca-liveeo Aug 11, 2022
b993529
Add string length validation to name and path inputs
rebecca-liveeo Sep 6, 2022
306b3d7
Refine comments and make minor formatting changes
rebecca-liveeo Sep 6, 2022
f731602
r/aws_ssoadmin_customer_managed_policy_attachment: Alphabetize attrib…
ewbankkit Sep 7, 2022
48cd067
r/aws_ssoadmin_customer_managed_policy_attachment: Tidy up resource C…
ewbankkit Sep 7, 2022
27e90cc
r/aws_ssoadmin_customer_managed_policy_attachment: Tidy up resource R…
ewbankkit Sep 8, 2022
554efc4
r/aws_ssoadmin_customer_managed_policy_attachment: Tidy up resource D…
ewbankkit Sep 8, 2022
5c25343
r/aws_ssoadmin_customer_managed_policy_attachment: Tidy up acceptance…
ewbankkit Sep 8, 2022
f04698d
r/aws_ssoadmin_customer_managed_policy_attachment: Correct resource N…
ewbankkit Sep 8, 2022
e72c536
Fix semgrep 'dgryski.semgrep-go.errnilcheck.err-nil-check'.
ewbankkit Sep 8, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/25915.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-resource
aws_ssoadmin_customer_managed_policy_attachment
```
9 changes: 5 additions & 4 deletions internal/provider/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -2065,10 +2065,11 @@ func New(_ context.Context) (*schema.Provider, error) {
"aws_ssm_resource_data_sync": ssm.ResourceResourceDataSync(),
"aws_ssm_service_setting": ssm.ResourceServiceSetting(),

"aws_ssoadmin_account_assignment": ssoadmin.ResourceAccountAssignment(),
"aws_ssoadmin_managed_policy_attachment": ssoadmin.ResourceManagedPolicyAttachment(),
"aws_ssoadmin_permission_set": ssoadmin.ResourcePermissionSet(),
"aws_ssoadmin_permission_set_inline_policy": ssoadmin.ResourcePermissionSetInlinePolicy(),
"aws_ssoadmin_account_assignment": ssoadmin.ResourceAccountAssignment(),
"aws_ssoadmin_customer_managed_policy_attachment": ssoadmin.ResourceCustomerManagedPolicyAttachment(),
oakbramble marked this conversation as resolved.
Show resolved Hide resolved
"aws_ssoadmin_managed_policy_attachment": ssoadmin.ResourceManagedPolicyAttachment(),
"aws_ssoadmin_permission_set": ssoadmin.ResourcePermissionSet(),
"aws_ssoadmin_permission_set_inline_policy": ssoadmin.ResourcePermissionSetInlinePolicy(),

"aws_storagegateway_cache": storagegateway.ResourceCache(),
"aws_storagegateway_cached_iscsi_volume": storagegateway.ResourceCachediSCSIVolume(),
Expand Down
229 changes: 229 additions & 0 deletions internal/service/ssoadmin/customer_managed_policy_attachment.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,229 @@
package ssoadmin

import (
"fmt"
"log"
"strings"
"time"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/ssoadmin"
"github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
"github.com/hashicorp/terraform-provider-aws/internal/conns"
"github.com/hashicorp/terraform-provider-aws/internal/tfresource"
"github.com/hashicorp/terraform-provider-aws/internal/verify"
)

const (
customerPolicyAttachmentTimeout = 5 * time.Minute
)

func ResourceCustomerManagedPolicyAttachment() *schema.Resource {
return &schema.Resource{
Create: resourceCustomerManagedPolicyAttachmentCreate,
Read: resourceCustomerManagedPolicyAttachmentRead,
Delete: resourceCustomerManagedPolicyAttachmentDelete,

Importer: &schema.ResourceImporter{
State: schema.ImportStatePassthrough,
},

Schema: map[string]*schema.Schema{
"customer_managed_policy_reference": {
Type: schema.TypeList,
Required: true,
ForceNew: true,
MaxItems: 1,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"name": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validation.StringLenBetween(0, 128),
},
"path": {
Type: schema.TypeString,
Optional: true,
Default: "/",
ForceNew: true,
ValidateFunc: validation.StringLenBetween(0, 512),
},
},
},
},
"instance_arn": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: verify.ValidARN,
},
"permission_set_arn": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: verify.ValidARN,
},
},
}
}

func resourceCustomerManagedPolicyAttachmentCreate(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*conns.AWSClient).SSOAdminConn

tfMap := d.Get("customer_managed_policy_reference").([]interface{})[0].(map[string]interface{})
policyName := tfMap["name"].(string)
policyPath := tfMap["path"].(string)
instanceARN := d.Get("instance_arn").(string)
permissionSetARN := d.Get("permission_set_arn").(string)
id := CustomerManagedPolicyAttachmentCreateResourceID(policyName, policyPath, permissionSetARN, instanceARN)
input := &ssoadmin.AttachCustomerManagedPolicyReferenceToPermissionSetInput{
CustomerManagedPolicyReference: expandCustomerManagedPolicyReference(tfMap),
InstanceArn: aws.String(instanceARN),
PermissionSetArn: aws.String(permissionSetARN),
}

log.Printf("[INFO] Attaching customer managed policy reference to permission set: %s", input)
_, err := tfresource.RetryWhenAWSErrCodeEquals(customerPolicyAttachmentTimeout, func() (interface{}, error) {
return conn.AttachCustomerManagedPolicyReferenceToPermissionSet(input)
}, ssoadmin.ErrCodeConflictException, ssoadmin.ErrCodeThrottlingException)

if err != nil {
return fmt.Errorf("creating SSO Customer Managed Policy Attachment (%s): %w", id, err)
}

d.SetId(id)

// After the policy has been attached to the permission set, provision in all accounts that use this permission set.
if err := provisionPermissionSet(conn, permissionSetARN, instanceARN); err != nil {
return err
}

return resourceCustomerManagedPolicyAttachmentRead(d, meta)
}

func resourceCustomerManagedPolicyAttachmentRead(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*conns.AWSClient).SSOAdminConn

policyName, policyPath, permissionSetARN, instanceARN, err := CustomerManagedPolicyAttachmentParseResourceID(d.Id())

if err != nil {
return err
}

policy, err := FindCustomerManagedPolicy(conn, policyName, policyPath, permissionSetARN, instanceARN)

if !d.IsNewResource() && tfresource.NotFound(err) {
log.Printf("[WARN] SSO Customer Managed Policy Attachment (%s) not found, removing from state", d.Id())
d.SetId("")
return nil
}

if err != nil {
return fmt.Errorf("reading SSO Customer Managed Policy Attachment (%s): %w", d.Id(), err)
}

if err := d.Set("customer_managed_policy_reference", []interface{}{flattenCustomerManagedPolicyReference(policy)}); err != nil {
return fmt.Errorf("setting customer_managed_policy_reference: %w", err)
}
d.Set("instance_arn", instanceARN)
d.Set("permission_set_arn", permissionSetARN)

return nil
}

func resourceCustomerManagedPolicyAttachmentDelete(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*conns.AWSClient).SSOAdminConn

policyName, policyPath, permissionSetARN, instanceARN, err := CustomerManagedPolicyAttachmentParseResourceID(d.Id())

if err != nil {
return err
}

input := &ssoadmin.DetachCustomerManagedPolicyReferenceFromPermissionSetInput{
CustomerManagedPolicyReference: &ssoadmin.CustomerManagedPolicyReference{
Name: aws.String(policyName),
Path: aws.String(policyPath),
},
InstanceArn: aws.String(instanceARN),
PermissionSetArn: aws.String(permissionSetARN),
}

log.Printf("[INFO] Detaching customer managed policy reference from permission set: %s", input)
_, err = tfresource.RetryWhenAWSErrCodeEquals(customerPolicyAttachmentTimeout, func() (interface{}, error) {
return conn.DetachCustomerManagedPolicyReferenceFromPermissionSet(input)
}, ssoadmin.ErrCodeConflictException, ssoadmin.ErrCodeThrottlingException)

if tfawserr.ErrCodeEquals(err, ssoadmin.ErrCodeResourceNotFoundException) {
return nil
}

if err != nil {
return fmt.Errorf("deleting SSO Customer Managed Policy Attachment (%s): %w", d.Id(), err)
}

// After the policy has been detached from the permission set, provision in all accounts that use this permission set.
if err := provisionPermissionSet(conn, permissionSetARN, instanceARN); err != nil {
return err
}

return nil
}

const customerManagedPolicyAttachmentIDSeparator = ","

func CustomerManagedPolicyAttachmentCreateResourceID(policyName, policyPath, permissionSetARN, instanceARN string) string {
parts := []string{policyName, policyPath, permissionSetARN, instanceARN}
id := strings.Join(parts, customerManagedPolicyAttachmentIDSeparator)

return id
}

func CustomerManagedPolicyAttachmentParseResourceID(id string) (string, string, string, string, error) {
parts := strings.Split(id, customerManagedPolicyAttachmentIDSeparator)

if len(parts) == 4 && parts[0] != "" && parts[1] != "" && parts[2] != "" && parts[3] != "" {
return parts[0], parts[1], parts[2], parts[3], nil
}

return "", "", "", "", fmt.Errorf("unexpected format for ID (%[1]s), expected CUSTOMER_MANAGED_POLICY_NAME%[2]sCUSTOMER_MANAGED_POLICY_PATH%[2]sPERMISSION_SET_ARN%[2]sINSTANCE_ARN", id, customerManagedPolicyAttachmentIDSeparator)
}

func expandCustomerManagedPolicyReference(tfMap map[string]interface{}) *ssoadmin.CustomerManagedPolicyReference {
if tfMap == nil {
return nil
}

apiObject := &ssoadmin.CustomerManagedPolicyReference{}

if v, ok := tfMap["name"].(string); ok && v != "" {
apiObject.Name = aws.String(v)
}

if v, ok := tfMap["path"].(string); ok && v != "" {
apiObject.Path = aws.String(v)
}

return apiObject
}

func flattenCustomerManagedPolicyReference(apiObject *ssoadmin.CustomerManagedPolicyReference) map[string]interface{} {
if apiObject == nil {
return nil
}

tfMap := map[string]interface{}{}

if v := apiObject.Name; v != nil {
tfMap["name"] = aws.StringValue(v)
}

if v := apiObject.Path; v != nil {
tfMap["path"] = aws.StringValue(v)
}

return tfMap
}