fix(26271): a changed provisioning_artifact_name is now taken into account and triggers an update in AWS for a provisioned_product

[theurichde]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26271

Output from acceptance testing:

export TF_LOG=; export AWS_PROFILE=default; export AWS_REGION=eu-central-1; export AWS_DEFAULT_REGION=eu-central-1; make testacc TESTS=TestAccServiceCatalogProvisionedProduct PKG=servicecatalog                              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactNameChanged'  -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactNameChanged
=== PAUSE TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactNameChanged
=== CONT  TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactNameChanged
--- PASS: TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactNameChanged (207.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	207.589s

$ export TF_LOG=; export AWS_PROFILE=default; export AWS_REGION=eu-central-1; export AWS_DEFAULT_REGION=eu-central-1; export ACCTEST_PARALLELISM=4; make testacc TESTS=TestAccServiceCatalogProvisionedProduct PKG=servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 4 -run='TestAccServiceCatalogProvisionedProduct'  -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_update
=== PAUSE TestAccServiceCatalogProvisionedProduct_update
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== RUN   TestAccServiceCatalogProvisionedProduct_tainted
=== PAUSE TestAccServiceCatalogProvisionedProduct_tainted
=== RUN   TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactNameChanged
=== PAUSE TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactNameChanged
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
=== CONT  TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactNameChanged
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (126.82s)
=== CONT  TestAccServiceCatalogProvisionedProduct_update
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (134.49s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tainted
--- PASS: TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactNameChanged (206.58s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (208.60s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tainted (189.25s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (206.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	333.874s

[theurichde]

Hi @breathingdust

Any chance to get that PR reviewed and merged somewhen soonish?

Thanks!

[jar-b]

LGTM 🎉

$ make testacc PKG=servicecatalog TESTS=TestAccServiceCatalogProvisionedProduct_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogProvisionedProduct_'  -timeout 180m

--- PASS: TestAccServiceCatalogProvisionedProduct_errorOnCreate (56.16s)
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (137.19s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (141.37s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (230.18s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (233.36s)
--- PASS: TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactName_update (236.40s)
--- PASS: TestAccServiceCatalogProvisionedProduct_computedOutputs (252.43s)
--- PASS: TestAccServiceCatalogProvisionedProduct_errorOnUpdate (276.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     280.030s

Note: TestAccServiceCatalogProvisionedProduct_ProductName_update was omitted from testing as it is dependent on a v5.0.0 change released in #31061. This test will be disabled until v5 in a follow-up PR.

[jar-b]

Thanks for your contribution, @theurichde! 👏

[github-actions]

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.