Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_vpc_security_group_ingress_rule: New resource #27680

Merged
merged 74 commits into from
Nov 11, 2022
Merged

r/aws_vpc_security_group_ingress_rule: New resource #27680

merged 74 commits into from
Nov 11, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 7, 2022 •
edited
Loading

Description

Introduces new resources aws_vpc_security_group_ingress_rule and aws_vpc_security_group_egress_rule.
This resource maps directly to the EC2 SecurityGroupRule resource and attempts to resolve many of the problems with the current aws_security_group_rule resource (and the aws_security_group resource's nested egress and ingress attributes) which does not map 1-to-1 onto SecurityGroupRule.

Relations

Relates #20104.

This PR will be merged with no externally visible effects:

  • No new documentation
  • No CHANGELOG entries
  • The new resource don't self-register

We still need to consider how to introduce these new resources and what (if any) deprecation strategy we announce.

@ewbankkit
EC2: Generate service package data.
5c8c32c
@ewbankkit
Add 'tags.TagsAttribute'.
312f903
@ewbankkit
r/aws_vpc_security_group_ingress_rule: Initial code.
c06c102
@ewbankkit
Register EC2 service package data.
faeda96
@ewbankkit
Add 'FindSecurityGroupRuleByID' and friends.
370d5fa
@ewbankkit
Flex: Additional comments.
ca55915
@ewbankkit
Add 'flex.ToFrameworkStringValue'.
468eb5c
@ewbankkit
Add 'flex.ToFrameworkInt64Value'.
6ccdce7
@ewbankkit
r/aws_vpc_security_group_ingress_rule: Working Create, Read and Delete.
2fee384
@ewbankkit
Add 'fwplanmodifiers.NormalizeEmptyMap'.
2e2c566
@ewbankkit
Use 'fwplanmodifiers.NormalizeEmptyMap' for 'tags' attributes.
bc87de3
@ewbankkit
'TagsAttributeComputed' -> 'TagsAttributeComputedOnly'.
25c48ea
@ewbankkit
Revert "Use 'fwplanmodifiers.NormalizeEmptyMap' for 'tags' attributes."
4e51091 
This reverts commit bc87de3.
@ewbankkit
Revert "Add 'fwplanmodifiers.NormalizeEmptyMap'."
2b8aca4 
This reverts commit 2e2c566.
@ewbankkit
'TagsAttributeComputed' -> 'TagsAttributeComputedOnly'.
647ea5c
@ewbankkit
r/aws_vpc_security_group_ingress_rule: Propagate null (vs. empty) tag…
4a90986 
…s on Read.
@ewbankkit
r/aws_vpc_security_group_ingress_rule: Flesh out Update.
c24a513
@ewbankkit
Add 'FindSecurityGroupIngressRuleByID'.
fd40227
@ewbankkit
r/aws_vpc_security_group_ingress_rule: Initial acceptance test.
45487cd 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupIngressRule_ -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_basic
=== PAUSE TestAccVPCSecurityGroupIngressRule_basic
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
--- PASS: TestAccVPCSecurityGroupIngressRule_basic (25.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	32.122s
@ewbankkit
r/aws_vpc_security_group_ingress_rule: Add 'TestAccVPCSecurityGroupIn…
ccd74d5 
…gressRule_disappears'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_disappears' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupIngressRule_disappears -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_disappears
=== PAUSE TestAccVPCSecurityGroupIngressRule_disappears
=== CONT  TestAccVPCSecurityGroupIngressRule_disappears
    vpc_security_group_ingress_rule_test.go:57: Step 1/1 error: Check failed: 1 error occurred:
        	* Check 2/2 error: 1 error occurred:
        	* deleting EC2 Security Group Ingress Rule (sgr-0136373b64661c07b)

        InvalidGroupId.Malformed: The security-group ID '' is malformed
        	status code: 400, request id: e06dfcd3-fdd5-4e91-a435-3032977080a6

--- FAIL: TestAccVPCSecurityGroupIngressRule_disappears (16.31s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	21.007s
FAIL
make: *** [testacc] Error 1
@ewbankkit
r/aws_vpc_security_group_ingress_rule: Add 'TestAccVPCSecurityGroupIn…
bcc0c70 
…gressRule_tags'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_tags' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupIngressRule_tags -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
    vpc_security_group_ingress_rule_test.go:82: Step 3/4 error: Error running apply: exit status 1

        Error: Provider returned invalid result object after apply

        After the apply operation, the provider still indicated an unknown value for
        aws_vpc_security_group_ingress_rule.test.tags_all. All values must be known
        after apply, so this is always a bug in the provider and should be reported
        in the provider's own repository. Terraform will still save the other known
        object values in the state.
--- FAIL: TestAccVPCSecurityGroupIngressRule_tags (31.14s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	35.800s
FAIL
make: *** [testacc] Error 1
@ewbankkit
tools/tfsdk2fw: Run 'go mod tidy'.
7a18363
@ewbankkit
tools/tfsdk2fw: Resource 'id' attribute is Computed-only.
faf635b
@ewbankkit
Wrapped Framework resource implements minimally ResourceWithConfigure.
a71faa8
@ewbankkit
Implement 'ModifyPlan' on the Framework resource wrapper.
e5cde1b 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_tags' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupIngressRule_tags -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
--- PASS: TestAccVPCSecurityGroupIngressRule_tags (51.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	56.599s
@ewbankkit
acctest: Construct a simple Framework State that contains just top-le…
6659fdb 
…vel attributes.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_disappears' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupIngressRule_disappears -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_disappears
=== PAUSE TestAccVPCSecurityGroupIngressRule_disappears
=== CONT  TestAccVPCSecurityGroupIngressRule_disappears
--- PASS: TestAccVPCSecurityGroupIngressRule_disappears (22.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	27.430s
@ewbankkit
r/aws_vpc_security_group_ingress_rule: Add 'security_group_rule_id' a…
6eec00d 
…ttribute.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCSecurityGroupIngressRule_basic -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_basic
=== PAUSE TestAccVPCSecurityGroupIngressRule_basic
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
--- PASS: TestAccVPCSecurityGroupIngressRule_basic (27.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	34.422s
@ewbankkit
r/aws_vpc_security_group_ingress_rule: Add 'TestAccVPCSecurityGroupIn…
9f8a8f8 
…gressRule_description'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_description' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCSecurityGroupIngressRule_description -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_description
=== PAUSE TestAccVPCSecurityGroupIngressRule_description
=== CONT  TestAccVPCSecurityGroupIngressRule_description
--- PASS: TestAccVPCSecurityGroupIngressRule_description (41.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	48.448s
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the flex Pertains to FLatteners and EXpanders. label Nov 7, 2022
@ewbankkit
Meta: Use 'framework.DataSourceWithConfigure'.
0e4132b 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccMeta' PKG=meta ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 3  -run=TestAccMeta -timeout 180m
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== RUN   TestAccMetaARNDataSource_s3Bucket
=== PAUSE TestAccMetaARNDataSource_s3Bucket
=== RUN   TestAccMetaBillingServiceAccountDataSource_basic
=== PAUSE TestAccMetaBillingServiceAccountDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_basic
=== PAUSE TestAccMetaDefaultTagsDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_empty
=== PAUSE TestAccMetaDefaultTagsDataSource_empty
=== RUN   TestAccMetaDefaultTagsDataSource_multiple
=== PAUSE TestAccMetaDefaultTagsDataSource_multiple
=== RUN   TestAccMetaDefaultTagsDataSource_ignore
=== PAUSE TestAccMetaDefaultTagsDataSource_ignore
=== RUN   TestAccMetaIPRangesDataSource_basic
=== PAUSE TestAccMetaIPRangesDataSource_basic
=== RUN   TestAccMetaIPRangesDataSource_none
=== PAUSE TestAccMetaIPRangesDataSource_none
=== RUN   TestAccMetaIPRangesDataSource_url
=== PAUSE TestAccMetaIPRangesDataSource_url
=== RUN   TestAccMetaIPRangesDataSource_uppercase
=== PAUSE TestAccMetaIPRangesDataSource_uppercase
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== RUN   TestAccMetaRegionDataSource_endpointAndName
=== PAUSE TestAccMetaRegionDataSource_endpointAndName
=== RUN   TestAccMetaRegionDataSource_name
=== PAUSE TestAccMetaRegionDataSource_name
=== RUN   TestAccMetaRegionsDataSource_basic
=== PAUSE TestAccMetaRegionsDataSource_basic
=== RUN   TestAccMetaRegionsDataSource_filter
=== PAUSE TestAccMetaRegionsDataSource_filter
=== RUN   TestAccMetaRegionsDataSource_allRegions
=== PAUSE TestAccMetaRegionsDataSource_allRegions
=== RUN   TestAccMetaRegionsDataSource_nonExistentRegion
=== PAUSE TestAccMetaRegionsDataSource_nonExistentRegion
=== RUN   TestAccMetaService_basic
=== PAUSE TestAccMetaService_basic
=== RUN   TestAccMetaService_byReverseDNSName
=== PAUSE TestAccMetaService_byReverseDNSName
=== RUN   TestAccMetaService_byDNSName
=== PAUSE TestAccMetaService_byDNSName
=== RUN   TestAccMetaService_byParts
=== PAUSE TestAccMetaService_byParts
=== RUN   TestAccMetaService_unsupported
=== PAUSE TestAccMetaService_unsupported
=== CONT  TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpoint
=== CONT  TestAccMetaIPRangesDataSource_basic
--- PASS: TestAccMetaARNDataSource_basic (13.07s)
=== CONT  TestAccMetaRegionsDataSource_nonExistentRegion
--- PASS: TestAccMetaRegionDataSource_endpoint (13.73s)
=== CONT  TestAccMetaService_unsupported
--- PASS: TestAccMetaIPRangesDataSource_basic (14.74s)
=== CONT  TestAccMetaService_byParts
--- PASS: TestAccMetaRegionsDataSource_nonExistentRegion (12.05s)
--- PASS: TestAccMetaService_unsupported (11.39s)
=== CONT  TestAccMetaService_byDNSName
=== CONT  TestAccMetaService_byReverseDNSName
--- PASS: TestAccMetaService_byParts (11.10s)
=== CONT  TestAccMetaService_basic
--- PASS: TestAccMetaService_byReverseDNSName (12.47s)
=== CONT  TestAccMetaRegionsDataSource_basic
--- PASS: TestAccMetaService_byDNSName (13.12s)
=== CONT  TestAccMetaRegionsDataSource_allRegions
--- PASS: TestAccMetaService_basic (12.60s)
=== CONT  TestAccMetaRegionsDataSource_filter
--- PASS: TestAccMetaRegionsDataSource_basic (11.34s)
=== CONT  TestAccMetaRegionDataSource_name
--- PASS: TestAccMetaRegionsDataSource_filter (11.86s)
--- PASS: TestAccMetaRegionsDataSource_allRegions (12.06s)
=== CONT  TestAccMetaRegionDataSource_basic
=== CONT  TestAccMetaIPRangesDataSource_uppercase
--- PASS: TestAccMetaRegionDataSource_name (12.12s)
=== CONT  TestAccMetaPartitionDataSource_basic
--- PASS: TestAccMetaRegionDataSource_basic (11.49s)
=== CONT  TestAccMetaIPRangesDataSource_url
--- PASS: TestAccMetaIPRangesDataSource_uppercase (13.27s)
=== CONT  TestAccMetaRegionDataSource_endpointAndName
--- PASS: TestAccMetaPartitionDataSource_basic (11.60s)
=== CONT  TestAccMetaDefaultTagsDataSource_empty
--- PASS: TestAccMetaIPRangesDataSource_url (12.91s)
=== CONT  TestAccMetaDefaultTagsDataSource_ignore
--- PASS: TestAccMetaRegionDataSource_endpointAndName (12.54s)
=== CONT  TestAccMetaDefaultTagsDataSource_multiple
--- PASS: TestAccMetaDefaultTagsDataSource_empty (16.11s)
=== CONT  TestAccMetaBillingServiceAccountDataSource_basic
=== CONT  TestAccMetaDefaultTagsDataSource_basic
--- PASS: TestAccMetaDefaultTagsDataSource_multiple (12.69s)
--- PASS: TestAccMetaDefaultTagsDataSource_ignore (26.22s)
=== CONT  TestAccMetaARNDataSource_s3Bucket
--- PASS: TestAccMetaDefaultTagsDataSource_basic (12.19s)
=== CONT  TestAccMetaIPRangesDataSource_none
--- PASS: TestAccMetaBillingServiceAccountDataSource_basic (16.25s)
--- PASS: TestAccMetaARNDataSource_s3Bucket (11.97s)
--- PASS: TestAccMetaIPRangesDataSource_none (13.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	119.065s
@ewbankkit
STS: Use 'framework.DataSourceWithConfigure'.
992b3c9 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccSTSCallerIdentityDataSource_' PKG=sts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20  -run=TestAccSTSCallerIdentityDataSource_ -timeout 180m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (12.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	19.792s
@ewbankkit
GlobalAccelerator: Use 'framework.DataSourceWithConfigure'.
39eb851 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccGlobalAcceleratorAcceleratorDataSource_' PKG=globalaccelerator
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20  -run=TestAccGlobalAcceleratorAcceleratorDataSource_ -timeout 180m
=== RUN   TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== PAUSE TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== CONT  TestAccGlobalAcceleratorAcceleratorDataSource_basic
--- PASS: TestAccGlobalAcceleratorAcceleratorDataSource_basic (93.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	97.845s
@ewbankkit
SimpleDB: Use 'framework.ResourceWithConfigure'.
864aab0 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 180m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== RUN   TestAccSimpleDBDomain_MigrateFromPluginSDK
=== PAUSE TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (18.87s)
--- PASS: TestAccSimpleDBDomain_basic (22.58s)
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (65.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	70.205s
@ewbankkit
MediaLive: Use 'framework.ResourceWithConfigure'.
47bc4da 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccMediaLive_serial/MultiplexProgram' PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20  -run=TestAccMediaLive_serial/MultiplexProgram -timeout 180m
=== RUN   TestAccMediaLive_serial
=== RUN   TestAccMediaLive_serial/MultiplexProgram
=== RUN   TestAccMediaLive_serial/MultiplexProgram/disappears
=== RUN   TestAccMediaLive_serial/MultiplexProgram/basic
=== RUN   TestAccMediaLive_serial/MultiplexProgram/update
--- PASS: TestAccMediaLive_serial (204.94s)
    --- PASS: TestAccMediaLive_serial/MultiplexProgram (204.94s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/disappears (62.01s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/basic (60.79s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/update (82.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	209.580s
@ewbankkit
EC2: Use 'framework.ResourceWithConfigure'.
b997700
@ewbankkit
'fwplanmodifiers' -> 'framework/planmodifiers'.
82c006e
@ewbankkit
'fwvalidators' -> 'framework/validators'.
43a73c1
@ewbankkit
'fwtypes' -> 'framework/types'.
7247920
@ewbankkit
d/aws_caller_identity: 'arn' is of type String as it's an output-only…
fcd2d5f 
… attribute.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccSTSCallerIdentityDataSource_' PKG=sts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20  -run=TestAccSTSCallerIdentityDataSource_ -timeout 180m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (12.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	16.702s
@ewbankkit
Move 'tags_all' plan-time logic into base resource.
ba6dc06 
Acceptance test output:

 make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== CONT  TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
--- PASS: TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply (45.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	51.425s
@ewbankkit
tools/tfsdk2fw: Data source embeds 'framework.DataSourceWithConfigure'.
bd69157
@ewbankkit
tools/tfsdk2fw: Resource embeds 'framework.ResourceWithConfigure'.
73d3e22
@ewbankkit
tools/tfsdk2fw: Generate resource 'ModifyPlan' if 'tags_all' detected.
91066cd
@ewbankkit
tools/tfsdk2fw: Generate TODOs for 'tags' and 'tags_all'.
7fa7e84
@ewbankkit
Add 'framework.IDAttribute'.
f8d99d6 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 180m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== RUN   TestAccSimpleDBDomain_MigrateFromPluginSDK
=== PAUSE TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (19.91s)
--- PASS: TestAccSimpleDBDomain_basic (24.53s)
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (59.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	68.487s
@ewbankkit
tools/tfsdk2fw: Correct tags TODO for data source.
61e9436
@ewbankkit
tools/tfsdk2fw: Add TODO for 'id' attribute.
b8680e7
@ewbankkit
Merge branch 'main' into f-aws_ec2_security_group_ingress+egress_rule
04242bb
@ewbankkit
Comment out self-registration of 'aws_vpc_security_group_ingress_rule…
cde1055 
…' and 'aws_vpc_security_group_egress_rule'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_basic\|TestAccVPCSecurityGroupEgressRule_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCSecurityGroupIngressRule_basic\|TestAccVPCSecurityGroupEgressRule_basic -timeout 180m
=== RUN   TestAccVPCSecurityGroupEgressRule_basic
=== PAUSE TestAccVPCSecurityGroupEgressRule_basic
=== RUN   TestAccVPCSecurityGroupIngressRule_basic
=== PAUSE TestAccVPCSecurityGroupIngressRule_basic
=== CONT  TestAccVPCSecurityGroupEgressRule_basic
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
=== CONT  TestAccVPCSecurityGroupEgressRule_basic
    vpc_security_group_egress_rule_test.go:23: Step 1/2 error: Error running pre-apply refresh: exit status 1

        Error: Invalid resource type

          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_egress_rule" "test":
          19: resource "aws_vpc_security_group_egress_rule" "test" {

        The provider hashicorp/aws does not support resource type
        "aws_vpc_security_group_egress_rule".
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
    vpc_security_group_ingress_rule_test.go:87: Step 1/2 error: Error running pre-apply refresh: exit status 1

        Error: Invalid resource type

          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_ingress_rule" "test":
          19: resource "aws_vpc_security_group_ingress_rule" "test" {

        The provider hashicorp/aws does not support resource type
        "aws_vpc_security_group_ingress_rule".
--- FAIL: TestAccVPCSecurityGroupIngressRule_basic (5.47s)
--- FAIL: TestAccVPCSecurityGroupEgressRule_basic (5.49s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	13.577s
FAIL
make: *** [testacc] Error 1
@ewbankkit
Remove any external visible traces of 'aws_vpc_security_group_ingress…
bcf74a1 
…_rule' and 'aws_vpc_security_group_egress_rule'.
@ewbankkit
Suppress golangci-lint errors like:
8af3fed 
internal/service/ec2/vpc_security_group_ingress_rule.go:140:33: mnd: Magic number: 65535, in <argument> detected (gomnd)
					int64validator.Between(-1, 65535),
@ewbankkit ewbankkit marked this pull request as ready for review November 11, 2022 18:21
@ewbankkit ewbankkit merged commit a1a6725 into main Nov 11, 2022
@ewbankkit ewbankkit deleted the f-aws_ec2_security_group_ingress+egress_rule branch November 11, 2022 18:57
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 11, 2022
github-actions bot pushed a commit that referenced this pull request Nov 11, 2022
Update CHANGELOG.md for #27680
f3424d7
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/medialive Issues and PRs that pertain to the medialive service. service/simpledb Issues and PRs that pertain to the simpledb service. service/sts Issues and PRs that pertain to the sts service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Milestone
v4.40.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ewbankkit