Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to avoid DNS record overwrite #2926

Merged
merged 3 commits into from
Feb 15, 2018

Commits on Jan 10, 2018

  1. Added option to avoid DNS record overwrite

    The current behavior of the aws_route53_record resource is to overwrite the record if one already exists. For example, we suppose that the notexample.com CNAME to foo.bar is added by hand via the CLI. If the new Terraform resource with the same name but with a different CNAME value is added, the record is going to be overridden. This might be a big problem: a record might be changed by mistake.
    
    So this PR proposes to add an option named allow_overwrite on the resource to protect overwrite. When the option is true the CREATE mode is used instead of UPSERT in the change batch. This means that if an added record already exists on route53, the application will fail. By default, the overwrite is permitted to avoid compatibility issue.
    Erouan50 committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    2ee5ed6 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Added Acc test

    Erouan50 committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    d200824 View commit details
    Browse the repository at this point in the history
  2. test/resource/aws_route53_record: Ensure allowOverwrite works when ru…

    …nning parallelized testing
    bflad committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    87c1c68 View commit details
    Browse the repository at this point in the history