Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace heredoc with aws_iam_policy_document datasource (r/o*, r/p*, … #29386

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Replace heredoc with aws_iam_policy_document datasource (r/o*, r/p*, … #29386

merged 3 commits into from
Feb 27, 2023

Conversation

mattburgess
Copy link
Collaborator

…r/r*)

Description

Relations

Relates #17714

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/opensearch Issues and PRs that pertain to the opensearch service. service/organizations Issues and PRs that pertain to the organizations service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/redshift Issues and PRs that pertain to the redshift service. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Feb 13, 2023
justinretzolk
justinretzolk requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to do this! I left a few things to review before we get this merged in.

website/docs/r/opensearch_domain.html.markdown Outdated Show resolved Hide resolved
website/docs/r/opensearch_domain_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pinpoint_event_stream.markdown Show resolved Hide resolved
website/docs/r/pinpoint_event_stream.markdown Outdated Show resolved Hide resolved
website/docs/r/redshift_scheduled_action.html.markdown Show resolved Hide resolved
@justinretzolk justinretzolk added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 27, 2023
mattburgess and others added 2 commits February 27, 2023 20:45
@mattburgess @justinretzolk
Apply suggestions from code review
4bfe8c4 
Co-authored-by: Justin Retzolk <44710313+justinretzolk@users.noreply.github.com>
@mattburgess
Fix formatting
8e8c187
justinretzolk
justinretzolk approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@justinretzolk justinretzolk merged commit 2be0ba9 into hashicorp:main Feb 27, 2023
@github-actions github-actions bot added this to the v4.57.0 milestone Feb 27, 2023
@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Feb 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This functionality has been released in v4.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinretzolk justinretzolk justinretzolk approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/opensearch Issues and PRs that pertain to the opensearch service. service/organizations Issues and PRs that pertain to the organizations service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/redshift Issues and PRs that pertain to the redshift service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.57.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattburgess @justinretzolk