Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DataSources: aws_oam_sink and aws_oam_sinks #30258

Merged
merged 3 commits into from Mar 28, 2023

Conversation

royrajan13
Copy link

@royrajan13 royrajan13 commented Mar 26, 2023

Description

Adding 2 data sources for aws_oam_sink resource:

  • aws_oam_sink
  • aws_oam_sinks

Relations

Relates #28158

References

Output from Acceptance Testing

➜ make testacc PKG=oam TESTS=TestAccObservabilityAccessManagerSinkDataSource
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/oam/... -v -count 1 -parallel 20 -run='TestAccObservabilityAccessManagerSinkDataSource'  -timeout 180m
=== RUN   TestAccObservabilityAccessManagerSinkDataSource_basic
--- PASS: TestAccObservabilityAccessManagerSinkDataSource_basic (126.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/oam        149.706s



➜ make testacc PKG=oam TESTS=TestAccObservabilityAccessManagerSinksDataSource
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/oam/... -v -count 1 -parallel 20 -run='TestAccObservabilityAccessManagerSinksDataSource'  -timeout 180m
=== RUN   TestAccObservabilityAccessManagerSinksDataSource_basic
--- PASS: TestAccObservabilityAccessManagerSinksDataSource_basic (122.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/oam        145.765s

* aws_oam_sink
* aws_oam_sinks
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/oam Issues and PRs that pertain to the oam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Mar 26, 2023
@ewbankkit ewbankkit added new-data-source Introduces a new data source. partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 28, 2023
@ewbankkit ewbankkit self-assigned this Mar 28, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccObservabilityAccessManagerSinkDataSource_\|TestAccObservabilityAccessManagerSinksDataSource_' PKG=oam ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/oam/... -v -count 1 -parallel 3  -run=TestAccObservabilityAccessManagerSinkDataSource_\|TestAccObservabilityAccessManagerSinksDataSource_ -timeout 180m
=== RUN   TestAccObservabilityAccessManagerSinkDataSource_basic
--- PASS: TestAccObservabilityAccessManagerSinkDataSource_basic (16.26s)
=== RUN   TestAccObservabilityAccessManagerSinksDataSource_basic
--- PASS: TestAccObservabilityAccessManagerSinksDataSource_basic (13.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/oam	35.787s

@ewbankkit
Copy link
Contributor

@royrajan13 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6d527c3 into hashicorp:main Mar 28, 2023
49 checks passed
@github-actions github-actions bot added this to the v4.61.0 milestone Mar 28, 2023
@github-actions
Copy link

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. partner Contribution from a partner. service/oam Issues and PRs that pertain to the oam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants