Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_s3_bucket_object: Add deprecation message to schemas #31492

Merged
merged 3 commits into from May 19, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 19, 2023

Description

Adds DeprecationMessage to resource and data source schemas.

Relations

Closes #29722.
Relates #22877.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3BucketObject_empty$$\|TestAccS3BucketObjectDataSource_basic$$\|TestAccS3BucketObjectsDataSource_basic$$' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3BucketObject_empty$\|TestAccS3BucketObjectDataSource_basic$\|TestAccS3BucketObjectsDataSource_basic$ -timeout 180m
=== RUN   TestAccS3BucketObjectDataSource_basic
=== PAUSE TestAccS3BucketObjectDataSource_basic
=== RUN   TestAccS3BucketObject_empty
=== PAUSE TestAccS3BucketObject_empty
=== RUN   TestAccS3BucketObjectsDataSource_basic
=== PAUSE TestAccS3BucketObjectsDataSource_basic
=== CONT  TestAccS3BucketObjectDataSource_basic
=== CONT  TestAccS3BucketObjectsDataSource_basic
=== CONT  TestAccS3BucketObject_empty
--- PASS: TestAccS3BucketObjectDataSource_basic (22.49s)
--- PASS: TestAccS3BucketObject_empty (24.27s)
--- PASS: TestAccS3BucketObjectsDataSource_basic (36.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	42.057s

@ewbankkit ewbankkit changed the title r/aws_s3_bucket_object: Add deprecation message to schema r/aws_s3_bucket_object: Add deprecation message to schemas May 19, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR. and removed service/s3 Issues and PRs that pertain to the s3 service. labels May 19, 2023
@ewbankkit ewbankkit added the service/s3 Issues and PRs that pertain to the s3 service. label May 19, 2023
@ewbankkit ewbankkit merged commit b7924ed into main May 19, 2023
48 checks passed
@ewbankkit ewbankkit deleted the d/aws_s3_bucket_object.schema-deprecation branch May 19, 2023 13:58
@github-actions github-actions bot added this to the v5.0.0 milestone May 19, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update aws_s3_bucket_object(s) schemas to add DeprecationMessage
1 participant