Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non default value for quicksight group membership #32496

Merged
merged 6 commits into from
Jul 15, 2023

Conversation

lafod
Copy link
Contributor

@lafod lafod commented Jul 13, 2023

Description

Allow user to set namespace to a different value aside default when adding users to a quicksight group

Relations

Closes #32494

References

https://docs.aws.amazon.com/cli/latest/reference/quicksight/create-group-membership.html

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccQuickSightGroupMembership_' PKG=quicksight ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 3  -run=TestAccQuickSightGroupMembership_ -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]
=== RUN   TestAccQuickSightGroupMembership_basic
=== PAUSE TestAccQuickSightGroupMembership_basic
=== RUN   TestAccQuickSightGroupMembership_withNamespace
=== PAUSE TestAccQuickSightGroupMembership_withNamespace
=== RUN   TestAccQuickSightGroupMembership_disappears
=== PAUSE TestAccQuickSightGroupMembership_disappears
=== CONT  TestAccQuickSightGroupMembership_basic
=== CONT  TestAccQuickSightGroupMembership_disappears
=== CONT  TestAccQuickSightGroupMembership_withNamespace
--- PASS: TestAccQuickSightGroupMembership_disappears (36.02s)
--- PASS: TestAccQuickSightGroupMembership_basic (44.27s)
--- PASS: TestAccQuickSightGroupMembership_withNamespace (164.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 196.553s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/quicksight Issues and PRs that pertain to the quicksight service. partner Contribution from a partner. needs-triage Waiting for first response or review from a maintainer. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 13, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 13, 2023
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@jar-b jar-b self-assigned this Jul 14, 2023
@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Jul 14, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=quicksight TESTS=TestAccQuickSightGroupMembership_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightGroupMembership_'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightGroupMembership_disappears (23.16s)
--- PASS: TestAccQuickSightGroupMembership_basic (26.26s)
--- PASS: TestAccQuickSightGroupMembership_withNamespace (138.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 141.840s

@jar-b jar-b merged commit 7dbd75e into hashicorp:main Jul 15, 2023
47 checks passed
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 15, 2023
@jar-b
Copy link
Member

jar-b commented Jul 15, 2023

Thanks for your contribution, @lafod! 👍

@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/quicksight Issues and PRs that pertain to the quicksight service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support non default value when creating group membership
4 participants