-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow non default value for quicksight group membership #32496
allow non default value for quicksight group membership #32496
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=quicksight TESTS=TestAccQuickSightGroupMembership_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightGroupMembership_' -timeout 180m
? github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema [no test files]
--- PASS: TestAccQuickSightGroupMembership_disappears (23.16s)
--- PASS: TestAccQuickSightGroupMembership_basic (26.26s)
--- PASS: TestAccQuickSightGroupMembership_withNamespace (138.44s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 141.840s
Thanks for your contribution, @lafod! 👍 |
This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Allow user to set namespace to a different value aside default when adding users to a quicksight group
Relations
Closes #32494
References
https://docs.aws.amazon.com/cli/latest/reference/quicksight/create-group-membership.html
Output from Acceptance Testing