r/aws_lightsail_domain_entry: support for AAAA record type

[sh0e1]

Description

When I try to add an AAAA record with aws_lightsail_domain_entry, I get an error with terraform validate.

Error: expected type to be one of [A CNAME MX NS SOA SRV TXT], got AAAA

Fixed aws_lightsail_domain_entry to support AAAA record type.

Relations

Relates #27309

References

IPv6 (AAAA) domain entry type is allowed in aws cli.
https://docs.aws.amazon.com/cli/latest/reference/lightsail/create-domain-entry.html#options

The type of domain entry, such as address for IPv4 (A), address for IPv6 (AAAA), canonical name (CNAME), mail exchanger (MX), name server (NS), start of authority (SOA), service locator (SRV), or text (TXT).

Output from Acceptance Testing

make testacc TESTS=TestAccLightsailDomainEntry PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailDomainEntry'  -timeout 180m
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomainEntry_underscore
=== PAUSE TestAccLightsailDomainEntry_underscore
=== RUN   TestAccLightsailDomainEntry_apex
=== PAUSE TestAccLightsailDomainEntry_apex
=== RUN   TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== RUN   TestAccLightsailDomainEntry_typeAAAA
=== PAUSE TestAccLightsailDomainEntry_typeAAAA
=== CONT  TestAccLightsailDomainEntry_basic
=== CONT  TestAccLightsailDomainEntry_disappears
=== CONT  TestAccLightsailDomainEntry_apex
=== CONT  TestAccLightsailDomainEntry_typeAAAA
=== CONT  TestAccLightsailDomainEntry_underscore
--- PASS: TestAccLightsailDomainEntry_disappears (45.91s)
--- PASS: TestAccLightsailDomainEntry_underscore (57.16s)
--- PASS: TestAccLightsailDomainEntry_typeAAAA (57.31s)
--- PASS: TestAccLightsailDomainEntry_basic (57.45s)
--- PASS: TestAccLightsailDomainEntry_apex (57.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  59.337s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @sh0e1 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccLightsailDomainEntry_' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsailDomainEntry_ -timeout 180m
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomainEntry_underscore
=== PAUSE TestAccLightsailDomainEntry_underscore
=== RUN   TestAccLightsailDomainEntry_apex
=== PAUSE TestAccLightsailDomainEntry_apex
=== RUN   TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== RUN   TestAccLightsailDomainEntry_typeAAAA
=== PAUSE TestAccLightsailDomainEntry_typeAAAA
=== CONT  TestAccLightsailDomainEntry_basic
=== CONT  TestAccLightsailDomainEntry_disappears
--- PASS: TestAccLightsailDomainEntry_disappears (37.79s)
=== CONT  TestAccLightsailDomainEntry_typeAAAA
--- PASS: TestAccLightsailDomainEntry_basic (44.03s)
=== CONT  TestAccLightsailDomainEntry_apex
--- PASS: TestAccLightsailDomainEntry_typeAAAA (41.55s)
=== CONT  TestAccLightsailDomainEntry_underscore
--- PASS: TestAccLightsailDomainEntry_apex (41.21s)
--- PASS: TestAccLightsailDomainEntry_underscore (41.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	125.641s

[ewbankkit]

@sh0e1 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.