Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ec2_network_insights_path: Avoid recreating resource when passing an ARN as source or destination #33168

Merged
merged 12 commits into from
Aug 24, 2023
Merged

r/aws_ec2_network_insights_path: Avoid recreating resource when passing an ARN as source or destination #33168

merged 12 commits into from
Aug 24, 2023

Commits on Aug 23, 2023

  1. r/aws_ec2_network_insights_path: Fix correct attribute name.

    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2a790cb View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3c698a7 View commit details
    Browse the repository at this point in the history

  3. r/aws_ec2_network_insights_path: Add 'destination_arn' and 'source_ar… 

    …n' attributes.
    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d22db81 View commit details
    Browse the repository at this point in the history

  4. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccVPCNetworkInsightsPath_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCNetworkInsightsPath_basic -timeout 180m
=== RUN   TestAccVPCNetworkInsightsPath_basic
=== PAUSE TestAccVPCNetworkInsightsPath_basic
=== CONT  TestAccVPCNetworkInsightsPath_basic
--- PASS: TestAccVPCNetworkInsightsPath_basic (52.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	58.363s
    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b2184d1 View commit details
    Browse the repository at this point in the history

  5. d/aws_ec2_network_insights_path: Add 'destination_arn' and 'source_ar… 

    …n' attributes.
    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b351ee2 View commit details
    Browse the repository at this point in the history

  6. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccVPCNetworkInsightsPathDataSource_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCNetworkInsightsPathDataSource_basic -timeout 180m
=== RUN   TestAccVPCNetworkInsightsPathDataSource_basic
=== PAUSE TestAccVPCNetworkInsightsPathDataSource_basic
=== CONT  TestAccVPCNetworkInsightsPathDataSource_basic
--- PASS: TestAccVPCNetworkInsightsPathDataSource_basic (46.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	52.380s
    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1353887 View commit details
    Browse the repository at this point in the history

  7. r/aws_ec2_network_insights_path: Avoid recreating resource when passi… 

    …ng an ARN as 'source' or 'destination'.
    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    74e89fc View commit details
    Browse the repository at this point in the history

  8. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccVPCNetworkInsightsPath_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCNetworkInsightsPath_ -timeout 180m
=== RUN   TestAccVPCNetworkInsightsPath_basic
=== PAUSE TestAccVPCNetworkInsightsPath_basic
=== RUN   TestAccVPCNetworkInsightsPath_disappears
=== PAUSE TestAccVPCNetworkInsightsPath_disappears
=== RUN   TestAccVPCNetworkInsightsPath_tags
=== PAUSE TestAccVPCNetworkInsightsPath_tags
=== RUN   TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
=== PAUSE TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
=== RUN   TestAccVPCNetworkInsightsPath_sourceIP
=== PAUSE TestAccVPCNetworkInsightsPath_sourceIP
=== RUN   TestAccVPCNetworkInsightsPath_destinationIP
=== PAUSE TestAccVPCNetworkInsightsPath_destinationIP
=== RUN   TestAccVPCNetworkInsightsPath_destinationPort
=== PAUSE TestAccVPCNetworkInsightsPath_destinationPort
=== CONT  TestAccVPCNetworkInsightsPath_basic
=== CONT  TestAccVPCNetworkInsightsPath_sourceIP
--- PASS: TestAccVPCNetworkInsightsPath_basic (57.25s)
=== CONT  TestAccVPCNetworkInsightsPath_destinationPort
--- PASS: TestAccVPCNetworkInsightsPath_sourceIP (88.68s)
=== CONT  TestAccVPCNetworkInsightsPath_tags
--- PASS: TestAccVPCNetworkInsightsPath_destinationPort (86.46s)
=== CONT  TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
--- PASS: TestAccVPCNetworkInsightsPath_sourceAndDestinationARN (53.52s)
=== CONT  TestAccVPCNetworkInsightsPath_destinationIP
--- PASS: TestAccVPCNetworkInsightsPath_tags (122.06s)
=== CONT  TestAccVPCNetworkInsightsPath_disappears
--- PASS: TestAccVPCNetworkInsightsPath_disappears (59.85s)
--- PASS: TestAccVPCNetworkInsightsPath_destinationIP (86.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	290.139s
    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c0bcf19 View commit details
    Browse the repository at this point in the history

  9. ec2: Use 'errors.Join'.

    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    89ed773 View commit details
    Browse the repository at this point in the history

  10. r/aws_ec2_network_insights_path: Retry 'AnalysisExistsForNetworkInsig… 

    …htsPath' errors on resource Delete.
    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5b926ba View commit details
    Browse the repository at this point in the history

  11. Correct CHANGELOG entry file name.

    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4e64621 View commit details
    Browse the repository at this point in the history

  12. Remove import step from 'TestAccVPCNetworkInsightsAnalysis_waitForCom… 

    …pletion'.
    @ewbankkit
    ewbankkit committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ae0d19b View commit details
    Browse the repository at this point in the history