Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F verified access trust provider #33195

Merged
merged 15 commits into from
Sep 11, 2023

Conversation

markoskandylis
Copy link
Contributor

Description

Adds support for VerrifiedAccess Trust Provider

Relations

Relates #29689

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVerifiedAccessTrustProvider.html

Output from Acceptance Testing

$  make testacc TESTARGS='-run=TestAccCodeCatalystDevenvironment_' PKG=codecatalyst  ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codecatalyst/... -v -count 1 -parallel 2  -run=TestAccCodeCatalystDevenvironment_ -timeout 180m
=== RUN   TestAccCodeCatalystDevenvironment_basic
=== PAUSE TestAccCodeCatalystDevenvironment_basic
=== RUN   TestAccCodeCatalystDevenvironment_withRepositories
=== PAUSE TestAccCodeCatalystDevenvironment_withRepositories
=== RUN   TestAccCodeCatalystDevenvironment_disappears
=== PAUSE TestAccCodeCatalystDevenvironment_disappears
=== CONT  TestAccCodeCatalystDevenvironment_basic
=== CONT  TestAccCodeCatalystDevenvironment_disappears
--- PASS: TestAccCodeCatalystDevenvironment_disappears (35.51s)
=== CONT  TestAccCodeCatalystDevenvironment_withRepositories
--- PASS: TestAccCodeCatalystDevenvironment_basic (39.53s)
--- PASS: TestAccCodeCatalystDevenvironment_withRepositories (353.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codecatalyst       392.338s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. github_actions Pull requests that update Github_actions code service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. labels Aug 27, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Aug 27, 2023
@markoskandylis markoskandylis marked this pull request as draft August 27, 2023 22:02
@markoskandylis markoskandylis marked this pull request as ready for review August 28, 2023 08:39
@justinretzolk justinretzolk added new-service Introduces a new service. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 30, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVerifiedAccessTrustProvider_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessTrustProvider_ -timeout 180m
=== RUN   TestAccVerifiedAccessTrustProvider_basic
=== PAUSE TestAccVerifiedAccessTrustProvider_basic
=== RUN   TestAccVerifiedAccessTrustProvider_deviceOptions
=== PAUSE TestAccVerifiedAccessTrustProvider_deviceOptions
=== RUN   TestAccVerifiedAccessTrustProvider_disappears
=== PAUSE TestAccVerifiedAccessTrustProvider_disappears
=== RUN   TestAccVerifiedAccessTrustProvider_oidcOptions
=== PAUSE TestAccVerifiedAccessTrustProvider_oidcOptions
=== RUN   TestAccVerifiedAccessTrustProvider_tags
=== PAUSE TestAccVerifiedAccessTrustProvider_tags
=== CONT  TestAccVerifiedAccessTrustProvider_basic
=== CONT  TestAccVerifiedAccessTrustProvider_oidcOptions
--- PASS: TestAccVerifiedAccessTrustProvider_basic (27.50s)
=== CONT  TestAccVerifiedAccessTrustProvider_disappears
--- PASS: TestAccVerifiedAccessTrustProvider_oidcOptions (27.55s)
=== CONT  TestAccVerifiedAccessTrustProvider_deviceOptions
--- PASS: TestAccVerifiedAccessTrustProvider_disappears (20.55s)
=== CONT  TestAccVerifiedAccessTrustProvider_tags
--- PASS: TestAccVerifiedAccessTrustProvider_deviceOptions (26.87s)
--- PASS: TestAccVerifiedAccessTrustProvider_tags (57.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	110.875s

@ewbankkit
Copy link
Contributor

@markoskandylis Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 342fb54 into hashicorp:main Sep 11, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.17.0 milestone Sep 11, 2023
@YakDriver YakDriver modified the milestones: v5.17.0, v5.16.2 Sep 11, 2023
@github-actions
Copy link

This functionality has been released in v5.16.2 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. new-service Introduces a new service. partner Contribution from a partner. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants