r/aws_s3_object_copy: Migrate to AWS SDK for Go v2 #33330

ewbankkit · 2023-09-06T17:02:51Z

Description

Migrates the aws_s3_object_copy resource to AWS SDK for Go v2.
The resource Delete functionality has not yet been migrated as it's shared with others.

Relations

Relates #33304.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3ObjectCopy_ -timeout 180m
=== RUN   TestAccS3ObjectCopy_basic
=== PAUSE TestAccS3ObjectCopy_basic
=== RUN   TestAccS3ObjectCopy_disappears
=== PAUSE TestAccS3ObjectCopy_disappears
=== RUN   TestAccS3ObjectCopy_tags
=== PAUSE TestAccS3ObjectCopy_tags
=== RUN   TestAccS3ObjectCopy_metadata
=== PAUSE TestAccS3ObjectCopy_metadata
=== RUN   TestAccS3ObjectCopy_grant
=== PAUSE TestAccS3ObjectCopy_grant
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_object
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_object
=== RUN   TestAccS3ObjectCopy_sourceWithSlashes
=== PAUSE TestAccS3ObjectCopy_sourceWithSlashes
=== CONT  TestAccS3ObjectCopy_basic
=== CONT  TestAccS3ObjectCopy_grant
=== CONT  TestAccS3ObjectCopy_tags
=== CONT  TestAccS3ObjectCopy_metadata
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_object
=== CONT  TestAccS3ObjectCopy_disappears
=== CONT  TestAccS3ObjectCopy_sourceWithSlashes
--- PASS: TestAccS3ObjectCopy_metadata (60.51s)
--- PASS: TestAccS3ObjectCopy_basic (61.31s)
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_bucket (61.71s)
--- PASS: TestAccS3ObjectCopy_disappears (62.18s)
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_object (62.51s)
--- PASS: TestAccS3ObjectCopy_grant (63.21s)
--- PASS: TestAccS3ObjectCopy_sourceWithSlashes (80.20s)
--- PASS: TestAccS3ObjectCopy_tags (104.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	110.315s

…g code.

…02411dfb0f646000bdb6ab8 && go mod tidy'.

…ceObjectCopyDoCopy'.

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_basic' PKG=s3 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2 -run=TestAccS3ObjectCopy_basic -timeout 180m === RUN TestAccS3ObjectCopy_basic === PAUSE TestAccS3ObjectCopy_basic === CONT TestAccS3ObjectCopy_basic --- PASS: TestAccS3ObjectCopy_basic (42.01s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 48.447s

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_disappears' PKG=s3 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2 -run=TestAccS3ObjectCopy_disappears -timeout 180m === RUN TestAccS3ObjectCopy_disappears === PAUSE TestAccS3ObjectCopy_disappears === CONT TestAccS3ObjectCopy_disappears --- PASS: TestAccS3ObjectCopy_disappears (43.24s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 48.855s

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_tags' PKG=s3 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2 -run=TestAccS3ObjectCopy_tags -timeout 180m === RUN TestAccS3ObjectCopy_tags === PAUSE TestAccS3ObjectCopy_tags === CONT TestAccS3ObjectCopy_tags --- PASS: TestAccS3ObjectCopy_tags (68.37s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 73.887s

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_metadata' PKG=s3 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2 -run=TestAccS3ObjectCopy_metadata -timeout 180m === RUN TestAccS3ObjectCopy_metadata === PAUSE TestAccS3ObjectCopy_metadata === CONT TestAccS3ObjectCopy_metadata --- PASS: TestAccS3ObjectCopy_metadata (74.15s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 95.276s

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_grant' PKG=s3 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2 -run=TestAccS3ObjectCopy_grant -timeout 180m === RUN TestAccS3ObjectCopy_grant === PAUSE TestAccS3ObjectCopy_grant === CONT TestAccS3ObjectCopy_grant --- PASS: TestAccS3ObjectCopy_grant (26.52s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 31.858s

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_BucketKeyEnabled_' PKG=s3 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2 -run=TestAccS3ObjectCopy_BucketKeyEnabled_ -timeout 180m === RUN TestAccS3ObjectCopy_BucketKeyEnabled_bucket === PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_bucket === RUN TestAccS3ObjectCopy_BucketKeyEnabled_object === PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_object === CONT TestAccS3ObjectCopy_BucketKeyEnabled_bucket === CONT TestAccS3ObjectCopy_BucketKeyEnabled_object --- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_object (27.50s) --- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_bucket (27.67s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 33.161s

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_sourceAndTargetWithSlashes' PKG=s3 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2 -run=TestAccS3ObjectCopy_sourceAndTargetWithSlashes -timeout 180m === RUN TestAccS3ObjectCopy_sourceAndTargetWithSlashes === PAUSE TestAccS3ObjectCopy_sourceAndTargetWithSlashes === CONT TestAccS3ObjectCopy_sourceAndTargetWithSlashes --- PASS: TestAccS3ObjectCopy_sourceAndTargetWithSlashes (25.79s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 31.058s

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_sourceWithSlashes' PKG=s3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3ObjectCopy_sourceWithSlashes -timeout 180m === RUN TestAccS3ObjectCopy_sourceWithSlashes === PAUSE TestAccS3ObjectCopy_sourceWithSlashes === CONT TestAccS3ObjectCopy_sourceWithSlashes --- PASS: TestAccS3ObjectCopy_sourceWithSlashes (44.62s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 50.263s

github-actions · 2023-09-06T17:03:10Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…- remove retry.

jar-b

LGTM 🎉

% make testacc TESTARGS='-run=TestAccS3ObjectCopy_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3ObjectCopy_ -timeout 180m
=== RUN   TestAccS3ObjectCopy_basic
=== PAUSE TestAccS3ObjectCopy_basic
=== RUN   TestAccS3ObjectCopy_disappears
=== PAUSE TestAccS3ObjectCopy_disappears
=== RUN   TestAccS3ObjectCopy_tags
=== PAUSE TestAccS3ObjectCopy_tags
=== RUN   TestAccS3ObjectCopy_metadata
=== PAUSE TestAccS3ObjectCopy_metadata
=== RUN   TestAccS3ObjectCopy_grant
=== PAUSE TestAccS3ObjectCopy_grant
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_object
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_object
=== RUN   TestAccS3ObjectCopy_sourceWithSlashes
=== PAUSE TestAccS3ObjectCopy_sourceWithSlashes
=== CONT  TestAccS3ObjectCopy_basic
=== CONT  TestAccS3ObjectCopy_grant
=== CONT  TestAccS3ObjectCopy_tags
=== CONT  TestAccS3ObjectCopy_disappears
=== CONT  TestAccS3ObjectCopy_metadata
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_object
=== CONT  TestAccS3ObjectCopy_sourceWithSlashes
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_bucket
--- PASS: TestAccS3ObjectCopy_basic (180.07s)
--- PASS: TestAccS3ObjectCopy_metadata (180.25s)
--- PASS: TestAccS3ObjectCopy_disappears (186.06s)
--- PASS: TestAccS3ObjectCopy_sourceWithSlashes (186.69s)
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_object (204.12s)
--- PASS: TestAccS3ObjectCopy_grant (216.52s)
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_bucket (217.88s)
--- PASS: TestAccS3ObjectCopy_tags (331.03s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 334.299s

github-actions · 2023-09-08T01:54:42Z

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-10-08T02:06:16Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ewbankkit added 24 commits September 5, 2023 13:57

s3: 'FindObjectByThreePartKey' -> 'FindObjectByThreePartKeyV1'.

bcff8bc

s3: 'ObjectListTags' -> 'ObjectListTagsV1'.

54c699c

s3: Generate AWS SDK for Go v2 tagging code.

74cc696

r/aws_s3_object_copy: Migrate (except Delete) to AWS SDK for Go v2.

3bad4a9

s3: Add '-SkipAWSServiceImp' when generating AWS SDK for Go v2 taggin…

798ce6b

…g code.

r/aws_s3_object_copy: Migrate acceptance tests to AWS SDK for Go v2.

d170f3a

Run 'go get github.com/hashicorp/aws-sdk-go-base/v2@2572ed001c9c61c7f…

917bd94

…02411dfb0f646000bdb6ab8 && go mod tidy'.

Use 'tfawserr.ErrHTTPStatusCodeEquals'.

eb905e6

Call 'resourceObjectCopyRead', not 'resourceObjectRead', from 'resour…

0a532c2

…ceObjectCopyDoCopy'.

Tidy up 'TestAccS3ObjectCopy_basic'.

5108f87

Add 'TestAccS3ObjectCopy_disappears'.

ae5b011

Add 'TestAccS3ObjectCopy_tags'.

3fbece4

Add 'TestAccS3ObjectCopy_metadata'.

22b34ed

Add 'TestAccS3ObjectCopy_grant'.

c08c837

Add 'TestAccS3ObjectCopy_sourceAndTargetWithSlashes'.

e66f033

External source object in 'TestAccS3ObjectCopy_sourceWithSlashes'.

ee57bb5

terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 6, 2023

ewbankkit added 2 commits September 6, 2023 13:46

r/aws_s3_object_copy: Amazon S3 Object Tags are strongly consistent -…

b16ed8f

…- remove retry.

s3: 'propagationTimeout' -> 's3BucketPropagationTimeout'.

99defa8

jar-b approved these changes Sep 6, 2023

View reviewed changes

ewbankkit merged commit 93cc3b0 into main Sep 6, 2023
35 checks passed

ewbankkit deleted the f-aws_s3_object-aws-sdk-v2 branch September 6, 2023 20:11

github-actions bot added this to the v5.16.0 milestone Sep 6, 2023

ewbankkit changed the title ~~r/aws_s3_object_copy: Migrate to AWS SDK for Go v2.~~ r/aws_s3_object_copy: Migrate to AWS SDK for Go v2 Sep 7, 2023

ewbankkit mentioned this pull request Sep 7, 2023

r/aws_s3_object: Migrate to AWS SDK for Go v2 #33358

Merged

This was referenced Sep 12, 2023

r/aws_s3_bucket_policy at al.: Migrate to AWS SDK for Go v2 #33431

Merged

r/aws_s3_bucket: Migrate FindBucket to AWS SDK for Go v2 #33452

Merged

r/aws_s3_bucket_website_configuration et al.: Migrate to AWS SDK for Go v2 #33537

Merged

This was referenced Sep 22, 2023

r/aws_s3_bucket_intelligent_tiering_configuration et al.: Migrate to AWS SDK for Go v2 #33593

Merged

s3(control): Complete migration to AWS SDK for Go v2 #33654

Closed

github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023

justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_s3_object_copy: Migrate to AWS SDK for Go v2 #33330

r/aws_s3_object_copy: Migrate to AWS SDK for Go v2 #33330

ewbankkit commented Sep 6, 2023 •

edited

Loading

github-actions bot commented Sep 6, 2023

jar-b left a comment

github-actions bot commented Sep 8, 2023

github-actions bot commented Oct 8, 2023

r/aws_s3_object_copy: Migrate to AWS SDK for Go v2 #33330

r/aws_s3_object_copy: Migrate to AWS SDK for Go v2 #33330

Conversation

ewbankkit commented Sep 6, 2023 • edited Loading

Description

Relations

Output from Acceptance Testing

github-actions bot commented Sep 6, 2023

Community Note

jar-b left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 8, 2023

github-actions bot commented Oct 8, 2023

ewbankkit commented Sep 6, 2023 •

edited

Loading