Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_iot_topic_rule: Fix InvalidParameter errors on Update with Kafka destinations #33380

Merged
merged 9 commits into from
Sep 11, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 8, 2023

Description

Unable to push to fork for #33360.

Relations

Closes #33360.
Closes #24742.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccIoTTopicRule_' PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2  -run=TestAccIoTTopicRule_ -timeout 180m
=== RUN   TestAccIoTTopicRule_basic
=== PAUSE TestAccIoTTopicRule_basic
=== RUN   TestAccIoTTopicRule_disappears
=== PAUSE TestAccIoTTopicRule_disappears
=== RUN   TestAccIoTTopicRule_tags
=== PAUSE TestAccIoTTopicRule_tags
=== RUN   TestAccIoTTopicRule_cloudWatchAlarm
=== PAUSE TestAccIoTTopicRule_cloudWatchAlarm
=== RUN   TestAccIoTTopicRule_cloudWatchLogs
=== PAUSE TestAccIoTTopicRule_cloudWatchLogs
=== RUN   TestAccIoTTopicRule_cloudWatchMetric
=== PAUSE TestAccIoTTopicRule_cloudWatchMetric
=== RUN   TestAccIoTTopicRule_dynamoDB
=== PAUSE TestAccIoTTopicRule_dynamoDB
=== RUN   TestAccIoTTopicRule_dynamoDBv2
=== PAUSE TestAccIoTTopicRule_dynamoDBv2
=== RUN   TestAccIoTTopicRule_elasticSearch
=== PAUSE TestAccIoTTopicRule_elasticSearch
=== RUN   TestAccIoTTopicRule_firehose
=== PAUSE TestAccIoTTopicRule_firehose
=== RUN   TestAccIoTTopicRule_Firehose_separator
=== PAUSE TestAccIoTTopicRule_Firehose_separator
=== RUN   TestAccIoTTopicRule_Firehose_batch_mode
=== PAUSE TestAccIoTTopicRule_Firehose_batch_mode
=== RUN   TestAccIoTTopicRule_http
=== PAUSE TestAccIoTTopicRule_http
=== RUN   TestAccIoTTopicRule_IoT_analytics
=== PAUSE TestAccIoTTopicRule_IoT_analytics
=== RUN   TestAccIoTTopicRule_IoT_analytics_batch_mode
=== PAUSE TestAccIoTTopicRule_IoT_analytics_batch_mode
=== RUN   TestAccIoTTopicRule_IoT_events
=== PAUSE TestAccIoTTopicRule_IoT_events
=== RUN   TestAccIoTTopicRule_IoT_events_batch_mode
=== PAUSE TestAccIoTTopicRule_IoT_events_batch_mode
=== RUN   TestAccIoTTopicRule_kafka
=== PAUSE TestAccIoTTopicRule_kafka
=== RUN   TestAccIoTTopicRule_kinesis
=== PAUSE TestAccIoTTopicRule_kinesis
=== RUN   TestAccIoTTopicRule_lambda
=== PAUSE TestAccIoTTopicRule_lambda
=== RUN   TestAccIoTTopicRule_republish
=== PAUSE TestAccIoTTopicRule_republish
=== RUN   TestAccIoTTopicRule_republishWithQos
=== PAUSE TestAccIoTTopicRule_republishWithQos
=== RUN   TestAccIoTTopicRule_s3
=== PAUSE TestAccIoTTopicRule_s3
=== RUN   TestAccIoTTopicRule_sns
=== PAUSE TestAccIoTTopicRule_sns
=== RUN   TestAccIoTTopicRule_sqs
=== PAUSE TestAccIoTTopicRule_sqs
=== RUN   TestAccIoTTopicRule_Step_functions
=== PAUSE TestAccIoTTopicRule_Step_functions
=== RUN   TestAccIoTTopicRule_Timestream
=== PAUSE TestAccIoTTopicRule_Timestream
=== RUN   TestAccIoTTopicRule_errorAction
=== PAUSE TestAccIoTTopicRule_errorAction
=== RUN   TestAccIoTTopicRule_updateKinesisErrorAction
=== PAUSE TestAccIoTTopicRule_updateKinesisErrorAction
=== CONT  TestAccIoTTopicRule_basic
=== CONT  TestAccIoTTopicRule_IoT_events
--- PASS: TestAccIoTTopicRule_basic (26.10s)
=== CONT  TestAccIoTTopicRule_elasticSearch
--- PASS: TestAccIoTTopicRule_IoT_events (31.57s)
=== CONT  TestAccIoTTopicRule_IoT_analytics_batch_mode
--- PASS: TestAccIoTTopicRule_elasticSearch (51.52s)
=== CONT  TestAccIoTTopicRule_IoT_analytics
--- PASS: TestAccIoTTopicRule_IoT_analytics_batch_mode (47.18s)
=== CONT  TestAccIoTTopicRule_http
--- PASS: TestAccIoTTopicRule_IoT_analytics (48.66s)
=== CONT  TestAccIoTTopicRule_Firehose_batch_mode
--- PASS: TestAccIoTTopicRule_http (76.96s)
=== CONT  TestAccIoTTopicRule_Firehose_separator
--- PASS: TestAccIoTTopicRule_Firehose_batch_mode (54.18s)
=== CONT  TestAccIoTTopicRule_firehose
--- PASS: TestAccIoTTopicRule_Firehose_separator (60.15s)
=== CONT  TestAccIoTTopicRule_s3
--- PASS: TestAccIoTTopicRule_firehose (58.78s)
=== CONT  TestAccIoTTopicRule_updateKinesisErrorAction
--- PASS: TestAccIoTTopicRule_s3 (51.76s)
=== CONT  TestAccIoTTopicRule_errorAction
--- PASS: TestAccIoTTopicRule_updateKinesisErrorAction (49.68s)
=== CONT  TestAccIoTTopicRule_Timestream
--- PASS: TestAccIoTTopicRule_errorAction (32.39s)
=== CONT  TestAccIoTTopicRule_Step_functions
--- PASS: TestAccIoTTopicRule_Timestream (49.47s)
=== CONT  TestAccIoTTopicRule_sqs
--- PASS: TestAccIoTTopicRule_Step_functions (50.03s)
=== CONT  TestAccIoTTopicRule_sns
--- PASS: TestAccIoTTopicRule_sqs (49.47s)
=== CONT  TestAccIoTTopicRule_lambda
--- PASS: TestAccIoTTopicRule_sns (49.84s)
=== CONT  TestAccIoTTopicRule_republishWithQos
--- PASS: TestAccIoTTopicRule_lambda (23.80s)
=== CONT  TestAccIoTTopicRule_republish
--- PASS: TestAccIoTTopicRule_republishWithQos (32.93s)
=== CONT  TestAccIoTTopicRule_kafka
--- PASS: TestAccIoTTopicRule_republish (52.29s)
=== CONT  TestAccIoTTopicRule_cloudWatchLogs
--- PASS: TestAccIoTTopicRule_cloudWatchLogs (52.93s)
=== CONT  TestAccIoTTopicRule_dynamoDBv2
--- PASS: TestAccIoTTopicRule_kafka (88.35s)
=== CONT  TestAccIoTTopicRule_dynamoDB
--- PASS: TestAccIoTTopicRule_dynamoDBv2 (48.22s)
=== CONT  TestAccIoTTopicRule_cloudWatchMetric
--- PASS: TestAccIoTTopicRule_dynamoDB (51.23s)
=== CONT  TestAccIoTTopicRule_IoT_events_batch_mode
--- PASS: TestAccIoTTopicRule_cloudWatchMetric (72.35s)
=== CONT  TestAccIoTTopicRule_tags
--- PASS: TestAccIoTTopicRule_IoT_events_batch_mode (69.16s)
=== CONT  TestAccIoTTopicRule_cloudWatchAlarm
--- PASS: TestAccIoTTopicRule_cloudWatchAlarm (58.05s)
=== CONT  TestAccIoTTopicRule_kinesis
--- PASS: TestAccIoTTopicRule_tags (70.03s)
=== CONT  TestAccIoTTopicRule_disappears
--- PASS: TestAccIoTTopicRule_disappears (19.24s)
--- PASS: TestAccIoTTopicRule_kinesis (62.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	767.135s

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iot Issues and PRs that pertain to the iot service. labels Sep 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 8, 2023
@ewbankkit ewbankkit merged commit fa02c43 into main Sep 11, 2023
68 checks passed
@ewbankkit ewbankkit deleted the b-pr33360 branch September 11, 2023 12:10
@github-actions github-actions bot added this to the v5.17.0 milestone Sep 11, 2023
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@YakDriver YakDriver modified the milestones: v5.17.0, v5.16.2 Sep 11, 2023
@github-actions
Copy link

This functionality has been released in v5.16.2 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/iot Issues and PRs that pertain to the iot service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_iot_topic_rule can't update kafka action
4 participants