cloudfront/distribution: Sweeper infinite loop #33675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XS
terraform-aws-provider
bot
added
the
prioritized
YakDriver
force-pushed
the
b-fix-cloudfront-sweeper-infloop
branch
from
9e28e0b
to
78ff713
Compare
gdavison
requested changes
Sep 28, 2023
internal/service/cloudfront/sweep.go
Outdated
Comment on lines
163
to
179
| var result *multierror.Error | ||
|
|
||
| // sweep: | ||
| // 1. Production Distributions | ||
| if err := sweepDistributionsByProductionStaging(region, false); err != nil { | ||
| result = multierror.Append(result, err) | ||
| log.Printf("[WARN] %s", err) | ||
| } | ||
|
|
||
| // 2. Continuous Deployment Policies | ||
| if err := sweepContinuousDeploymentPolicies(region); err != nil { | ||
| result = multierror.Append(result, err) | ||
| log.Printf("[WARN] %s", err) | ||
| } | ||
|
|
||
| // 3. Staging Distributions | ||
| if err := sweepDistributionsByProductionStaging(region, true); err != nil { | ||
| result = multierror.Append(result, err) | ||
| log.Printf("[WARN] %s", err) | ||
| } | ||
|
|
||
| return result.ErrorOrNil() | ||
| return nil |
There was a problem hiding this comment.
Errors should return errors, not fail silently
github-actions
bot
added
size/M
|
This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relations
Relates #33663
Relates #33578
References
Output from Acceptance Testing