Fix aws_lb network in AWS GovCloud #34140

jseiser · 2023-10-27T15:22:20Z

Description

Relations

Closes #34135.
Relates #33994.

References

Output from Acceptance Testing

❯ make test
==> Checking that code complies with gofmt requirements...
go test ./...  -timeout=5m
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	7.908s

I want to be clear, im not a Golang dev, I just see this and figured the same fix would work.

github-actions · 2023-10-27T15:22:37Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

jseiser · 2023-11-01T19:16:25Z

Is there anything missing on this?

jseiser · 2023-11-16T15:47:44Z

This is becoming more of a problem, as some of the most popular TF modules are requiring an AWS provider >= the version that includes this non working change in gov cloud.

zhaque44 · 2023-12-05T16:40:43Z

@jseiser @ewbankkit any info or status on this getting merged?

jseiser · 2023-12-05T16:42:14Z

@zhaque44 No response from Hashicorp :/

ewbankkit · 2023-12-05T21:41:59Z

Before fix in GovCloud:

% make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy' PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20  -run=TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy -timeout 360m
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
    load_balancer_test.go:1339: Step 1/4 error: Error running apply: exit status 1
        
        Error: failure configuring LB attributes: InvalidConfigurationRequest: Load balancer attribute key 'dns_record.client_routing_policy' is not supported on load balancers with type 'network'
        	status code: 400, request id: bd4a60df-dfd3-43f4-90af-6cd1abd3989a
        
          with aws_lb.test,
          on terraform_plugin_test.tf line 42, in resource "aws_lb" "test":
          42: resource "aws_lb" "test" {
        
--- FAIL: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy (162.58s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	168.136s
FAIL
make: *** [testacc] Error 1

…gToIntValue'.

…k_traffic' on Create.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_' PKG=elbv2 ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2LoadBalancer_ -timeout 360m
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN   TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN   TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== PAUSE TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== RUN   TestAccELBV2LoadBalancer_disappears
=== PAUSE TestAccELBV2LoadBalancer_disappears
=== RUN   TestAccELBV2LoadBalancer_nameGenerated
=== PAUSE TestAccELBV2LoadBalancer_nameGenerated
=== RUN   TestAccELBV2LoadBalancer_nameGeneratedForZeroValue
=== PAUSE TestAccELBV2LoadBalancer_nameGeneratedForZeroValue
=== RUN   TestAccELBV2LoadBalancer_namePrefix
=== PAUSE TestAccELBV2LoadBalancer_namePrefix
=== RUN   TestAccELBV2LoadBalancer_duplicateName
=== PAUSE TestAccELBV2LoadBalancer_duplicateName
=== RUN   TestAccELBV2LoadBalancer_tags
=== PAUSE TestAccELBV2LoadBalancer_tags
=== RUN   TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== PAUSE TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== RUN   TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
=== PAUSE TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
=== RUN   TestAccELBV2LoadBalancer_ALB_outpost
=== PAUSE TestAccELBV2LoadBalancer_ALB_outpost
=== RUN   TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== PAUSE TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== RUN   TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== PAUSE TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== RUN   TestAccELBV2LoadBalancer_backwardsCompatibility
=== PAUSE TestAccELBV2LoadBalancer_backwardsCompatibility
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen
=== RUN   TestAccELBV2LoadBalancer_updateIPAddressType
=== PAUSE TestAccELBV2LoadBalancer_updateIPAddressType
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateSubnets
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateSubnets
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets
=== RUN   TestAccELBV2LoadBalancer_updateDesyncMitigationMode
=== PAUSE TestAccELBV2LoadBalancer_updateDesyncMitigationMode
=== RUN   TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite
=== PAUSE TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite
=== RUN   TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode
=== PAUSE TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode
=== RUN   TestAccELBV2LoadBalancer_ALB_updateXffClientPort
=== PAUSE TestAccELBV2LoadBalancer_ALB_updateXffClientPort
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (209.68s)
=== CONT  TestAccELBV2LoadBalancer_ALB_updateXffClientPort
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix (345.40s)
=== CONT  TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection (297.20s)
=== CONT  TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite
--- PASS: TestAccELBV2LoadBalancer_ALB_updateXffClientPort (294.91s)
=== CONT  TestAccELBV2LoadBalancer_updateDesyncMitigationMode
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets
--- PASS: TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode (306.29s)
--- PASS: TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite (304.18s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink
--- PASS: TestAccELBV2LoadBalancer_updateDesyncMitigationMode (312.60s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink (336.73s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets (443.75s)
=== CONT  TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy (307.32s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing (251.18s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader (298.67s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups (708.11s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields (308.64s)
=== CONT  TestAccELBV2LoadBalancer_backwardsCompatibility
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2 (306.90s)
=== CONT  TestAccELBV2LoadBalancer_NLB_privateIPv4Address
--- PASS: TestAccELBV2LoadBalancer_backwardsCompatibility (216.30s)
=== CONT  TestAccELBV2LoadBalancer_networkLoadBalancerEIP
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone (303.14s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup
--- PASS: TestAccELBV2LoadBalancer_NLB_privateIPv4Address (225.60s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup (215.40s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix
--- PASS: TestAccELBV2LoadBalancer_networkLoadBalancerEIP (243.11s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix (327.51s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs (398.19s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateSubnets
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs (359.46s)
=== CONT  TestAccELBV2LoadBalancer_ALB_outpost
    acctest.go:1155: skipping since no Outposts found
--- SKIP: TestAccELBV2LoadBalancer_ALB_outpost (0.46s)
=== CONT  TestAccELBV2LoadBalancer_updateIPAddressType
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups (265.68s)
=== CONT  TestAccELBV2LoadBalancer_disappears
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateSubnets (244.68s)
=== CONT  TestAccELBV2LoadBalancer_nameGenerated
--- PASS: TestAccELBV2LoadBalancer_updateIPAddressType (272.65s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen
--- PASS: TestAccELBV2LoadBalancer_disappears (199.96s)
=== CONT  TestAccELBV2LoadBalancer_tags
--- PASS: TestAccELBV2LoadBalancer_nameGenerated (219.71s)
=== CONT  TestAccELBV2LoadBalancer_ipv6SubnetMapping
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen (314.32s)
=== CONT  TestAccELBV2LoadBalancer_nameGeneratedForZeroValue
--- PASS: TestAccELBV2LoadBalancer_ipv6SubnetMapping (261.28s)
=== CONT  TestAccELBV2LoadBalancer_duplicateName
--- PASS: TestAccELBV2LoadBalancer_tags (359.03s)
=== CONT  TestAccELBV2LoadBalancer_namePrefix
--- PASS: TestAccELBV2LoadBalancer_nameGeneratedForZeroValue (198.49s)
=== CONT  TestAccELBV2LoadBalancer_LoadBalancerType_gateway
--- PASS: TestAccELBV2LoadBalancer_duplicateName (213.52s)
=== CONT  TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_namePrefix (197.62s)
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerType_gateway (176.21s)
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (211.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	3514.161s

% make testacc TESTARGS='-run=TestAccELBV2LoadBalancerDataSource_' PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2LoadBalancerDataSource_ -timeout 360m
=== RUN   TestAccELBV2LoadBalancerDataSource_basic
=== PAUSE TestAccELBV2LoadBalancerDataSource_basic
=== RUN   TestAccELBV2LoadBalancerDataSource_outpost
=== PAUSE TestAccELBV2LoadBalancerDataSource_outpost
=== RUN   TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== PAUSE TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== CONT  TestAccELBV2LoadBalancerDataSource_basic
=== CONT  TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== CONT  TestAccELBV2LoadBalancerDataSource_outpost
    acctest.go:1155: skipping since no Outposts found
--- SKIP: TestAccELBV2LoadBalancerDataSource_outpost (0.85s)
--- PASS: TestAccELBV2LoadBalancerDataSource_basic (212.69s)
--- PASS: TestAccELBV2LoadBalancerDataSource_backwardsCompatibility (220.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	226.247s

AWS US GovCloud

% make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_NLB_\|TestAccELBV2LoadBalancer_NetworkLoadBalancer_\|TestAccELBV2LoadBalancer_ipv6SubnetMapping\|TestAccELBV2LoadBalancer_ALB_basic' PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2LoadBalancer_NLB_\|TestAccELBV2LoadBalancer_NetworkLoadBalancer_\|TestAccELBV2LoadBalancer_ipv6SubnetMapping\|TestAccELBV2LoadBalancer_ALB_basic -timeout 360m
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN   TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN   TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== PAUSE TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== RUN   TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== PAUSE TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
=== CONT  TestAccELBV2LoadBalancer_NLB_privateIPv4Address
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (219.88s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink
--- PASS: TestAccELBV2LoadBalancer_NLB_privateIPv4Address (240.34s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets
    acctest.go:951: skipping tests; current partition (aws-us-gov) not supported
--- SKIP: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets (0.00s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix (373.67s)
=== CONT  TestAccELBV2LoadBalancer_ipv6SubnetMapping
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink (375.21s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
    acctest.go:951: skipping tests; current partition (aws-us-gov) not supported
--- SKIP: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy (0.00s)
=== CONT  TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_ipv6SubnetMapping (238.99s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (209.85s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups (745.45s)
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs (376.09s)
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone (288.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	1099.437s

ewbankkit · 2023-12-08T14:06:39Z

@jseiser Thanks for the contribution 🎉 👏.

zhaque44 · 2023-12-08T14:56:54Z

@jseiser Thanks for the contribution 🎉 👏.

are we ready to ship? this will help us remove this version constraint: version = "<= 5.22"

ewbankkit · 2023-12-08T15:16:05Z

@jseiser This fix will be available in Terraform AWS Provider v5.31.0, likely next Thursday, December 14th.

github-actions · 2023-12-15T02:39:02Z

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-01-15T02:09:55Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Fix aws_lb network in AWS GovCloud

deb2832

github-actions bot added service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR. and removed service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Oct 27, 2023

terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 27, 2023

github-actions bot added the service/elbv2 Issues and PRs that pertain to the elbv2 service. label Oct 27, 2023

ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 27, 2023

jseiser mentioned this pull request Oct 27, 2023

[Bug]: v5.23.0 - aws_lb - Load balancer attribute key 'dns_record.client_routing_policy' is not supported on load balancers with type 'network' #34135

Closed

Merge branch 'main' into HEAD

01b0ad2

ewbankkit mentioned this pull request Dec 6, 2023

r/aws_lb: Add enforce_security_group_inbound_rules_on_private_link_traffic #33767

Merged

ewbankkit added 13 commits December 6, 2023 11:01

Tweak CHANGELOG entry.

fa60890

Add 'FindLoadBalancerAttributesByARN'.

41bf07a

elbv2: Lowercase some constant names.

7e710d9

r/aws_lb: Add attributes constants.

3958b24

r/aws_lb: Tidy up Delete.

23cfdff

Add 'flex.BoolValueToString', 'flex.IntValueToString' and 'flex.Strin…

7407d5b

…gToIntValue'.

Fix typo.

f6f95f7

r/aws_lb: Don't call Update from Create.

7a89bc3

r/aws_lb: Fix typos.

67c73db

r/aws_lb: Prune legacy attribute update code.

dd2af04

r/aws_lb: Handle 'enforce_security_group_inbound_rules_on_private_lin…

f631c09

…k_traffic' on Create.

r/aws_lb: Correctly handle 'access_logs' on Update.

127b953

d/aws_lb: Add dns_record_client_routing_policy attribute.

8840dd5

ewbankkit self-assigned this Dec 7, 2023

ewbankkit added this to the v5.31.0 milestone Dec 7, 2023

ewbankkit added 3 commits December 7, 2023 15:04

r/aws_lb: Remove custom Set function for 'subnet_mapping'.

579c0a9

r/aws_lb: Acceptance test fixes for US GovCloud.

fb2c4b6

r/aws_lb: Remove 'testing.Short' from acceptance tests.

f193acc

ewbankkit approved these changes Dec 8, 2023

View reviewed changes

ewbankkit merged commit bc36495 into hashicorp:main Dec 8, 2023
36 checks passed

bryantbiggs mentioned this pull request Dec 11, 2023

feat: Add option enforce_security_group_inbound_rules_on_private_link_traffic terraform-aws-modules/terraform-aws-alb#332

Merged

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix aws_lb network in AWS GovCloud #34140

Fix aws_lb network in AWS GovCloud #34140

jseiser commented Oct 27, 2023 •

edited by ewbankkit

github-actions bot commented Oct 27, 2023

jseiser commented Nov 1, 2023

jseiser commented Nov 16, 2023

zhaque44 commented Dec 5, 2023

jseiser commented Dec 5, 2023

ewbankkit commented Dec 5, 2023

ewbankkit left a comment

ewbankkit commented Dec 8, 2023

zhaque44 commented Dec 8, 2023

ewbankkit commented Dec 8, 2023

github-actions bot commented Dec 15, 2023

github-actions bot commented Jan 15, 2024

Fix aws_lb network in AWS GovCloud #34140

Fix aws_lb network in AWS GovCloud #34140

Conversation

jseiser commented Oct 27, 2023 • edited by ewbankkit

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Oct 27, 2023

Community Note

jseiser commented Nov 1, 2023

jseiser commented Nov 16, 2023

zhaque44 commented Dec 5, 2023

jseiser commented Dec 5, 2023

ewbankkit commented Dec 5, 2023

ewbankkit left a comment

Choose a reason for hiding this comment

AWS US GovCloud

ewbankkit commented Dec 8, 2023

zhaque44 commented Dec 8, 2023

ewbankkit commented Dec 8, 2023

github-actions bot commented Dec 15, 2023

github-actions bot commented Jan 15, 2024

jseiser commented Oct 27, 2023 •

edited by ewbankkit