Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F verifiedaccess endpoint #34156

Merged
merged 14 commits into from
Oct 31, 2023

Conversation

markoskandylis
Copy link
Contributor

@markoskandylis markoskandylis commented Oct 29, 2023

Description

Adds support for VerrifiedAccess Endpoint

Relations

Relates #29689.

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_VerifiedAccessEndpoint.html

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccEC2VerifiedAccessEndpoint_' PKG=ec2  ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2VerifiedAccessEndpoint_ -timeout 360m
=== RUN   TestAccEC2VerifiedAccessEndpoint_basic
=== PAUSE TestAccEC2VerifiedAccessEndpoint_basic
=== RUN   TestAccEC2VerifiedAccessEndpoint_networkInterface
=== PAUSE TestAccEC2VerifiedAccessEndpoint_networkInterface
=== RUN   TestAccEC2VerifiedAccessEndpoint_tags
=== PAUSE TestAccEC2VerifiedAccessEndpoint_tags
=== RUN   TestAccEC2VerifiedAccessEndpoint_disappears
=== PAUSE TestAccEC2VerifiedAccessEndpoint_disappears
=== CONT  TestAccEC2VerifiedAccessEndpoint_basic
=== CONT  TestAccEC2VerifiedAccessEndpoint_tags
=== CONT  TestAccEC2VerifiedAccessEndpoint_networkInterface
--- PASS: TestAccEC2VerifiedAccessEndpoint_tags (1164.51s)
=== CONT  TestAccEC2VerifiedAccessEndpoint_disappears
--- PASS: TestAccEC2VerifiedAccessEndpoint_networkInterface (1188.87s)
--- PASS: TestAccEC2VerifiedAccessEndpoint_basic (1236.50s)
--- PASS: TestAccEC2VerifiedAccessEndpoint_disappears (1459.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2627.346s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. labels Oct 29, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 29, 2023
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 30, 2023
% make testacc TESTARGS='-run=TestAccEC2VerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2VerifiedAccessEndpoint_ -timeout 360m
=== RUN   TestAccEC2VerifiedAccessEndpoint_basic
=== PAUSE TestAccEC2VerifiedAccessEndpoint_basic
=== RUN   TestAccEC2VerifiedAccessEndpoint_disappears
=== PAUSE TestAccEC2VerifiedAccessEndpoint_disappears
=== CONT  TestAccEC2VerifiedAccessEndpoint_basic
=== CONT  TestAccEC2VerifiedAccessEndpoint_disappears
--- PASS: TestAccEC2VerifiedAccessEndpoint_disappears (1408.01s)
--- PASS: TestAccEC2VerifiedAccessEndpoint_basic (1470.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1484.543s
@ewbankkit
Copy link
Contributor

Acceptance tests so far:

% make testacc TESTARGS='-run=TestAccEC2VerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2VerifiedAccessEndpoint_ -timeout 360m
=== RUN   TestAccEC2VerifiedAccessEndpoint_basic
=== PAUSE TestAccEC2VerifiedAccessEndpoint_basic
=== RUN   TestAccEC2VerifiedAccessEndpoint_disappears
=== PAUSE TestAccEC2VerifiedAccessEndpoint_disappears
=== CONT  TestAccEC2VerifiedAccessEndpoint_basic
=== CONT  TestAccEC2VerifiedAccessEndpoint_disappears
--- PASS: TestAccEC2VerifiedAccessEndpoint_disappears (1408.01s)
--- PASS: TestAccEC2VerifiedAccessEndpoint_basic (1470.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1484.543s

@markoskandylis
Copy link
Contributor Author

make testacc TESTARGS='-run=TestAccEC2VerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2VerifiedAccessEndpoint_ -timeout 360m
=== RUN TestAccEC2VerifiedAccessEndpoint_basic
=== PAUSE TestAccEC2VerifiedAccessEndpoint_basic
=== RUN TestAccEC2VerifiedAccessEndpoint_networkInterface
=== PAUSE TestAccEC2VerifiedAccessEndpoint_networkInterface
=== RUN TestAccEC2VerifiedAccessEndpoint_tags
=== PAUSE TestAccEC2VerifiedAccessEndpoint_tags
=== RUN TestAccEC2VerifiedAccessEndpoint_disappears
=== PAUSE TestAccEC2VerifiedAccessEndpoint_disappears
=== CONT TestAccEC2VerifiedAccessEndpoint_basic
=== CONT TestAccEC2VerifiedAccessEndpoint_tags
=== CONT TestAccEC2VerifiedAccessEndpoint_networkInterface
--- PASS: TestAccEC2VerifiedAccessEndpoint_tags (1049.66s)
=== CONT TestAccEC2VerifiedAccessEndpoint_disappears
--- PASS: TestAccEC2VerifiedAccessEndpoint_networkInterface (1070.57s)
--- PASS: TestAccEC2VerifiedAccessEndpoint_basic (1085.81s)

--- PASS: TestAccEC2VerifiedAccessEndpoint_disappears (1256.95s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 2310.058s

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccVerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessEndpoint_ -timeout 720m
=== RUN   TestAccVerifiedAccessEndpoint_basic
=== PAUSE TestAccVerifiedAccessEndpoint_basic
=== RUN   TestAccVerifiedAccessEndpoint_networkInterface
=== PAUSE TestAccVerifiedAccessEndpoint_networkInterface
=== RUN   TestAccVerifiedAccessEndpoint_tags
=== PAUSE TestAccVerifiedAccessEndpoint_tags
=== RUN   TestAccVerifiedAccessEndpoint_disappears
=== PAUSE TestAccVerifiedAccessEndpoint_disappears
=== CONT  TestAccVerifiedAccessEndpoint_basic
=== CONT  TestAccVerifiedAccessEndpoint_tags
--- PASS: TestAccVerifiedAccessEndpoint_tags (1143.93s)
=== CONT  TestAccVerifiedAccessEndpoint_networkInterface
--- PASS: TestAccVerifiedAccessEndpoint_basic (1361.01s)
=== CONT  TestAccVerifiedAccessEndpoint_disappears
--- PASS: TestAccVerifiedAccessEndpoint_networkInterface (1059.30s)
--- PASS: TestAccVerifiedAccessEndpoint_disappears (1387.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2753.739s

@ewbankkit
Copy link
Contributor

@markoskandylis Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8423c75 into hashicorp:main Oct 31, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.24.0 milestone Oct 31, 2023
Copy link

github-actions bot commented Nov 2, 2023

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Dec 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants