Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove force new on eks vpc change #34209

Merged
merged 11 commits into from Nov 6, 2023
Merged

Remove force new on eks vpc change #34209

merged 11 commits into from Nov 6, 2023

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Nov 1, 2023

Description

Removes the force new components. The update api now allows for it.

Relations

Closes #34090.

References

https://aws.amazon.com/about-aws/whats-new/2023/10/amazon-eks-modification-cluster-subnets-security/
aws/containers-roadmap#170

Output from Acceptance Testing

%  make testacc TESTS=TestAccEKSCluster_VPC_securityGroupIDs_update PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_VPC_securityGroupIDs_update'  -timeout 360m
=== RUN   TestAccEKSCluster_VPC_securityGroupIDs_update
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs_update
=== CONT  TestAccEKSCluster_VPC_securityGroupIDs_update
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs_update (953.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	956.809s

Note for maintainer:
Due to an API restriction, each of the API calls requires a different update call, which utilizes the provided timeout. I am unsure if this break convention, but the alternative approach is erroring out initially if more than one update is made. Open to either approach.

Copy link

github-actions bot commented Nov 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/eks Issues and PRs that pertain to the eks service. and removed size/XS Managed by automation to categorize the size of a PR. labels Nov 1, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 1, 2023
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Nov 1, 2023
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Nov 1, 2023
@danquack

This comment was marked as resolved.

@danquack danquack marked this pull request as ready for review November 2, 2023 16:29
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 2, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSCluster_VPC\|TestAccEKSCluster_basic' PKG=eks ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2  -run=TestAccEKSCluster_VPC\|TestAccEKSCluster_basic -timeout 360m
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_VPC_securityGroupIDs
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs
=== RUN   TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update
=== RUN   TestAccEKSCluster_VPC_endpointPrivateAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPrivateAccess
=== RUN   TestAccEKSCluster_VPC_endpointPublicAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPublicAccess
=== RUN   TestAccEKSCluster_VPC_publicAccessCIDRs
=== PAUSE TestAccEKSCluster_VPC_publicAccessCIDRs
=== CONT  TestAccEKSCluster_basic
=== CONT  TestAccEKSCluster_VPC_endpointPrivateAccess
--- PASS: TestAccEKSCluster_basic (644.54s)
=== CONT  TestAccEKSCluster_VPC_publicAccessCIDRs
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1479.10s)
=== CONT  TestAccEKSCluster_VPC_endpointPublicAccess
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (951.38s)
=== CONT  TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update
--- PASS: TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update (1507.49s)
=== CONT  TestAccEKSCluster_VPC_securityGroupIDs
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1344.08s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (625.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        2841.829s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit da1568d into hashicorp:main Nov 6, 2023
36 checks passed
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 6, 2023
@danquack danquack deleted the patch-2 branch November 6, 2023 22:39
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support updating EKS cluster subnets and security groups
3 participants