Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TechDebt: Migrate apprunner service to aws-sdk-go-v2 #34292

Merged
merged 72 commits into from
Nov 22, 2023
Merged

TechDebt: Migrate apprunner service to aws-sdk-go-v2 #34292

merged 72 commits into from
Nov 22, 2023

Conversation

brittandeyoung
Copy link
Collaborator

@brittandeyoung brittandeyoung commented Nov 7, 2023 •
edited by ewbankkit

Description

This pull request converts the apprunner service to use the aws-sdk-go-v2.

Relations

Relates #32976.
Closes #34192.
Closes #30216.
Closes #27861.

References

Output from Acceptance Testing

➜ terraform-provider-aws (td-apprunner-aws-sdk-go-v2) ✔ make testacc TESTARGS='-run=TestAccAppRunner' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunner -timeout 360m
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_complex
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_complex
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_multipleVersions
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_multipleVersions
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_updateMultipleVersions
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_updateMultipleVersions
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_disappears
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_disappears
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_tags
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_tags
=== RUN   TestAccAppRunnerConnection_basic
=== PAUSE TestAccAppRunnerConnection_basic
=== RUN   TestAccAppRunnerConnection_disappears
=== PAUSE TestAccAppRunnerConnection_disappears
=== RUN   TestAccAppRunnerConnection_tags
=== PAUSE TestAccAppRunnerConnection_tags
=== RUN   TestAccAppRunnerCustomDomainAssociation_basic
    custom_domain_association_test.go:28: Environment variable APPRUNNER_CUSTOM_DOMAIN is not set
--- SKIP: TestAccAppRunnerCustomDomainAssociation_basic (0.00s)
=== RUN   TestAccAppRunnerCustomDomainAssociation_disappears
    custom_domain_association_test.go:67: Environment variable APPRUNNER_CUSTOM_DOMAIN is not set
--- SKIP: TestAccAppRunnerCustomDomainAssociation_disappears (0.00s)
=== RUN   TestAccAppRunnerObservabilityConfiguration_basic
=== PAUSE TestAccAppRunnerObservabilityConfiguration_basic
=== RUN   TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== PAUSE TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== RUN   TestAccAppRunnerObservabilityConfiguration_disappears
=== PAUSE TestAccAppRunnerObservabilityConfiguration_disappears
=== RUN   TestAccAppRunnerObservabilityConfiguration_tags
=== PAUSE TestAccAppRunnerObservabilityConfiguration_tags
=== RUN   TestAccAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAppRunnerService_ImageRepository_basic
=== RUN   TestAccAppRunnerService_ImageRepository_autoScaling
=== PAUSE TestAccAppRunnerService_ImageRepository_autoScaling
=== RUN   TestAccAppRunnerService_ImageRepository_encryption
=== PAUSE TestAccAppRunnerService_ImageRepository_encryption
=== RUN   TestAccAppRunnerService_ImageRepository_healthCheck
=== PAUSE TestAccAppRunnerService_ImageRepository_healthCheck
=== RUN   TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
=== RUN   TestAccAppRunnerService_ImageRepository_instance_Update
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_Update
=== RUN   TestAccAppRunnerService_ImageRepository_instance_Update1
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_Update1
=== RUN   TestAccAppRunnerService_ImageRepository_networkConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_networkConfiguration
=== RUN   TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== RUN   TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
=== PAUSE TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
=== RUN   TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets
=== PAUSE TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets
=== RUN   TestAccAppRunnerService_disappears
=== PAUSE TestAccAppRunnerService_disappears
=== RUN   TestAccAppRunnerService_tags
=== PAUSE TestAccAppRunnerService_tags
=== RUN   TestAccAppRunnerVPCConnector_basic
=== PAUSE TestAccAppRunnerVPCConnector_basic
=== RUN   TestAccAppRunnerVPCConnector_disappears
=== PAUSE TestAccAppRunnerVPCConnector_disappears
=== RUN   TestAccAppRunnerVPCConnector_tags
=== PAUSE TestAccAppRunnerVPCConnector_tags
=== RUN   TestAccAppRunnerVPCConnector_defaultTags
=== PAUSE TestAccAppRunnerVPCConnector_defaultTags
=== RUN   TestAccAppRunnerVPCIngressConnection_basic
=== PAUSE TestAccAppRunnerVPCIngressConnection_basic
=== RUN   TestAccAppRunnerVPCIngressConnection_disappears
=== PAUSE TestAccAppRunnerVPCIngressConnection_disappears
=== RUN   TestAccAppRunnerVPCIngressConnection_tags
=== PAUSE TestAccAppRunnerVPCIngressConnection_tags
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== CONT  TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
=== CONT  TestAccAppRunnerService_tags
=== CONT  TestAccAppRunnerVPCConnector_tags
=== CONT  TestAccAppRunnerVPCConnector_basic
=== CONT  TestAccAppRunnerService_disappears
=== CONT  TestAccAppRunnerService_ImageRepository_instance_Update1
=== CONT  TestAccAppRunnerService_ImageRepository_instance_Update
=== CONT  TestAccAppRunnerService_ImageRepository_networkConfiguration
=== CONT  TestAccAppRunnerObservabilityConfiguration_basic
=== CONT  TestAccAppRunnerVPCIngressConnection_tags
=== CONT  TestAccAppRunnerVPCConnector_defaultTags
=== CONT  TestAccAppRunnerVPCIngressConnection_basic
=== CONT  TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== CONT  TestAccAppRunnerVPCConnector_disappears
=== CONT  TestAccAppRunnerVPCIngressConnection_disappears
=== CONT  TestAccAppRunnerConnection_tags
=== CONT  TestAccAppRunnerConnection_basic
=== CONT  TestAccAppRunnerConnection_disappears
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_tags
=== NAME  TestAccAppRunnerService_ImageRepository_networkConfiguration
    service_test.go:358: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating EC2 VPC: operation error EC2: CreateVpc, https response error StatusCode: 400, RequestID: 0b257eee-9282-4fb4-ac18-ddf9499712f0, api error VpcLimitExceeded: The maximum number of VPCs has been reached.
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- FAIL: TestAccAppRunnerService_ImageRepository_networkConfiguration (37.35s)
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_disappears
--- PASS: TestAccAppRunnerConnection_disappears (52.02s)
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_updateMultipleVersions
--- PASS: TestAccAppRunnerObservabilityConfiguration_basic (63.08s)
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_multipleVersions
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_basic (63.66s)
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_complex
--- PASS: TestAccAppRunnerConnection_basic (66.79s)
=== CONT  TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
--- PASS: TestAccAppRunnerVPCConnector_disappears (69.67s)
=== CONT  TestAccAppRunnerService_ImageRepository_basic
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_disappears (37.02s)
=== CONT  TestAccAppRunnerService_ImageRepository_healthCheck
--- PASS: TestAccAppRunnerVPCConnector_basic (77.45s)
=== CONT  TestAccAppRunnerService_ImageRepository_encryption
--- PASS: TestAccAppRunnerVPCConnector_defaultTags (109.81s)
=== CONT  TestAccAppRunnerService_ImageRepository_autoScaling
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_tags (117.66s)
=== CONT  TestAccAppRunnerObservabilityConfiguration_disappears
--- PASS: TestAccAppRunnerConnection_tags (118.86s)
=== CONT  TestAccAppRunnerObservabilityConfiguration_tags
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_updateMultipleVersions (74.09s)
=== CONT  TestAccAppRunnerObservabilityConfiguration_traceConfiguration
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_multipleVersions (66.80s)
=== CONT  TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets
--- PASS: TestAccAppRunnerVPCConnector_tags (138.91s)
--- PASS: TestAccAppRunnerObservabilityConfiguration_disappears (24.11s)
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_complex (86.87s)
--- PASS: TestAccAppRunnerObservabilityConfiguration_traceConfiguration (26.98s)
--- PASS: TestAccAppRunnerObservabilityConfiguration_tags (57.23s)
--- PASS: TestAccAppRunnerService_disappears (265.83s)
=== NAME  TestAccAppRunnerVPCIngressConnection_disappears
    vpc_ingress_connection_test.go:66: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating EC2 VPC: operation error EC2: CreateVpc, https response error StatusCode: 400, RequestID: 6b7fd78e-028b-41ff-942c-5fbbe6364a17, api error VpcLimitExceeded: The maximum number of VPCs has been reached.
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
=== NAME  TestAccAppRunnerVPCIngressConnection_basic
    vpc_ingress_connection_test.go:33: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating EC2 VPC: operation error EC2: CreateVpc, https response error StatusCode: 400, RequestID: 42893656-2286-4029-95e7-00029814aeb2, api error VpcLimitExceeded: The maximum number of VPCs has been reached.
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- FAIL: TestAccAppRunnerVPCIngressConnection_disappears (303.14s)
--- FAIL: TestAccAppRunnerVPCIngressConnection_basic (303.34s)
=== NAME  TestAccAppRunnerVPCIngressConnection_tags
    vpc_ingress_connection_test.go:89: Step 1/4 error: Error running apply: exit status 1
        
        Error: creating EC2 VPC: operation error EC2: CreateVpc, https response error StatusCode: 400, RequestID: f2a21149-5d7d-4f02-89bb-04576e69c882, api error VpcLimitExceeded: The maximum number of VPCs has been reached.
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- PASS: TestAccAppRunnerService_tags (304.99s)
--- PASS: TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars (245.01s)
--- PASS: TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole (311.94s)
--- PASS: TestAccAppRunnerService_ImageRepository_basic (243.70s)
--- FAIL: TestAccAppRunnerVPCIngressConnection_tags (330.19s)
--- PASS: TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets (277.65s)
--- PASS: TestAccAppRunnerService_ImageRepository_instance_Update1 (472.79s)
--- PASS: TestAccAppRunnerService_ImageRepository_instance_Update (473.27s)
--- PASS: TestAccAppRunnerService_ImageRepository_autoScaling (406.43s)
--- PASS: TestAccAppRunnerService_ImageRepository_observabilityConfiguration (526.47s)
--- PASS: TestAccAppRunnerService_ImageRepository_healthCheck (502.59s)
--- PASS: TestAccAppRunnerService_ImageRepository_encryption (506.08s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  587.424s
FAIL
make: *** [testacc] Error 1

➜ terraform-provider-aws (td-apprunner-aws-sdk-go-v2) ✔ make testacc TESTARGS='-run=TestAccAppRunnerVPCIngressConnection_tags' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunnerVPCIngressConnection_tags -timeout 360m
=== RUN   TestAccAppRunnerVPCIngressConnection_tags
=== PAUSE TestAccAppRunnerVPCIngressConnection_tags
=== CONT  TestAccAppRunnerVPCIngressConnection_tags
--- PASS: TestAccAppRunnerVPCIngressConnection_tags (462.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  465.913s

➜ terraform-provider-aws (td-apprunner-aws-sdk-go-v2) ✔ make testacc TESTARGS='-run=TestAccAppRunnerVPCIngressConnection_basic' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunnerVPCIngressConnection_basic -timeout 360m
=== RUN   TestAccAppRunnerVPCIngressConnection_basic
=== PAUSE TestAccAppRunnerVPCIngressConnection_basic
=== CONT  TestAccAppRunnerVPCIngressConnection_basic
--- PASS: TestAccAppRunnerVPCIngressConnection_basic (487.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  490.293s

➜ terraform-provider-aws (td-apprunner-aws-sdk-go-v2) ✔ make testacc TESTARGS='-run=TestAccAppRunnerService_ImageRepository_networkConfiguration' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunnerService_ImageRepository_networkConfiguration -timeout 360m
=== RUN   TestAccAppRunnerService_ImageRepository_networkConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_networkConfiguration
=== CONT  TestAccAppRunnerService_ImageRepository_networkConfiguration
--- PASS: TestAccAppRunnerService_ImageRepository_networkConfiguration (512.04s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  515.229s
...

@brittandeyoung
go get github.com/aws/aws-sdk-go-v2/service/apprunner
6da8b0a
@brittandeyoung
names: Update apprunner to use aws-sdk-go-v2
0512115
@brittandeyoung
conns: generate new apprunner aws-sdk-go-v2 client
bc95884
@brittandeyoung
apprunner: Amend generate, update tags gen to sdk-v2
e77f62d
@brittandeyoung
apprunner: re-generate tags_gen with sdk-v2
0f6687c
@brittandeyoung
apprunner: Amend auto_scaling_configuration_version, migrate to aws-s…
97539d4 
…dk-go-v2
@brittandeyoung
apprunner: Amend auto_scaling_configuration_version_test, migrate to …
88cbfce 
…aws-sdk-go-v2
@brittandeyoung
apprunner: Amend connection, migrate to aws-sdk-go-v2
7d3f05f
@brittandeyoung
apprunner: Amend connection_test, migrate to aws-sdk-go-v2
7ad4389
@brittandeyoung
apprunner: Amend custom_domain_association, migrate to aws-sdk-go-v2
b7e3596
@brittandeyoung
apprunner: Amend custom_domain_association_test, migrate to aws-sdk-g…
1db1305 
…o-v2
@brittandeyoung
apprunner: Amend find, migrate to aws-sdk-go-v2
27f8f3c
@brittandeyoung
apprunner: Amend observability_configuration, migrate to aws-sdk-go-v2
ed88d0b
@brittandeyoung
apprunner: Amend observability_configuration_version_test, migrate to…
a54966d 
… aws-sdk-go-v2
@brittandeyoung
apprunner: Amend service, migrate to aws-sdk-go-v2
f981c6d
@brittandeyoung
apprunner: Amend service_package_gen, migrate to aws-sdk-go-v2
030f895
@brittandeyoung
apprunner: Amend service_test, migrate to aws-sdk-go-v2
88074a6
@brittandeyoung
apprunner: Amend status, migrate to aws-sdk-go-v2
f68da77
@brittandeyoung
apprunner: Amend sweep, migrate to aws-sdk-go-v2
ebd1ab1
@brittandeyoung
apprunner: Amend vpc_connector, migrate to aws-sdk-go-v2
f0857dc
@brittandeyoung
apprunner: Amend vpc_connector_test, migrate to aws-sdk-go-v2
a2d8abe
@brittandeyoung
apprunner: Amend vpc_ingress_connection, migrate to aws-sdk-go-v2
c7f8475
@brittandeyoung
apprunner: Amend vpc_ingress_connection_test, migrate to aws-sdk-go-v2
68bb073
@brittandeyoung
apprunner: Amend wait, migrate to aws-sdk-go-v2
390101e
@brittandeyoung
apprunner: Amend find, golangci-lint
d86229d
@brittandeyoung
apprunner: Amend auto_scaling_configuration_version, use correct int …
aad4c92 
…type
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apprunner Issues and PRs that pertain to the apprunner service. labels Nov 7, 2023
@ewbankkit
Merge branch 'main' into HEAD
44580c4 
# Conflicts:
#	go.mod
#	go.sum
@ewbankkit
r/aws_apprunner_service: Add network_configuration.ip_address_type …
663e910 
…argument.
@ewbankkit
Acceptance test output:
baf3f0c 
% make testacc TESTARGS='-run=TestAccAppRunnerService_ImageRepository_basic' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerService_ImageRepository_basic -timeout 360m
=== RUN   TestAccAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAppRunnerService_ImageRepository_basic
=== CONT  TestAccAppRunnerService_ImageRepository_basic
--- PASS: TestAccAppRunnerService_ImageRepository_basic (191.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	197.385s
@ewbankkit
r/aws_apprunner_service: Add `source_configuration.code_repository.so…
3697706 
…urce_directory` argument to support monorepos.
@ewbankkit
r/aws_apprunner_service: Allow health_check_configuration to be upd…
7f55082 
…ated in-place.
@ewbankkit
Acceptance test output:
8de1ddb 
% make testacc TESTARGS='-run=TestAccAppRunnerService_ImageRepository_healthCheck' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerService_ImageRepository_healthCheck -timeout 360m
=== RUN   TestAccAppRunnerService_ImageRepository_healthCheck
=== PAUSE TestAccAppRunnerService_ImageRepository_healthCheck
=== CONT  TestAccAppRunnerService_ImageRepository_healthCheck
--- PASS: TestAccAppRunnerService_ImageRepository_healthCheck (356.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	361.648s
@ewbankkit
r/aws_apprunner_service: Use 'ListServices' to find 'service_url' for…
2cf7c6f 
… private services.
@ewbankkit
r/aws_apprunner_service: Find 'service_url' via custom domains for pr…
1d6c57b 
…ivate services.
@ewbankkit
Acceptance test output:
370a584 
% APPRUNNER_CUSTOM_DOMAIN=ewbankkit.com make testacc TESTARGS='-run=TestAccAppRunnerService_ImageRepository_networkConfiguration\|TestAccAppRunnerCustomDomainAssociation_basic' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerService_ImageRepository_networkConfiguration\|TestAccAppRunnerCustomDomainAssociation_basic -timeout 360m
=== RUN   TestAccAppRunnerCustomDomainAssociation_basic
=== PAUSE TestAccAppRunnerCustomDomainAssociation_basic
=== RUN   TestAccAppRunnerService_ImageRepository_networkConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_networkConfiguration
=== CONT  TestAccAppRunnerCustomDomainAssociation_basic
=== CONT  TestAccAppRunnerService_ImageRepository_networkConfiguration
--- PASS: TestAccAppRunnerCustomDomainAssociation_basic (190.00s)
--- PASS: TestAccAppRunnerService_ImageRepository_networkConfiguration (488.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	493.964s
@ewbankkit
Add CHANGELOG entry.
6b93aa9
@ewbankkit
r/aws_apprunner_service: Change observability_configuration to Forc…
b304c73 
…eNew.
@ewbankkit
Revert "r/aws_apprunner_service: Change observability_configuration…
76b7cbc 
… to ForceNew."

This reverts commit b304c73.
@ewbankkit
r/aws_apprunner_auto_scaling_configuration_version: Add is_default …
eb33475 
…argument and `has_associated_service` attribute.
@ewbankkit
r/aws_apprunner_auto_scaling_configuration_version: 'is_default' is r…
1f1c8ea 
…ead-only.
@ewbankkit
Acceptance test output:
bc742e5 
% make testacc TESTARGS='-run=TestAccAppRunnerAutoScalingConfigurationVersion_basic' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunnerAutoScalingConfigurationVersion_basic -timeout 360m
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_basic
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_basic (23.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	29.181s
@ewbankkit
r/aws_apprunner_default_auto_scaling_configuration_version: New resou…
95a6877 
…rce.
@ewbankkit
r/aws_apprunner_default_auto_scaling_configuration_version: Documenta…
15e1f5d 
…tion.
@ewbankkit
r/aws_apprunner_default_auto_scaling_configuration_version: Acceptanc…
9ba102b 
…e tests.
@ewbankkit
Acceptance test output:
16b2109 
% make testacc TESTARGS='-run=TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial -timeout 360m
=== RUN   TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial
=== PAUSE TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial
=== CONT  TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial
=== RUN   TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial/basic
--- PASS: TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial (56.07s)
    --- PASS: TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial/basic (56.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	61.601s
ewbankkit
ewbankkit approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppRunnerAutoScalingConfigurationVersion_' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerAutoScalingConfigurationVersion_ -timeout 360m
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_complex
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_complex
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_multipleVersions
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_multipleVersions
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_updateMultipleVersions
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_updateMultipleVersions
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_disappears
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_disappears
=== RUN   TestAccAppRunnerAutoScalingConfigurationVersion_tags
=== PAUSE TestAccAppRunnerAutoScalingConfigurationVersion_tags
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_basic
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_updateMultipleVersions
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_basic (24.75s)
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_multipleVersions
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_updateMultipleVersions (48.24s)
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_tags
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_multipleVersions (43.35s)
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_disappears
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_disappears (17.45s)
=== CONT  TestAccAppRunnerAutoScalingConfigurationVersion_complex
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_tags (55.52s)
--- PASS: TestAccAppRunnerAutoScalingConfigurationVersion_complex (58.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	149.424s
% make testacc TESTARGS='-run=TestAccAppRunnerConnection_' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerConnection_ -timeout 360m
=== RUN   TestAccAppRunnerConnection_basic
=== PAUSE TestAccAppRunnerConnection_basic
=== RUN   TestAccAppRunnerConnection_disappears
=== PAUSE TestAccAppRunnerConnection_disappears
=== RUN   TestAccAppRunnerConnection_tags
=== PAUSE TestAccAppRunnerConnection_tags
=== CONT  TestAccAppRunnerConnection_disappears
=== CONT  TestAccAppRunnerConnection_tags
--- PASS: TestAccAppRunnerConnection_disappears (39.91s)
=== CONT  TestAccAppRunnerConnection_basic
--- PASS: TestAccAppRunnerConnection_basic (48.35s)
--- PASS: TestAccAppRunnerConnection_tags (111.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	125.470s
% APPRUNNER_CUSTOM_DOMAIN=ewbankkit.com make testacc TESTARGS='-run=TestAccAppRunnerCustomDomainAssociation_' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerCustomDomainAssociation_ -timeout 360m
=== RUN   TestAccAppRunnerCustomDomainAssociation_basic
=== PAUSE TestAccAppRunnerCustomDomainAssociation_basic
=== RUN   TestAccAppRunnerCustomDomainAssociation_disappears
=== PAUSE TestAccAppRunnerCustomDomainAssociation_disappears
=== CONT  TestAccAppRunnerCustomDomainAssociation_basic
=== CONT  TestAccAppRunnerCustomDomainAssociation_disappears
--- PASS: TestAccAppRunnerCustomDomainAssociation_disappears (248.66s)
--- PASS: TestAccAppRunnerCustomDomainAssociation_basic (279.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	285.448s
% make testacc TESTARGS='-run=TestAccAppRunnerObservabilityConfiguration_' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerObservabilityConfiguration_ -timeout 360m
=== RUN   TestAccAppRunnerObservabilityConfiguration_basic
=== PAUSE TestAccAppRunnerObservabilityConfiguration_basic
=== RUN   TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== PAUSE TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== RUN   TestAccAppRunnerObservabilityConfiguration_disappears
=== PAUSE TestAccAppRunnerObservabilityConfiguration_disappears
=== RUN   TestAccAppRunnerObservabilityConfiguration_tags
=== PAUSE TestAccAppRunnerObservabilityConfiguration_tags
=== CONT  TestAccAppRunnerObservabilityConfiguration_basic
=== CONT  TestAccAppRunnerObservabilityConfiguration_disappears
--- PASS: TestAccAppRunnerObservabilityConfiguration_disappears (19.91s)
=== CONT  TestAccAppRunnerObservabilityConfiguration_traceConfiguration
--- PASS: TestAccAppRunnerObservabilityConfiguration_basic (26.20s)
=== CONT  TestAccAppRunnerObservabilityConfiguration_tags
--- PASS: TestAccAppRunnerObservabilityConfiguration_traceConfiguration (25.73s)
--- PASS: TestAccAppRunnerObservabilityConfiguration_tags (55.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	87.866s
% make testacc TESTARGS='-run=TestAccAppRunnerVPCIngressConnection_' PKG=apprunner ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 1  -run=TestAccAppRunnerVPCIngressConnection_ -timeout 360m
=== RUN   TestAccAppRunnerVPCIngressConnection_basic
=== PAUSE TestAccAppRunnerVPCIngressConnection_basic
=== RUN   TestAccAppRunnerVPCIngressConnection_disappears
=== PAUSE TestAccAppRunnerVPCIngressConnection_disappears
=== RUN   TestAccAppRunnerVPCIngressConnection_tags
=== PAUSE TestAccAppRunnerVPCIngressConnection_tags
=== CONT  TestAccAppRunnerVPCIngressConnection_basic
--- PASS: TestAccAppRunnerVPCIngressConnection_basic (332.82s)
=== CONT  TestAccAppRunnerVPCIngressConnection_tags
--- PASS: TestAccAppRunnerVPCIngressConnection_tags (410.40s)
=== CONT  TestAccAppRunnerVPCIngressConnection_disappears
--- PASS: TestAccAppRunnerVPCIngressConnection_disappears (359.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	1108.585s
% make testacc TESTARGS='-run=TestAccAppRunnerVPCConnector_' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerVPCConnector_ -timeout 360m
=== RUN   TestAccAppRunnerVPCConnector_basic
=== PAUSE TestAccAppRunnerVPCConnector_basic
=== RUN   TestAccAppRunnerVPCConnector_disappears
=== PAUSE TestAccAppRunnerVPCConnector_disappears
=== RUN   TestAccAppRunnerVPCConnector_tags
=== PAUSE TestAccAppRunnerVPCConnector_tags
=== RUN   TestAccAppRunnerVPCConnector_defaultTags
=== PAUSE TestAccAppRunnerVPCConnector_defaultTags
=== CONT  TestAccAppRunnerVPCConnector_basic
=== CONT  TestAccAppRunnerVPCConnector_defaultTags
--- PASS: TestAccAppRunnerVPCConnector_basic (34.20s)
=== CONT  TestAccAppRunnerVPCConnector_tags
--- PASS: TestAccAppRunnerVPCConnector_defaultTags (67.40s)
=== CONT  TestAccAppRunnerVPCConnector_disappears
--- PASS: TestAccAppRunnerVPCConnector_disappears (56.11s)
--- PASS: TestAccAppRunnerVPCConnector_tags (129.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	169.768s
% make testacc TESTARGS='-run=TestAccAppRunnerService_' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerService_ -timeout 360m
=== RUN   TestAccAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAppRunnerService_ImageRepository_basic
=== RUN   TestAccAppRunnerService_ImageRepository_autoScaling
=== PAUSE TestAccAppRunnerService_ImageRepository_autoScaling
=== RUN   TestAccAppRunnerService_ImageRepository_encryption
=== PAUSE TestAccAppRunnerService_ImageRepository_encryption
=== RUN   TestAccAppRunnerService_ImageRepository_healthCheck
=== PAUSE TestAccAppRunnerService_ImageRepository_healthCheck
=== RUN   TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
=== RUN   TestAccAppRunnerService_ImageRepository_instance_Update
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_Update
=== RUN   TestAccAppRunnerService_ImageRepository_instance_Update1
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_Update1
=== RUN   TestAccAppRunnerService_ImageRepository_networkConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_networkConfiguration
=== RUN   TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== RUN   TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
=== PAUSE TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
=== RUN   TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets
=== PAUSE TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets
=== RUN   TestAccAppRunnerService_disappears
=== PAUSE TestAccAppRunnerService_disappears
=== RUN   TestAccAppRunnerService_tags
=== PAUSE TestAccAppRunnerService_tags
=== CONT  TestAccAppRunnerService_ImageRepository_basic
=== CONT  TestAccAppRunnerService_ImageRepository_networkConfiguration
--- PASS: TestAccAppRunnerService_ImageRepository_basic (193.69s)
=== CONT  TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
--- PASS: TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole (191.68s)
=== CONT  TestAccAppRunnerService_ImageRepository_instance_Update1
--- PASS: TestAccAppRunnerService_ImageRepository_networkConfiguration (468.31s)
=== CONT  TestAccAppRunnerService_ImageRepository_instance_Update
--- PASS: TestAccAppRunnerService_ImageRepository_instance_Update1 (400.22s)
=== CONT  TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets
--- PASS: TestAccAppRunnerService_ImageRepository_instance_Update (391.59s)
=== CONT  TestAccAppRunnerService_tags
--- PASS: TestAccAppRunnerService_ImageRepository_runtimeEnvironmentSecrets (184.60s)
=== CONT  TestAccAppRunnerService_disappears
--- PASS: TestAccAppRunnerService_tags (202.89s)
=== CONT  TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
--- PASS: TestAccAppRunnerService_disappears (178.58s)
=== CONT  TestAccAppRunnerService_ImageRepository_encryption
--- PASS: TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars (197.90s)
=== CONT  TestAccAppRunnerService_ImageRepository_healthCheck
--- PASS: TestAccAppRunnerService_ImageRepository_encryption (345.88s)
=== CONT  TestAccAppRunnerService_ImageRepository_autoScaling
--- PASS: TestAccAppRunnerService_ImageRepository_healthCheck (365.57s)
=== CONT  TestAccAppRunnerService_ImageRepository_observabilityConfiguration
--- PASS: TestAccAppRunnerService_ImageRepository_autoScaling (347.72s)
--- PASS: TestAccAppRunnerService_ImageRepository_observabilityConfiguration (371.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	2004.039s
% make testacc TESTARGS='-run=TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20  -run=TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial -timeout 360m
=== RUN   TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial
=== PAUSE TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial
=== CONT  TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial
=== RUN   TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial/basic
--- PASS: TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial (56.07s)
    --- PASS: TestAccAppRunnerDefaultAutoScalingConfigurationVersion_serial/basic (56.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	61.601s

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Nov 22, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 22, 2023
@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1913fce into hashicorp:main Nov 22, 2023
50 checks passed
@github-actions github-actions bot added this to the v5.27.0 milestone Nov 22, 2023
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-resource Introduces a new resource. service/apprunner Issues and PRs that pertain to the apprunner service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.27.0
3 participants
@brittandeyoung @ewbankkit @justinretzolk