Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #34158 #34326

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Fixes for #34158 #34326

merged 3 commits into from
Nov 9, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 9, 2023

Description

A couple of fixes on merge for #34158.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSageMakerModel_' PKG=sagemaker ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 2  -run=TestAccSageMakerModel_ -timeout 360m
=== RUN   TestAccSageMakerModel_basic
=== PAUSE TestAccSageMakerModel_basic
=== RUN   TestAccSageMakerModel_inferenceExecution
=== PAUSE TestAccSageMakerModel_inferenceExecution
=== RUN   TestAccSageMakerModel_tags
=== PAUSE TestAccSageMakerModel_tags
=== RUN   TestAccSageMakerModel_primaryContainerModelDataURL
=== PAUSE TestAccSageMakerModel_primaryContainerModelDataURL
=== RUN   TestAccSageMakerModel_primaryContainerHostname
=== PAUSE TestAccSageMakerModel_primaryContainerHostname
=== RUN   TestAccSageMakerModel_primaryContainerImage
=== PAUSE TestAccSageMakerModel_primaryContainerImage
=== RUN   TestAccSageMakerModel_primaryContainerEnvironment
=== PAUSE TestAccSageMakerModel_primaryContainerEnvironment
=== RUN   TestAccSageMakerModel_primaryContainerModeSingle
=== PAUSE TestAccSageMakerModel_primaryContainerModeSingle
=== RUN   TestAccSageMakerModel_primaryContainerModelPackageName
=== PAUSE TestAccSageMakerModel_primaryContainerModelPackageName
=== RUN   TestAccSageMakerModel_primaryContainerModelDataSource
=== PAUSE TestAccSageMakerModel_primaryContainerModelDataSource
=== RUN   TestAccSageMakerModel_containers
=== PAUSE TestAccSageMakerModel_containers
=== RUN   TestAccSageMakerModel_vpc
=== PAUSE TestAccSageMakerModel_vpc
=== RUN   TestAccSageMakerModel_primaryContainerPrivateDockerRegistry
=== PAUSE TestAccSageMakerModel_primaryContainerPrivateDockerRegistry
=== RUN   TestAccSageMakerModel_networkIsolation
=== PAUSE TestAccSageMakerModel_networkIsolation
=== RUN   TestAccSageMakerModel_disappears
=== PAUSE TestAccSageMakerModel_disappears
=== CONT  TestAccSageMakerModel_basic
=== CONT  TestAccSageMakerModel_primaryContainerModelPackageName
--- PASS: TestAccSageMakerModel_basic (34.23s)
=== CONT  TestAccSageMakerModel_primaryContainerPrivateDockerRegistry
--- PASS: TestAccSageMakerModel_primaryContainerPrivateDockerRegistry (37.75s)
=== CONT  TestAccSageMakerModel_disappears
--- PASS: TestAccSageMakerModel_disappears (30.44s)
=== CONT  TestAccSageMakerModel_networkIsolation
=== NAME  TestAccSageMakerModel_primaryContainerModelPackageName
    model_test.go:273: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating SageMaker model: ValidationException: Caller is not subscribed to the marketplace offering.
        	status code: 400, request id: 42e12e19-9b78-4ba1-85c0-33a855561186
        
          with aws_sagemaker_model.test,
          on terraform_plugin_test.tf line 54, in resource "aws_sagemaker_model" "test":
          54: resource "aws_sagemaker_model" "test" {
        
--- FAIL: TestAccSageMakerModel_primaryContainerModelPackageName (131.67s)
=== CONT  TestAccSageMakerModel_containers
--- PASS: TestAccSageMakerModel_networkIsolation (33.96s)
=== CONT  TestAccSageMakerModel_vpc
--- PASS: TestAccSageMakerModel_containers (35.15s)
=== CONT  TestAccSageMakerModel_primaryContainerHostname
--- PASS: TestAccSageMakerModel_vpc (36.13s)
=== CONT  TestAccSageMakerModel_primaryContainerModeSingle
--- PASS: TestAccSageMakerModel_primaryContainerHostname (34.40s)
=== CONT  TestAccSageMakerModel_primaryContainerEnvironment
--- PASS: TestAccSageMakerModel_primaryContainerModeSingle (35.14s)
=== CONT  TestAccSageMakerModel_primaryContainerImage
--- PASS: TestAccSageMakerModel_primaryContainerEnvironment (35.55s)
=== CONT  TestAccSageMakerModel_tags
--- PASS: TestAccSageMakerModel_primaryContainerImage (35.69s)
=== CONT  TestAccSageMakerModel_primaryContainerModelDataURL
--- PASS: TestAccSageMakerModel_primaryContainerModelDataURL (57.93s)
=== CONT  TestAccSageMakerModel_primaryContainerModelDataSource
--- PASS: TestAccSageMakerModel_tags (72.35s)
=== CONT  TestAccSageMakerModel_inferenceExecution
--- PASS: TestAccSageMakerModel_inferenceExecution (36.66s)
--- PASS: TestAccSageMakerModel_primaryContainerModelDataSource (55.73s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	362.527s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change (or #34158).

Copy link

github-actions bot commented Nov 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Nov 9, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 9, 2023
@ewbankkit ewbankkit added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Nov 9, 2023
@github-actions github-actions bot removed the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Nov 9, 2023
@ewbankkit ewbankkit merged commit 436254c into main Nov 9, 2023
73 checks passed
@ewbankkit ewbankkit deleted the fixup-34158 branch November 9, 2023 13:29
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 9, 2023
github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant