Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for policy_document property to VerifiedAccessEndpoint resource #34354

Closed

Conversation

sQu4rks
Copy link
Contributor

@sQu4rks sQu4rks commented Nov 10, 2023

Description

Adds support for the policy_document property on the VerifiedAccessEndpoint resource

Relations

Relates: #29689

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVerifiedAccessEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessEndpoint_ -timeout 360m
=== RUN   TestAccVerifiedAccessEndpoint_basic
=== PAUSE TestAccVerifiedAccessEndpoint_basic
=== RUN   TestAccVerifiedAccessEndpoint_policy
=== PAUSE TestAccVerifiedAccessEndpoint_policy
=== RUN   TestAccVerifiedAccessEndpoint_policyUpdate
=== PAUSE TestAccVerifiedAccessEndpoint_policyUpdate
=== RUN   TestAccVerifiedAccessEndpoint_networkInterface
=== PAUSE TestAccVerifiedAccessEndpoint_networkInterface
=== RUN   TestAccVerifiedAccessEndpoint_tags
=== PAUSE TestAccVerifiedAccessEndpoint_tags
=== RUN   TestAccVerifiedAccessEndpoint_disappears
=== PAUSE TestAccVerifiedAccessEndpoint_disappears
=== CONT  TestAccVerifiedAccessEndpoint_basic
=== CONT  TestAccVerifiedAccessEndpoint_networkInterface
--- PASS: TestAccVerifiedAccessEndpoint_networkInterface (445.39s)
=== CONT  TestAccVerifiedAccessEndpoint_disappears
--- PASS: TestAccVerifiedAccessEndpoint_basic (455.03s)
=== CONT  TestAccVerifiedAccessEndpoint_tags
--- PASS: TestAccVerifiedAccessEndpoint_tags (1011.99s)
=== CONT  TestAccVerifiedAccessEndpoint_policyUpdate
--- PASS: TestAccVerifiedAccessEndpoint_disappears (1396.51s)
=== CONT  TestAccVerifiedAccessEndpoint_policy
--- PASS: TestAccVerifiedAccessEndpoint_policyUpdate (1327.78s)
--- PASS: TestAccVerifiedAccessEndpoint_policy (1250.39s)
PASS
...

Note: Tests take long to run.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/L Managed by automation to categorize the size of a PR. labels Nov 10, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Nov 10, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 13, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 14, 2023
@sQu4rks sQu4rks marked this pull request as ready for review November 14, 2023 21:12
@ewbankkit ewbankkit self-assigned this Feb 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 2, 2024
@ewbankkit ewbankkit assigned ewbankkit and unassigned ewbankkit Feb 4, 2024
@ewbankkit
Copy link
Contributor

Superseded by #34264.

@ewbankkit ewbankkit closed this Feb 9, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants