Modify Kinesis Delivery Stream default Lambda buffer size hint to 1 MB. #35137

theherk · 2024-01-04T11:38:36Z

This is the correct value, though 3 MB may have been at some point in the past. This addresses the perpetual differences found in the state currently due to the default creation being 1 MB, and state default expecting 3 MB. References can be seen in #9827 and #19936. This also fixes #33014.

Relations

Closes Kinesis firehose delivery stream, default lambda transform params not stored in state #9827
Closes aws_kinesis_firehose_delivery_stream still doesn't save processors configuration properly #19936
Closes [Docs]: Default kinesis_firehose_delivery_stream parameter values have changed in AWS #33014
Closes r/aws_kinesis_firehose_delivery_stream - Send defaults for BufferIntervalInSeconds and BufferSizeInMBs #26964
Closes [Enhancement]: Kinesis Data Firehose adds support for document ID that is auto-generated by Amazon OpenSearch Service #32064

References

Correct value source of truth can be found here: https://docs.aws.amazon.com/firehose/latest/dev/data-transformation.html.

Output from Acceptance Testing

~~Failing at the moment, due to I believe the fact that people were setting this value to 1 MB statically, but this isn't stored in the state since it is the actual default value.~~

Tests are now passing. See below.

…rvalInSeconds and BufferSizeInMBs Send default processor parameter values to remove requirement to set both 'BufferSizeInMBs' and 'BufferIntervalInSeconds' even if one is using the default value.

This is the correct value, though 3 MB may have been at some point in the past. This addresses the perpetual differences found in the state currently due to the default creation being 1 MB, and state default expecting 3 MB. References can be seen in hashicorp#9827 and hashicorp#19936. This also fixes hashicorp#33014.

github-actions · 2024-01-04T11:38:55Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…fault values. There was some disagreement about if the default was 3 MB as this resource previously (incorrectly) assumed or 1 MB as is correct. This updates the fixtures to use neither value.

theherk · 2024-01-04T12:37:26Z

Tests are now passing.

Output from Acceptance Testing

% make testacc TESTS=TestAccFirehoseDeliveryStream PKG=firehose

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20 -run='TestAccFirehoseDeliveryStream'  -timeout 360m
=== RUN   TestAccFirehoseDeliveryStreamDataSource_basic
=== PAUSE TestAccFirehoseDeliveryStreamDataSource_basic
=== RUN   TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== RUN   TestAccFirehoseDeliveryStream_disappears
=== PAUSE TestAccFirehoseDeliveryStream_disappears
=== RUN   TestAccFirehoseDeliveryStream_tags
=== PAUSE TestAccFirehoseDeliveryStream_tags
=== RUN   TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging
=== PAUSE TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging
=== RUN   TestAccFirehoseDeliveryStream_extendedS3basic
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3basic
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty
=== RUN   TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
=== RUN   TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
=== RUN   TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
=== RUN   TestAccFirehoseDeliveryStream_extendedS3Updates
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3Updates
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource
=== RUN   TestAccFirehoseDeliveryStream_redshiftUpdates
=== PAUSE TestAccFirehoseDeliveryStream_redshiftUpdates
=== RUN   TestAccFirehoseDeliveryStream_splunkUpdates
=== PAUSE TestAccFirehoseDeliveryStream_splunkUpdates
=== RUN   TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_httpEndpoint
=== PAUSE TestAccFirehoseDeliveryStream_httpEndpoint
=== RUN   TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration
=== PAUSE TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration
=== RUN   TestAccFirehoseDeliveryStream_elasticSearchUpdates
=== PAUSE TestAccFirehoseDeliveryStream_elasticSearchUpdates
=== RUN   TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates
=== PAUSE TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates
=== RUN   TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates
=== PAUSE TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates
=== RUN   TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_openSearchUpdates
=== PAUSE TestAccFirehoseDeliveryStream_openSearchUpdates
=== RUN   TestAccFirehoseDeliveryStream_openSearchEndpointUpdates
=== PAUSE TestAccFirehoseDeliveryStream_openSearchEndpointUpdates
=== RUN   TestAccFirehoseDeliveryStream_openSearchWithVPCUpdates
=== PAUSE TestAccFirehoseDeliveryStream_openSearchWithVPCUpdates
=== RUN   TestAccFirehoseDeliveryStream_Opensearch_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_Opensearch_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_openSearchServerlessUpdates
=== PAUSE TestAccFirehoseDeliveryStream_openSearchServerlessUpdates
=== RUN   TestAccFirehoseDeliveryStream_missingProcessing
=== PAUSE TestAccFirehoseDeliveryStream_missingProcessing
=== CONT  TestAccFirehoseDeliveryStreamDataSource_basic
=== CONT  TestAccFirehoseDeliveryStream_extendedS3Updates
=== CONT  TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates
=== CONT  TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
=== CONT  TestAccFirehoseDeliveryStream_openSearchWithVPCUpdates
=== CONT  TestAccFirehoseDeliveryStream_missingProcessing
=== CONT  TestAccFirehoseDeliveryStream_openSearchServerlessUpdates
=== CONT  TestAccFirehoseDeliveryStream_Opensearch_ErrorOutputPrefix
=== CONT  TestAccFirehoseDeliveryStream_redshiftUpdates
=== CONT  TestAccFirehoseDeliveryStream_splunkUpdates
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource
=== CONT  TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration
=== CONT  TestAccFirehoseDeliveryStream_elasticSearchUpdates
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource
=== CONT  TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix
=== CONT  TestAccFirehoseDeliveryStream_httpEndpoint
=== CONT  TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix
=== CONT  TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates
=== CONT  TestAccFirehoseDeliveryStream_openSearchEndpointUpdates
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty
=== NAME  TestAccFirehoseDeliveryStream_Opensearch_ErrorOutputPrefix
    acctest.go:1099: skipping tests; missing IAM service-linked role /aws-service-role/opensearchservice. Please create the role and retry
--- SKIP: TestAccFirehoseDeliveryStream_Opensearch_ErrorOutputPrefix (1.45s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
=== NAME  TestAccFirehoseDeliveryStream_openSearchWithVPCUpdates
    acctest.go:1099: skipping tests; missing IAM service-linked role /aws-service-role/opensearchservice. Please create the role and retry
--- SKIP: TestAccFirehoseDeliveryStream_openSearchWithVPCUpdates (1.45s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
=== NAME  TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates
    acctest.go:1099: skipping tests; missing IAM service-linked role /aws-service-role/es. Please create the role and retry
--- SKIP: TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates (1.55s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
=== NAME  TestAccFirehoseDeliveryStream_elasticSearchUpdates
    acctest.go:1099: skipping tests; missing IAM service-linked role /aws-service-role/es. Please create the role and retry
--- SKIP: TestAccFirehoseDeliveryStream_elasticSearchUpdates (1.58s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty
=== NAME  TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix
    acctest.go:1099: skipping tests; missing IAM service-linked role /aws-service-role/es. Please create the role and retry
--- SKIP: TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix (1.59s)
=== CONT  TestAccFirehoseDeliveryStream_openSearchUpdates
=== NAME  TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates
    acctest.go:1099: skipping tests; missing IAM service-linked role /aws-service-role/es. Please create the role and retry
--- SKIP: TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates (1.59s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3basic
=== NAME  TestAccFirehoseDeliveryStream_openSearchEndpointUpdates
    acctest.go:1099: skipping tests; missing IAM service-linked role /aws-service-role/opensearchservice. Please create the role and retry
--- SKIP: TestAccFirehoseDeliveryStream_openSearchEndpointUpdates (1.60s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty
=== NAME  TestAccFirehoseDeliveryStream_openSearchUpdates
    acctest.go:1099: skipping tests; missing IAM service-linked role /aws-service-role/opensearchservice. Please create the role and retry
--- SKIP: TestAccFirehoseDeliveryStream_openSearchUpdates (0.18s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource (95.11s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration (115.33s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled
--- PASS: TestAccFirehoseDeliveryStream_missingProcessing (119.94s)
=== CONT  TestAccFirehoseDeliveryStream_tags
=== CONT  TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update (142.03s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty (143.92s)
=== CONT  TestAccFirehoseDeliveryStream_disappears
--- PASS: TestAccFirehoseDeliveryStreamDataSource_basic (143.97s)
=== CONT  TestAccFirehoseDeliveryStream_basic
--- PASS: TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN (143.93s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty (146.01s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty (149.16s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning (159.24s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_splunkUpdates (176.10s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix (179.53s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3basic (178.41s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3Updates (181.58s)
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix (185.77s)
--- PASS: TestAccFirehoseDeliveryStream_httpEndpoint (220.04s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate (241.67s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate (149.51s)
--- PASS: TestAccFirehoseDeliveryStream_tags (125.15s)
--- PASS: TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging (104.37s)
--- PASS: TestAccFirehoseDeliveryStream_disappears (116.86s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty (110.93s)
--- PASS: TestAccFirehoseDeliveryStream_basic (144.00s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty (138.05s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled (176.02s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update (158.49s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix (178.32s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix (155.69s)
--- PASS: TestAccFirehoseDeliveryStream_redshiftUpdates (334.73s)
--- PASS: TestAccFirehoseDeliveryStream_openSearchServerlessUpdates (488.66s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource (743.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/firehose   746.075s

This reverts commit 9374e69.

…fferIntervalInSeconds" This reverts commit 7f785a9.

…StreamConfig_extendedS3UpdatesSetBufferIntervalNoBufferSize' (hashicorp#26964).

…ters (hashicorp#26964).

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_extended\|TestAccFirehoseDeliveryStream_Extended\|TestAccFirehoseDeliveryStream_splunk\|TestAccFirehoseDeliveryStream_Splunk\|TestAccFirehoseDeliveryStream_redshift' PKG=firehose ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 3 -run=TestAccFirehoseDeliveryStream_extended\|TestAccFirehoseDeliveryStream_Extended\|TestAccFirehoseDeliveryStream_splunk\|TestAccFirehoseDeliveryStream_Splunk\|TestAccFirehoseDeliveryStream_redshift -timeout 360m === RUN TestAccFirehoseDeliveryStream_extendedS3basic === PAUSE TestAccFirehoseDeliveryStream_extendedS3basic === RUN TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled === RUN TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate === RUN TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update === RUN TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty === RUN TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty === RUN TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty === RUN TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty === RUN TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update === RUN TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix === RUN TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix === RUN TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty === RUN TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN === PAUSE TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN === RUN TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning === PAUSE TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning === RUN TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate === PAUSE TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate === RUN TestAccFirehoseDeliveryStream_extendedS3Updates === PAUSE TestAccFirehoseDeliveryStream_extendedS3Updates === RUN TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource === RUN TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource === PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource === RUN TestAccFirehoseDeliveryStream_redshiftUpdates === PAUSE TestAccFirehoseDeliveryStream_redshiftUpdates === RUN TestAccFirehoseDeliveryStream_splunkUpdates === PAUSE TestAccFirehoseDeliveryStream_splunkUpdates === RUN TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix === PAUSE TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix === CONT TestAccFirehoseDeliveryStream_extendedS3basic === CONT TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty === CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty --- PASS: TestAccFirehoseDeliveryStream_extendedS3basic (98.48s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty (121.61s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty (133.61s) === CONT TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource (87.89s) === CONT TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update (129.50s) === CONT TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix --- PASS: TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix (129.63s) === CONT TestAccFirehoseDeliveryStream_splunkUpdates --- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate (240.48s) === CONT TestAccFirehoseDeliveryStream_redshiftUpdates --- PASS: TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN (164.79s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource --- PASS: TestAccFirehoseDeliveryStream_splunkUpdates (140.03s) === CONT TestAccFirehoseDeliveryStream_extendedS3Updates --- PASS: TestAccFirehoseDeliveryStream_extendedS3Updates (143.49s) === CONT TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning --- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning (115.03s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate (120.64s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource (623.22s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled (138.72s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix (147.81s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix (199.13s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update (178.95s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty (165.28s) === CONT TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty --- PASS: TestAccFirehoseDeliveryStream_redshiftUpdates (1061.70s) --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty (94.14s) --- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty (124.30s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/firehose 1472.874s

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_extendedS3Updates\|TestAccFirehoseDeliveryStream_basic' PKG=firehose ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20 -run=TestAccFirehoseDeliveryStream_extendedS3Updates\|TestAccFirehoseDeliveryStream_basic -timeout 360m === RUN TestAccFirehoseDeliveryStream_basic === PAUSE TestAccFirehoseDeliveryStream_basic === RUN TestAccFirehoseDeliveryStream_extendedS3Updates === PAUSE TestAccFirehoseDeliveryStream_extendedS3Updates === CONT TestAccFirehoseDeliveryStream_basic === CONT TestAccFirehoseDeliveryStream_extendedS3Updates --- PASS: TestAccFirehoseDeliveryStream_basic (159.68s) --- PASS: TestAccFirehoseDeliveryStream_extendedS3Updates (176.43s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/firehose 182.295s

….document_id_options` configuration block.

…fering_interval` and `splunk_configuration.buffering_size` arguments.

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_splunkUpdates\|TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix' PKG=firehose ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20 -run=TestAccFirehoseDeliveryStream_splunkUpdates\|TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix -timeout 360m === RUN TestAccFirehoseDeliveryStream_splunkUpdates === PAUSE TestAccFirehoseDeliveryStream_splunkUpdates === RUN TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix === PAUSE TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix === CONT TestAccFirehoseDeliveryStream_splunkUpdates === CONT TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix --- PASS: TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix (177.22s) --- PASS: TestAccFirehoseDeliveryStream_splunkUpdates (180.60s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/firehose 186.438s

github-actions · 2024-01-05T17:06:22Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

ewbankkit

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_\|TestAccFirehoseDeliveryStreamDataSource_' PKG=firehose ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 3  -run=TestAccFirehoseDeliveryStream_\|TestAccFirehoseDeliveryStreamDataSource_ -timeout 720m
=== RUN   TestAccFirehoseDeliveryStreamDataSource_basic
=== PAUSE TestAccFirehoseDeliveryStreamDataSource_basic
=== RUN   TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== RUN   TestAccFirehoseDeliveryStream_disappears
=== PAUSE TestAccFirehoseDeliveryStream_disappears
=== RUN   TestAccFirehoseDeliveryStream_tags
=== PAUSE TestAccFirehoseDeliveryStream_tags
=== RUN   TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging
=== PAUSE TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging
=== RUN   TestAccFirehoseDeliveryStream_extendedS3basic
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3basic
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty
=== RUN   TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
=== RUN   TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
=== RUN   TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
=== RUN   TestAccFirehoseDeliveryStream_extendedS3Updates
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3Updates
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource
=== RUN   TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource
=== PAUSE TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource
=== RUN   TestAccFirehoseDeliveryStream_redshiftUpdates
=== PAUSE TestAccFirehoseDeliveryStream_redshiftUpdates
=== RUN   TestAccFirehoseDeliveryStream_splunkUpdates
=== PAUSE TestAccFirehoseDeliveryStream_splunkUpdates
=== RUN   TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_httpEndpoint
=== PAUSE TestAccFirehoseDeliveryStream_httpEndpoint
=== RUN   TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration
=== PAUSE TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration
=== RUN   TestAccFirehoseDeliveryStream_elasticSearchUpdates
=== PAUSE TestAccFirehoseDeliveryStream_elasticSearchUpdates
=== RUN   TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates
=== PAUSE TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates
=== RUN   TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates
=== PAUSE TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates
=== RUN   TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_openSearchUpdates
=== PAUSE TestAccFirehoseDeliveryStream_openSearchUpdates
=== RUN   TestAccFirehoseDeliveryStream_openSearchEndpointUpdates
=== PAUSE TestAccFirehoseDeliveryStream_openSearchEndpointUpdates
=== RUN   TestAccFirehoseDeliveryStream_openSearchWithVPCUpdates
=== PAUSE TestAccFirehoseDeliveryStream_openSearchWithVPCUpdates
=== RUN   TestAccFirehoseDeliveryStream_Opensearch_ErrorOutputPrefix
=== PAUSE TestAccFirehoseDeliveryStream_Opensearch_ErrorOutputPrefix
=== RUN   TestAccFirehoseDeliveryStream_openSearchServerlessUpdates
=== PAUSE TestAccFirehoseDeliveryStream_openSearchServerlessUpdates
=== RUN   TestAccFirehoseDeliveryStream_missingProcessing
=== PAUSE TestAccFirehoseDeliveryStream_missingProcessing
=== CONT  TestAccFirehoseDeliveryStreamDataSource_basic
=== CONT  TestAccFirehoseDeliveryStream_extendedS3Updates
=== CONT  TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates
--- PASS: TestAccFirehoseDeliveryStreamDataSource_basic (148.74s)
=== CONT  TestAccFirehoseDeliveryStream_missingProcessing
=== CONT  TestAccFirehoseDeliveryStream_openSearchServerlessUpdates
--- PASS: TestAccFirehoseDeliveryStream_extendedS3Updates (174.21s)
--- PASS: TestAccFirehoseDeliveryStream_missingProcessing (76.66s)
=== CONT  TestAccFirehoseDeliveryStream_Opensearch_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_openSearchServerlessUpdates (605.67s)
=== CONT  TestAccFirehoseDeliveryStream_openSearchWithVPCUpdates
--- PASS: TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates (1573.78s)
=== CONT  TestAccFirehoseDeliveryStream_openSearchEndpointUpdates
--- PASS: TestAccFirehoseDeliveryStream_Opensearch_ErrorOutputPrefix (1976.35s)
=== CONT  TestAccFirehoseDeliveryStream_openSearchUpdates
--- PASS: TestAccFirehoseDeliveryStream_openSearchEndpointUpdates (1935.58s)
=== CONT  TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_openSearchWithVPCUpdates (2928.17s)
=== CONT  TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates
--- PASS: TestAccFirehoseDeliveryStream_openSearchUpdates (1813.05s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix (161.76s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
--- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate (261.16s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty (102.30s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix (121.52s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update (137.90s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty (120.62s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty (102.92s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3basic
--- PASS: TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix (1592.05s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty
--- PASS: TestAccFirehoseDeliveryStream_extendedS3basic (95.36s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty (125.75s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update (122.02s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate (103.29s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled (132.80s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
--- PASS: TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN (97.58s)
=== CONT  TestAccFirehoseDeliveryStream_tags
--- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning (105.41s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty
--- PASS: TestAccFirehoseDeliveryStream_tags (149.90s)
=== CONT  TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty (130.79s)
=== CONT  TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging
--- PASS: TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging (65.69s)
=== CONT  TestAccFirehoseDeliveryStream_elasticSearchUpdates
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration (116.41s)
=== CONT  TestAccFirehoseDeliveryStream_disappears
--- PASS: TestAccFirehoseDeliveryStream_disappears (102.89s)
=== CONT  TestAccFirehoseDeliveryStream_redshiftUpdates
--- PASS: TestAccFirehoseDeliveryStream_redshiftUpdates (320.37s)
=== CONT  TestAccFirehoseDeliveryStream_splunkUpdates
--- PASS: TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates (2452.01s)
=== CONT  TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_splunkUpdates (139.17s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix (154.65s)
=== CONT  TestAccFirehoseDeliveryStream_httpEndpoint
--- PASS: TestAccFirehoseDeliveryStream_httpEndpoint (107.08s)
=== CONT  TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource (65.09s)
=== CONT  TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix
--- PASS: TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix (141.63s)
=== CONT  TestAccFirehoseDeliveryStream_basic
--- PASS: TestAccFirehoseDeliveryStream_basic (101.29s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_mskClusterSource (536.78s)
--- PASS: TestAccFirehoseDeliveryStream_elasticSearchUpdates (1535.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	7216.331s

# Conflicts: # go.mod # go.sum

ewbankkit · 2024-01-05T19:58:12Z

@theherk @mtt88 Thanks for the contribution 🎉 👏.

github-actions · 2024-01-12T12:42:39Z

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-03-12T02:02:47Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

mtt88 and others added 3 commits September 23, 2022 21:00

r/aws_kinesis_firehose_delivery_stream - Send defaults for BufferInte…

7f785a9

…rvalInSeconds and BufferSizeInMBs Send default processor parameter values to remove requirement to set both 'BufferSizeInMBs' and 'BufferIntervalInSeconds' even if one is using the default value.

Add changelog

9374e69

github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/firehose Issues and PRs that pertain to the firehose service. labels Jan 4, 2024

terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 4, 2024

theherk added 2 commits January 4, 2024 13:31

Update test fixtures for Kinesis Data Streams to non-ambiguous non-de…

0e9caea

…fault values. There was some disagreement about if the default was 3 MB as this resource previously (incorrectly) assumed or 1 MB as is correct. This updates the fixtures to use neither value.

Add changelog entry for Kinesis Data Streams default bug fix.

e0dad94

theherk changed the title ~~[WIP]: Modify Kinesis Delivery Stream default Lambda buffer size hint to 1 MB.~~ Modify Kinesis Delivery Stream default Lambda buffer size hint to 1 MB. Jan 4, 2024

github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 4, 2024

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 4, 2024

ewbankkit added 6 commits January 4, 2024 10:54

Revert "Add changelog"

1498e6d

This reverts commit 9374e69.

Revert "r/aws_kinesis_firehose_delivery_stream - Send defaults for Bu…

5580d05

…fferIntervalInSeconds" This reverts commit 7f785a9.

Merge commit '5580d0583dc85e78f033b9609361e4508b3cb41b' into HEAD

93783b9

Tweak CHANGELOG entry.

8154d8e

TestAccFirehoseDeliveryStream_extendedS3Updates: Add 'testAccDelivery…

7a55176

…StreamConfig_extendedS3UpdatesSetBufferIntervalNoBufferSize' (hashicorp#26964).

r/aws_kinesis_firehose_delivery_stream: Send default processor parame…

4b5dcbd

…ters (hashicorp#26964).

ewbankkit self-assigned this Jan 4, 2024

terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 4, 2024

Add CHANGELOG entry.

83adbe2

ewbankkit added the bug Addresses a defect in current functionality. label Jan 4, 2024

ewbankkit mentioned this pull request Jan 4, 2024

r/aws_kinesis_firehose_delivery_stream - Send defaults for BufferIntervalInSeconds and BufferSizeInMBs #26964

Merged

ewbankkit added 3 commits January 4, 2024 14:19

Use AWS SDK for Go v2 for firehose service.

ab4b0ab

Run 'make gen'.

33b2268

ewbankkit added 9 commits January 5, 2024 09:00

r/aws_kinesis_firehose_delivery_stream: Migrate to AWS SDK for Go v2.

43f1eba

firehose: Migrate sweepers to AWS SDK for Go v2.

7348d2b

firehose: Migrate acceptance tests to AWS SDK for Go v2.

104120a

'ResourceDeliveryStream' -> 'resourceDeliveryStream'.

e386e5f

r/aws_kinesis_firehose_delivery_stream: Add `opensearch_configuration…

981ead2

….document_id_options` configuration block.

r/aws_kinesis_firehose_delivery_stream: Support zero buffering.

1875d4e

r/aws_kinesis_firehose_delivery_stream: Add `splunk_configuration.buf…

2ddcbd2

…fering_interval` and `splunk_configuration.buffering_size` arguments.

ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 5, 2024

ewbankkit approved these changes Jan 5, 2024

View reviewed changes

ewbankkit added 3 commits January 5, 2024 14:15

Merge branch 'main' into HEAD

47bfaed

# Conflicts: # go.mod # go.sum

r/aws_kinesis_firehose_delivery_stream: Fixup documentation.

29ec256

Fix golangci-lint 'unconvert'.

3fcfeaa

ewbankkit merged commit bc1b769 into hashicorp:main Jan 5, 2024
50 checks passed

github-actions bot added this to the v5.32.0 milestone Jan 5, 2024

github-actions bot removed the bug Addresses a defect in current functionality. label Jan 12, 2024

plain5 mentioned this pull request Jan 12, 2024

[Enhancement] : Provide support for the opensearch_configuration object. fdmsantos/terraform-aws-kinesis-firehose#8

Closed

justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify Kinesis Delivery Stream default Lambda buffer size hint to 1 MB. #35137

Modify Kinesis Delivery Stream default Lambda buffer size hint to 1 MB. #35137

theherk commented Jan 4, 2024 •

edited by ewbankkit

Loading

github-actions bot commented Jan 4, 2024

theherk commented Jan 4, 2024 •

edited

Loading

github-actions bot commented Jan 5, 2024

ewbankkit left a comment

ewbankkit commented Jan 5, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Mar 12, 2024

Modify Kinesis Delivery Stream default Lambda buffer size hint to 1 MB. #35137

Modify Kinesis Delivery Stream default Lambda buffer size hint to 1 MB. #35137

Conversation

theherk commented Jan 4, 2024 • edited by ewbankkit Loading

Relations

References

Output from Acceptance Testing

github-actions bot commented Jan 4, 2024

Community Note

theherk commented Jan 4, 2024 • edited Loading

github-actions bot commented Jan 5, 2024

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Jan 5, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Mar 12, 2024

theherk commented Jan 4, 2024 •

edited by ewbankkit

Loading

theherk commented Jan 4, 2024 •

edited

Loading