Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediaconvert: Use standard Regional endpoints, not per-account endpoints #35615

Merged
merged 18 commits into from
Feb 2, 2024

Conversation

ewbankkit
Copy link
Contributor

Description

Also migrates to AWS SDK for Go v2.

Relations

Closes #35608.
Relates #32976.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccMediaConvert' PKG=mediaconvert ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mediaconvert/... -v -count 1 -parallel 2  -run=TestAccMediaConvert -timeout 360m
=== RUN   TestAccMediaConvertQueueDataSource_basic
=== PAUSE TestAccMediaConvertQueueDataSource_basic
=== RUN   TestAccMediaConvertQueue_basic
=== PAUSE TestAccMediaConvertQueue_basic
=== RUN   TestAccMediaConvertQueue_disappears
=== PAUSE TestAccMediaConvertQueue_disappears
=== RUN   TestAccMediaConvertQueue_withTags
=== PAUSE TestAccMediaConvertQueue_withTags
=== RUN   TestAccMediaConvertQueue_reservationPlanSettings
    acctest.go:93: MediaConvert Reserved Queues are $400/month and cannot be deleted for 1 year.
--- SKIP: TestAccMediaConvertQueue_reservationPlanSettings (0.00s)
=== RUN   TestAccMediaConvertQueue_withStatus
=== PAUSE TestAccMediaConvertQueue_withStatus
=== RUN   TestAccMediaConvertQueue_withDescription
=== PAUSE TestAccMediaConvertQueue_withDescription
=== CONT  TestAccMediaConvertQueueDataSource_basic
=== CONT  TestAccMediaConvertQueue_withTags
--- PASS: TestAccMediaConvertQueueDataSource_basic (18.00s)
=== CONT  TestAccMediaConvertQueue_disappears
--- PASS: TestAccMediaConvertQueue_disappears (21.01s)
=== CONT  TestAccMediaConvertQueue_basic
--- PASS: TestAccMediaConvertQueue_withTags (51.68s)
=== CONT  TestAccMediaConvertQueue_withDescription
--- PASS: TestAccMediaConvertQueue_basic (22.74s)
=== CONT  TestAccMediaConvertQueue_withStatus
--- PASS: TestAccMediaConvertQueue_withDescription (30.87s)
--- PASS: TestAccMediaConvertQueue_withStatus (31.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert	104.885s

% make testacc TESTARGS='-run=TestAccMediaConvert' PKG=mediaconvert ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mediaconvert/... -v -count 1 -parallel 2  -run=TestAccMediaConvert -timeout 360m
=== RUN   TestAccMediaConvertQueueDataSource_basic
=== PAUSE TestAccMediaConvertQueueDataSource_basic
=== RUN   TestAccMediaConvertQueue_basic
=== PAUSE TestAccMediaConvertQueue_basic
=== RUN   TestAccMediaConvertQueue_disappears
=== PAUSE TestAccMediaConvertQueue_disappears
=== RUN   TestAccMediaConvertQueue_withTags
=== PAUSE TestAccMediaConvertQueue_withTags
=== RUN   TestAccMediaConvertQueue_reservationPlanSettings
    acctest.go:93: MediaConvert Reserved Queues are $400/month and cannot be deleted for 1 year.
--- SKIP: TestAccMediaConvertQueue_reservationPlanSettings (0.00s)
=== RUN   TestAccMediaConvertQueue_withStatus
=== PAUSE TestAccMediaConvertQueue_withStatus
=== RUN   TestAccMediaConvertQueue_withDescription
=== PAUSE TestAccMediaConvertQueue_withDescription
=== CONT  TestAccMediaConvertQueueDataSource_basic
=== CONT  TestAccMediaConvertQueue_withTags
--- PASS: TestAccMediaConvertQueueDataSource_basic (42.69s)
=== CONT  TestAccMediaConvertQueue_withDescription
--- PASS: TestAccMediaConvertQueue_withTags (118.81s)
=== CONT  TestAccMediaConvertQueue_disappears
--- PASS: TestAccMediaConvertQueue_withDescription (78.13s)
=== CONT  TestAccMediaConvertQueue_basic
--- PASS: TestAccMediaConvertQueue_disappears (65.92s)
=== CONT  TestAccMediaConvertQueue_withStatus
--- PASS: TestAccMediaConvertQueue_basic (80.26s)
--- PASS: TestAccMediaConvertQueue_withStatus (52.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert	247.966s
% make testacc TESTARGS='-run=TestAccMediaConvert' PKG=mediaconvert ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mediaconvert/... -v -count 1 -parallel 2  -run=TestAccMediaConvert -timeout 360m
=== RUN   TestAccMediaConvertQueueDataSource_basic
=== PAUSE TestAccMediaConvertQueueDataSource_basic
=== RUN   TestAccMediaConvertQueue_basic
=== PAUSE TestAccMediaConvertQueue_basic
=== RUN   TestAccMediaConvertQueue_disappears
=== PAUSE TestAccMediaConvertQueue_disappears
=== RUN   TestAccMediaConvertQueue_withTags
=== PAUSE TestAccMediaConvertQueue_withTags
=== RUN   TestAccMediaConvertQueue_reservationPlanSettings
    acctest.go:93: MediaConvert Reserved Queues are $400/month and cannot be deleted for 1 year.
--- SKIP: TestAccMediaConvertQueue_reservationPlanSettings (0.00s)
=== RUN   TestAccMediaConvertQueue_withStatus
=== PAUSE TestAccMediaConvertQueue_withStatus
=== RUN   TestAccMediaConvertQueue_withDescription
=== PAUSE TestAccMediaConvertQueue_withDescription
=== CONT  TestAccMediaConvertQueueDataSource_basic
=== CONT  TestAccMediaConvertQueue_withTags
--- PASS: TestAccMediaConvertQueueDataSource_basic (17.37s)
=== CONT  TestAccMediaConvertQueue_withDescription
--- PASS: TestAccMediaConvertQueue_withTags (44.88s)
=== CONT  TestAccMediaConvertQueue_disappears
--- PASS: TestAccMediaConvertQueue_withDescription (27.56s)
=== CONT  TestAccMediaConvertQueue_basic
--- PASS: TestAccMediaConvertQueue_disappears (16.32s)
=== CONT  TestAccMediaConvertQueue_withStatus
--- PASS: TestAccMediaConvertQueue_basic (19.36s)
--- PASS: TestAccMediaConvertQueue_withStatus (28.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert	99.890s
Copy link

github-actions bot commented Feb 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Feb 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 2, 2024
@ewbankkit ewbankkit merged commit 3a190e6 into main Feb 2, 2024
44 checks passed
@ewbankkit ewbankkit deleted the td-mediaconvert.DescribeEndpointsInput-deprecated branch February 2, 2024 17:15
@github-actions github-actions bot added this to the v5.36.0 milestone Feb 2, 2024
github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
Copy link

github-actions bot commented Feb 8, 2024

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Elemental MediaConvert account-specific endpoints are no longer required
1 participant