Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key_value_store_associations #36228

Conversation

surajsubramanian
Copy link
Contributor

@surajsubramanian surajsubramanian commented Mar 6, 2024

Description

This PR introduces a new optional argument key_value_store_associations to the aws_cloudfront_function resource.

Relations

Closes #36048

References

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-function-functionconfig.html#cfn-cloudfront-function-functionconfig-keyvaluestoreassociations

Output from Acceptance Testing

> make testacc TESTS=TestAccCloudFrontFunction_KeyValueStoreAssociations PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontFunction_KeyValueStoreAssociations'  -timeout 360m
=== RUN   TestAccCloudFrontFunction_KeyValueStoreAssociations
=== PAUSE TestAccCloudFrontFunction_KeyValueStoreAssociations
=== CONT  TestAccCloudFrontFunction_KeyValueStoreAssociations
--- PASS: TestAccCloudFrontFunction_KeyValueStoreAssociations (42.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 46.502s
> make testacc TESTS=TestAccCloudFrontFunctionDataSource_basic PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontFunctionDataSource_basic'  -timeout 360m
=== RUN   TestAccCloudFrontFunctionDataSource_basic
=== PAUSE TestAccCloudFrontFunctionDataSource_basic
=== CONT  TestAccCloudFrontFunctionDataSource_basic
--- PASS: TestAccCloudFrontFunctionDataSource_basic (39.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 43.890s
> make testacc TESTS=TestAccCloudFrontFunction_basic PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontFunction_basic'  -timeout 360m
=== RUN   TestAccCloudFrontFunction_basic
=== PAUSE TestAccCloudFrontFunction_basic
=== CONT  TestAccCloudFrontFunction_basic
--- PASS: TestAccCloudFrontFunction_basic (24.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 28.102s

Copy link

github-actions bot commented Mar 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Mar 6, 2024
@surajsubramanian surajsubramanian changed the title [cloudfront/function] Add key_value_store_associations Add key_value_store_associations Mar 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 6, 2024
@surajsubramanian surajsubramanian force-pushed the f-aws_cloudfront_function-key_value_store_associations branch from 3623c33 to 7002110 Compare March 6, 2024 00:44
@surajsubramanian surajsubramanian force-pushed the f-aws_cloudfront_function-key_value_store_associations branch from 7002110 to 29c9c07 Compare March 6, 2024 00:46
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 7, 2024
@justinretzolk
Copy link
Member

Hey @surajsubramanian 👋 Thank you for taking the time to raise this! #35889 was mentioned in the issue that you linked in the PR description as one that would potentially be resolved by this addition. As I'm triaging this, I wanted to check with you on if you felt this PR would resolve that issue as well.

@justinretzolk justinretzolk added waiting-response Maintainers are waiting on response from community or contributor. needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2024
@surajsubramanian
Copy link
Contributor Author

surajsubramanian commented Mar 9, 2024

@justinretzolk Unfortunately I won't be able to provide any information on how the PR affects #35889 at the moment as I'm unable to write more acceptance tests closely tied with key_value_store.

Under internal/service/cloudfront, key_value_store is the only file where aws-sdk-go-v2 is used whilst the rest of cloudfront is yet to be migrated to v2.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 9, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 9, 2024
@guitarrapc
Copy link

Is there any stopping reason? We eager to use this functionality.

@surajsubramanian surajsubramanian deleted the f-aws_cloudfront_function-key_value_store_associations branch March 30, 2024 21:41
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Allow association of aws_cloudfront_function and aws_cloudfront_key_value_store
3 participants