Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve import docs for aws_bcmdataexports_export resource #37144

Merged
merged 1 commit into from May 1, 2024

Conversation

yob
Copy link
Contributor

@yob yob commented Apr 28, 2024

This resource was added in v5.47.0 and I took it for a test run. We have an existing v2.0 export that was manually created, and I wanted to import it into terraform management.

It wasn't clear from the docs what format the ID should be in, but by reading the provider source I could see it was the export ARN. I thought I'd mention that in the docs to help others.

Interestingly, finding the export ARN from the AWS web console wasn't easy. The URL was the only option I could find.

Relations

Relates: #36847

This resource was added in v5.47.0 and I took it for a test run. We have
an existing v2.0 export that was manually created, and I wanted to
import it into terraform management.

It wasn't clear from the docs what format the ID should be in, but by
reading the provider source I could see it was the export ARN. I thought
I'd mention that in the docs to help others.

Interestingly, finding the export ARN from the AWS web console wasn't
easy. The URL was the only option I could find.
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. size/XS Managed by automation to categorize the size of a PR. labels Apr 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 28, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @yob 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Apr 30, 2024
@johnsonaj johnsonaj self-assigned this May 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 1, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnsonaj johnsonaj merged commit a44832e into hashicorp:main May 1, 2024
68 checks passed
@github-actions github-actions bot added this to the v5.48.0 milestone May 1, 2024
@yob yob deleted the export-docs branch May 1, 2024 22:30
@johnsonaj
Copy link
Contributor

@yob thank you for your contribution! 🎉

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 2, 2024
Copy link

github-actions bot commented May 2, 2024

This functionality has been released in v5.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants