Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/37153: Add custom_image to code_editor_app_settings in Sagemaker user profile and domain #37155

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature/37153: Add custom_image to code_editor_app_settings in Sagemaker user profile and domain #37155

wants to merge 4 commits into from
+315 −4

Conversation

michaeljneely
Copy link

Description

AWS Sagemaker supports custom images for CodeEditor applications.

Custom images can be added via aws_sagemaker_user_profile.user_settings.code_editor_app_settings or aws_sagemaker_domain.default_user_settings.code_editor_app_settings

Relations

Closes #37153

References

  1. https://aws.amazon.com/about-aws/whats-new/2024/04/amazon-sagemaker-studio-code-editor-custom-images/
  2. https://docs.aws.amazon.com/sagemaker/latest/dg/code-editor-custom-images-provide-access.html

Output from Acceptance Testing

I've added tests but can't run them myself. I would be grateful if someone could confirm these tests pass successfully.

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Apr 29, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 29, 2024
github-actions[bot]
github-actions bot reviewed Apr 29, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @michaeljneely 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2024
DrFaust92
DrFaust92 approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deepakbshetty
deepakbshetty reviewed May 5, 2024
View reviewed changes
internal/service/sagemaker/domain.go
@@ -389,6 +389,27 @@ func ResourceDomain() *schema.Resource {
ValidateFunc: verify.ValidARN,
},
},
"custom_image": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michaeljneely , I am unable to see expandDomainCustomImages under expandDomainCodeEditorAppSettings(Create,Update) & flattenDomainCustomImages under flattenDomainCodeEditorAppSettings. (Read)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for catching this. Those missing elements have been added.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@deepakbshetty deepakbshetty deepakbshetty left review comments

@DrFaust92 DrFaust92 Awaiting requested review from DrFaust92

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: SageMaker Studio now supports custom images for Code Editor Applications
4 participants
@michaeljneely @DrFaust92 @deepakbshetty @justinretzolk