Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASG] fix: Fixed max_group_prepared_capacity to allow setting 0 #37174

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ponkio-o
Copy link
Contributor

Description

Hi, I fixed a bug in ASG warm poll settings where "Warm poll size" could not be set to 0.
The API allows "MaxGroupPreparedCapacity" to be set to 0. In fact, it can be set on the management console.
CleanShot 2024-04-30 at 17 11 17

Relations

Closes: #37173

References

https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_PutWarmPool.html#API_PutWarmPool_RequestParameters

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_warmPool' PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingGroup_warmPool -timeout 360m
=== RUN   TestAccAutoScalingGroup_warmPool
=== PAUSE TestAccAutoScalingGroup_warmPool
=== CONT  TestAccAutoScalingGroup_warmPool
--- PASS: TestAccAutoScalingGroup_warmPool (495.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        500.164s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Apr 30, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 30, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't set warm_pool.max_group_prepared_capacity of aws_autoscaling_group to 0
2 participants