awssdkpatch: enum type validation patch #37209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enhancement adds patches to migrate validation functions for enum types to the `enum.Validate` function. Due to a `gopatch` limitation, the field which the validation function is assigned to (`ValidateFunc`) cannot be migrated to the proper field (`ValidateDiagFunc`). The generated patches include a comment indicating that this step will need to be done manually once the patch is applied, at least until the underlying `gopatch` limitation is addressed. Related section in the AWS SDK migration guide: - https://hashicorp.github.io/terraform-provider-aws/aws-go-sdk-migrations/#validation-functions
jar-b
added
the
aws-sdk-go-migration
Community NoteVoting for Prioritization
For Submitters
|
jar-b
added
the
enhancement
github-actions
bot
added
the
size/S
terraform-aws-provider
bot
added
the
prioritized
jar-b
changed the title
mattburgess
reviewed
May 1, 2024
| # Step 4: Migrate enum validation | ||
| # | ||
| # This will only be partially correct. The enum.Validate function implements | ||
| # ValidateDiagFunc, while StringInSliace implements ValidateFunc. Due to |
There was a problem hiding this comment.
Suggested change
| # ValidateDiagFunc, while StringInSliace implements ValidateFunc. Due to | |
| # ValidateDiagFunc, while StringInSlice implements ValidateFunc. Due to |
There was a problem hiding this comment.
Thanks for catching these - too quick on the merge 🤦 . I just came across another patch to add and will fix as part of that PR.
mattburgess
reviewed
May 1, 2024
| # | ||
| # This will only be partially correct. The enum.Validate function implements | ||
| # ValidateDiagFunc, while StringInSliace implements ValidateFunc. Due to | ||
| # limitiations with how gopatch handles multiple matches within an elision, we |
There was a problem hiding this comment.
Suggested change
| # limitiations with how gopatch handles multiple matches within an elision, we | |
| # limitations with how gopatch handles multiple matches within an elision, we |
|
This functionality has been released in v5.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
github-actions
bot
removed
the
prioritized
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enhancement adds patches to migrate validation functions for enum types to the
enum.Validatefunction.Due to a
gopatchlimitation, the field which the validation function is assigned to (ValidateFunc) cannot be migrated to the proper field (ValidateDiagFunc). The generated patches include a comment indicating that this step will need to be done manually once the patch is applied, at least until the underlyinggopatchlimitation is addressed.Related section in the AWS SDK migration guide:
Relations
Relates #32976