Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlm: Migrate to AWS SDK v2 #37214

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

mattburgess
Copy link
Collaborator

Description

Relations

Closes #36140

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

github-actions bot commented May 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dlm Issues and PRs that pertain to the dlm service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels May 1, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 1, 2024
Copy link

github-actions bot commented May 1, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@mattburgess mattburgess added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label May 1, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 2, 2024
@johnsonaj johnsonaj self-assigned this May 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccDLM" PKG=dlm

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/dlm/... -v -count 1 -parallel 20  -run=TestAccDLM -timeout 360m
--- PASS: TestAccDLMLifecyclePolicy_disappears (23.63s)
--- PASS: TestAccDLMLifecyclePolicy_parameters_volume (25.45s)
--- PASS: TestAccDLMLifecyclePolicy_retainInterval (27.28s)
--- PASS: TestAccDLMLifecyclePolicy_cron (27.48s)
--- PASS: TestAccDLMLifecyclePolicy_shareRule (27.63s)
--- PASS: TestAccDLMLifecyclePolicy_basic (27.67s)
--- PASS: TestAccDLMLifecyclePolicy_fastRestore (27.79s)
--- PASS: TestAccDLMLifecyclePolicy_variableTags (27.87s)
--- PASS: TestAccDLMLifecyclePolicy_parameters_instance (27.89s)
--- PASS: TestAccDLMLifecyclePolicy_event (34.84s)
--- PASS: TestAccDLMLifecyclePolicy_full (35.43s)
--- PASS: TestAccDLMLifecyclePolicy_deprecate (37.52s)
--- PASS: TestAccDLMLifecyclePolicy_tags (42.18s)
--- PASS: TestAccDLMLifecyclePolicy_crossRegionCopyRule (62.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dlm 67.450s

@johnsonaj
Copy link
Contributor

@mattburgess thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit d7a8fd6 into hashicorp:main May 21, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.51.0 milestone May 21, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 24, 2024
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/dlm Issues and PRs that pertain to the dlm service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] DLM (Data Lifecycle Manager) Service
3 participants