r/aws_vpc_endpoint: Add support for user-defined IP addresses

[ddericco]

Description

Adds support for user-defined IP addressed on PrivateLink interface endpoints.

Notes:

• Amazon Athena is used to test IPv6 endpoints since EC2 does not support IPv6 on private endpoints today: https://docs.aws.amazon.com/vpc/latest/userguide/aws-ipv6-support.html
• Acceptance test TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup is currently failing, though this behavior predates the current PR (see CI: So many failing EC2 acceptance tests #35747).

Relations

Closes #34147

References

• What's New: https://aws.amazon.com/about-aws/whats-new/2023/08/aws-privatelink-user-defined-ip-vpc-endpoints/
• API reference: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVpcEndpoint.html

Output from Acceptance Testing

$ make testacc TESTS='TestAccVPCEndpoint_' PKG=ec2                                                                            ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpoint_'  -timeout 360m
=== RUN   TestAccVPCEndpoint_gatewayBasic
=== PAUSE TestAccVPCEndpoint_gatewayBasic
=== RUN   TestAccVPCEndpoint_interfaceBasic
=== PAUSE TestAccVPCEndpoint_interfaceBasic
=== RUN   TestAccVPCEndpoint_interfacePrivateDNS
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== RUN   TestAccVPCEndpoint_disappears
=== PAUSE TestAccVPCEndpoint_disappears
=== RUN   TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN   TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccVPCEndpoint_gatewayPolicy
=== PAUSE TestAccVPCEndpoint_gatewayPolicy
=== RUN   TestAccVPCEndpoint_ignoreEquivalent
=== PAUSE TestAccVPCEndpoint_ignoreEquivalent
=== RUN   TestAccVPCEndpoint_ipAddressType
=== PAUSE TestAccVPCEndpoint_ipAddressType
=== RUN   TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccVPCEndpoint_interfaceUserDefinedIPv4
=== PAUSE TestAccVPCEndpoint_interfaceUserDefinedIPv4
=== RUN   TestAccVPCEndpoint_interfaceUserDefinedIPv6
=== PAUSE TestAccVPCEndpoint_interfaceUserDefinedIPv6
=== RUN   TestAccVPCEndpoint_interfaceUserDefinedDualstack
=== PAUSE TestAccVPCEndpoint_interfaceUserDefinedDualstack
=== RUN   TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== PAUSE TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpoint_gatewayBasic
=== CONT  TestAccVPCEndpoint_ipAddressType
=== CONT  TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpoint_interfaceUserDefinedDualstack
=== CONT  TestAccVPCEndpoint_interfaceUserDefinedIPv6
=== CONT  TestAccVPCEndpoint_interfaceUserDefinedIPv4
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== CONT  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== CONT  TestAccVPCEndpoint_tags
=== CONT  TestAccVPCEndpoint_ignoreEquivalent
=== CONT  TestAccVPCEndpoint_gatewayPolicy
=== CONT  TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== CONT  TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== CONT  TestAccVPCEndpoint_disappears
=== CONT  TestAccVPCEndpoint_interfacePrivateDNS
=== CONT  TestAccVPCEndpoint_interfaceBasic
--- PASS: TestAccVPCEndpoint_disappears (143.89s)
--- PASS: TestAccVPCEndpoint_gatewayBasic (177.58s)
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (206.74s)
--- PASS: TestAccVPCEndpoint_gatewayPolicy (268.70s)
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (276.24s)
--- PASS: TestAccVPCEndpoint_interfaceBasic (294.32s)
--- PASS: TestAccVPCEndpoint_tags (305.60s)
=== NAME  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
    vpc_endpoint_test.go:439: Step 3/3 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        -       "network_interface_ids.#":           "1",
        +       "network_interface_ids.#":           "3",
        +       "network_interface_ids.1":           "eni-05125770040de7ddf",
        +       "network_interface_ids.2":           "eni-0d77f6a5403fe9404",
        -       "subnet_configurations.#":           "1",
        +       "subnet_configurations.#":           "3",
        -       "subnet_configurations.0.ipv4":      "10.0.56.7",
        +       "subnet_configurations.0.ipv4":      "10.0.100.247",
        -       "subnet_configurations.0.subnet_id": "subnet-0a106f8bbf441060c",
        +       "subnet_configurations.0.subnet_id": "subnet-0633fe7fe9b6b73b5",
        +       "subnet_configurations.1.%":         "3",
        +       "subnet_configurations.1.ipv4":      "10.0.142.22",
        +       "subnet_configurations.1.ipv6":      "",
        +       "subnet_configurations.1.subnet_id": "subnet-0932af53a9cbb46a1",
        +       "subnet_configurations.2.%":         "3",
        +       "subnet_configurations.2.ipv4":      "10.0.56.7",
        +       "subnet_configurations.2.ipv6":      "",
        +       "subnet_configurations.2.subnet_id": "subnet-0a106f8bbf441060c",
          }
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (413.80s)
--- PASS: TestAccVPCEndpoint_interfaceUserDefinedDualstack (420.40s)
--- PASS: TestAccVPCEndpoint_interfaceUserDefinedIPv6 (420.72s)
--- PASS: TestAccVPCEndpoint_interfaceUserDefinedIPv4 (431.61s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (459.53s)
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (483.80s)
--- FAIL: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (526.23s)
--- PASS: TestAccVPCEndpoint_ipAddressType (528.26s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (575.41s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (605.29s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ec2        613.889s
FAIL
make: *** [testacc] Error 1

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.