awssdkpatch: Fix aliased import substitutions #37239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
the
size/S
dlm imports its service package with an alias. The current patch template didn't cope with templated imports. gopatch [supports](https://github.com/uber-go/gopatch/blob/main/docs/PatchesInDepth.md#changing-any-import) changing both named and unnamed imports so this converts over to using that generic solution. On top of that, fix up the other patches so that they match aliased names rather than fully-qualified names.
terraform-aws-provider
bot
added
needs-triage
mattburgess
force-pushed
the
awssdkpatch-fix-aliased-imports
branch
from
1c47d19
to
bca429e
Compare
jar-b
added
aws-sdk-go-migration
jar-b
reviewed
May 3, 2024
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
github-actions
bot
added
size/XS
|
Thanks for your contribution, @mattburgess ! 👍 |
|
This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dmsimports its service package with an alias. The current patch template didn't cope with templated imports. gopatch supports changing both named and unnamed imports so this converts over to using that generic solution.On top of that, fix up the other patches so that they match aliased names rather than fully-qualified names.
Description
Relations
Relates #32976