Fix for default_tags and tags on EC2 block devices #37441
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`default_tags` support for EC2 root block devices was introduced in hasicorp/terraform-provider-aws#33769, which is great ... except it makes the mix of `default_tags` and `tags` on a `root_block_device` perpetually showing drift even when there is none. The solution is to not remove the default tags config from the volume tags in ec2_instance. This diff fixes hashicorp#36448 for us in our environment (which references hashicorp#33769 as the change that introduced this bug). This diff possibly fixes hashicorp#36706 too, but we weren't hitting this issue.
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XS
terraform-aws-provider
bot
added
the
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @0xkag 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
bug
|
Any interest in merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
default_tagssupport for EC2 root block devices was introduced in #33769, which is great ... except it makes the mix ofdefault_tagsandtagson aroot_block_deviceperpetually showing drift even when there is none.The solution is to not remove the default tags config from the volume tags in ec2_instance.
This diff fixes #36448 for us in our environment (which references #33769 as the change that introduced this bug).
This diff possibly fixes #36706 too, but we weren't hitting this issue.
Relations
Relates #33769
Relates #36706
Closes #36448
Output from Acceptance Testing