Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Prefer constants for test string literals #37688

Merged
merged 30 commits into from
May 24, 2024
Merged

ci: Prefer constants for test string literals #37688

merged 30 commits into from
May 24, 2024

Conversation

YakDriver
Copy link
Member

Description

This PR adds constants for test string literals and updates the code to use the constants instead.

Relations

Relates #37293

References

Output from Acceptance Testing

Handled through nightly builds.

@YakDriver
ci: Prefer constant for test string literals
5eae361
@YakDriver
acctest: Add constant for test string literals
a140372
@YakDriver
accessanalyzer: Use constants for test strings
0896e36
@YakDriver
acm: Use constants for test strings
406a10f
@YakDriver
acmpca: Use constants for test strings
799a582
@YakDriver
apprunner: Use constants for test strings
dfe38d8
@YakDriver
appsync: Use constants for test strings
be529ef
@YakDriver
batch: Use constants for test strings
b014f09
@YakDriver
comprehend: Use constants for test strings
b6e4a45
@YakDriver
ec2: Use constants for test strings
ed1d367
@YakDriver
iam: Use constants for test strings
ab2fc03
@YakDriver
licensemanager: Use constants for test strings
2115bf6
@YakDriver
lightsail: Use constants for test strings
c949399
@YakDriver
s3: Use constants for test strings
40e7859
@YakDriver
servicecatalog: Use constants for test strings
7afa75a
@YakDriver
ssmcontacts: Use constants for test strings
216df77
@YakDriver
xray: Use constants for test strings
d48785f
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. service/s3 Issues and PRs that pertain to the s3 service. service/lightsail Issues and PRs that pertain to the lightsail service. service/acm Issues and PRs that pertain to the acm service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/appsync Issues and PRs that pertain to the appsync service. service/batch Issues and PRs that pertain to the batch service. service/acmpca Issues and PRs that pertain to the acmpca service. service/xray Issues and PRs that pertain to the xray service. service/licensemanager Issues and PRs that pertain to the licensemanager service. labels May 24, 2024
@github-actions github-actions bot added service/comprehend Issues and PRs that pertain to the comprehend service. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. linter Pertains to changes to or issues with the various linters. service/apprunner Issues and PRs that pertain to the apprunner service. generators Relates to code generators. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. service/vpc Issues and PRs that pertain to the vpc service. labels May 24, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 24, 2024
@YakDriver YakDriver merged commit f9378aa into main May 24, 2024
38 checks passed
@YakDriver YakDriver deleted the t-acctest-literal-overlapkey1-resourcekey1-string-constant branch May 24, 2024 17:26
@github-actions github-actions bot added this to the v5.52.0 milestone May 24, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 30, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. linter Pertains to changes to or issues with the various linters. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/apprunner Issues and PRs that pertain to the apprunner service. service/appsync Issues and PRs that pertain to the appsync service. service/batch Issues and PRs that pertain to the batch service. service/comprehend Issues and PRs that pertain to the comprehend service. service/iam Issues and PRs that pertain to the iam service. service/licensemanager Issues and PRs that pertain to the licensemanager service. service/lightsail Issues and PRs that pertain to the lightsail service. service/s3 Issues and PRs that pertain to the s3 service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. service/vpc Issues and PRs that pertain to the vpc service. service/xray Issues and PRs that pertain to the xray service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.52.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@YakDriver