Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add link to s3 access point naming convention #37707

Merged
merged 2 commits into from
May 28, 2024

Conversation

stefanfreitag
Copy link

Description

Add information about the naming convention to the required argument name.

Relations

Closes #37656

References

  • Link to the naming convention for S3 access points.

Output from Acceptance Testing

Not applicable

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3control Issues and PRs that pertain to the s3control service. and removed size/XS Managed by automation to categorize the size of a PR. labels May 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 25, 2024
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for taking the time to help clarify the documentation! I pushed a slight phrasing change more in line with our phrasing elsewhere in the documentation, and will get this merged once the checks finish up 🚀

@justinretzolk justinretzolk merged commit 85dad03 into hashicorp:main May 28, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v5.52.0 milestone May 28, 2024
@terraform-aws-provider terraform-aws-provider bot removed the needs-triage Waiting for first response or review from a maintainer. label May 28, 2024
Copy link

This functionality has been released in v5.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@stefanfreitag stefanfreitag deleted the d-aws_s3_access_point branch June 24, 2024 19:53
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/s3control Issues and PRs that pertain to the s3control service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: add more details for name on resource: aws_s3_access_point
3 participants