Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EngineLifecycleSupport #37708

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented May 25, 2024

Description

Relations

Closes #37619

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSGlobalCluster_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSGlobalCluster_'  -timeout 360m
=== RUN   TestAccRDSGlobalCluster_basic
=== PAUSE TestAccRDSGlobalCluster_basic
=== RUN   TestAccRDSGlobalCluster_disappears
=== PAUSE TestAccRDSGlobalCluster_disappears
=== RUN   TestAccRDSGlobalCluster_databaseName
=== PAUSE TestAccRDSGlobalCluster_databaseName
=== RUN   TestAccRDSGlobalCluster_deletionProtection
=== PAUSE TestAccRDSGlobalCluster_deletionProtection
=== RUN   TestAccRDSGlobalCluster_engineLifecycleSupport_disabled
=== PAUSE TestAccRDSGlobalCluster_engineLifecycleSupport_disabled
=== RUN   TestAccRDSGlobalCluster_EngineVersion_updateMinor
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_updateMinor
=== RUN   TestAccRDSGlobalCluster_EngineVersion_updateMajor
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_updateMajor
=== RUN   TestAccRDSGlobalCluster_EngineVersion_updateMinorMultiRegion
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_updateMinorMultiRegion
=== RUN   TestAccRDSGlobalCluster_EngineVersion_updateMajorMultiRegion
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_updateMajorMultiRegion
=== RUN   TestAccRDSGlobalCluster_EngineVersion_auroraMySQL
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_auroraMySQL
=== RUN   TestAccRDSGlobalCluster_EngineVersion_auroraPostgreSQL
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_auroraPostgreSQL
=== RUN   TestAccRDSGlobalCluster_forceDestroy
=== PAUSE TestAccRDSGlobalCluster_forceDestroy
=== RUN   TestAccRDSGlobalCluster_sourceDBClusterIdentifier
=== PAUSE TestAccRDSGlobalCluster_sourceDBClusterIdentifier
=== RUN   TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== PAUSE TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== RUN   TestAccRDSGlobalCluster_storageEncrypted
=== PAUSE TestAccRDSGlobalCluster_storageEncrypted
=== CONT  TestAccRDSGlobalCluster_basic
=== CONT  TestAccRDSGlobalCluster_EngineVersion_updateMajorMultiRegion
=== CONT  TestAccRDSGlobalCluster_storageEncrypted
=== CONT  TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== CONT  TestAccRDSGlobalCluster_sourceDBClusterIdentifier
=== CONT  TestAccRDSGlobalCluster_forceDestroy
=== CONT  TestAccRDSGlobalCluster_EngineVersion_auroraPostgreSQL
=== CONT  TestAccRDSGlobalCluster_EngineVersion_auroraMySQL
=== CONT  TestAccRDSGlobalCluster_engineLifecycleSupport_disabled
=== CONT  TestAccRDSGlobalCluster_EngineVersion_updateMinorMultiRegion
=== CONT  TestAccRDSGlobalCluster_EngineVersion_updateMajor
=== CONT  TestAccRDSGlobalCluster_EngineVersion_updateMinor
=== CONT  TestAccRDSGlobalCluster_databaseName
=== CONT  TestAccRDSGlobalCluster_deletionProtection
=== CONT  TestAccRDSGlobalCluster_disappears
--- PASS: TestAccRDSGlobalCluster_forceDestroy (145.80s)
--- PASS: TestAccRDSGlobalCluster_disappears (150.91s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_auroraPostgreSQL (171.72s)
--- PASS: TestAccRDSGlobalCluster_basic (172.10s)
--- PASS: TestAccRDSGlobalCluster_engineLifecycleSupport_disabled (172.25s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_auroraMySQL (172.53s)
--- PASS: TestAccRDSGlobalCluster_storageEncrypted (218.21s)
--- PASS: TestAccRDSGlobalCluster_databaseName (218.34s)
--- PASS: TestAccRDSGlobalCluster_deletionProtection (233.55s)
--- PASS: TestAccRDSGlobalCluster_sourceDBClusterIdentifier (276.61s)
--- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (292.08s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMinor (1610.46s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMajor (2148.64s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMinorMultiRegion (3655.64s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMajorMultiRegion (3990.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	4010.250s

--- PASS: TestAccRDSCluster_localWriteForwarding (196.45s)
--- PASS: TestAccRDSCluster_deletionProtection (236.16s)
--- PASS: TestAccRDSCluster_basic (239.12s)
--- PASS: TestAccRDSCluster_enableHTTPEndpointProvisioned (244.39s)
--- PASS: TestAccRDSCluster_password (261.40s)
--- PASS: TestAccRDSCluster_missingUserNameCausesError (16.19s)
--- PASS: TestAccRDSCluster_iamAuth (141.04s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (420.61s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (422.51s)
--- PASS: TestAccRDSCluster_snapshotIdentifier (425.51s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (425.74s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (441.65s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (466.66s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (485.56s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (485.76s)
--- PASS: TestAccRDSCluster_NoDeleteAutomatedBackups (495.54s)
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (500.62s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (501.50s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (502.15s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (505.43s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (506.60s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (506.70s)
--- PASS: TestAccRDSCluster_takeFinalSnapshot (272.56s)
--- PASS: TestAccRDSCluster_encrypted (161.56s)
--- PASS: TestAccRDSCluster_kmsKey (164.84s)
--- PASS: TestAccRDSCluster_backupsUpdate (227.24s)
--- PASS: TestAccRDSCluster_backtrackWindow (266.87s)
--- PASS: TestAccRDSCluster_updateIAMRoles (211.00s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (513.36s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (211.09s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (278.41s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (176.16s)
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (223.84s)
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (264.26s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (184.31s)
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (408.61s)
--- PASS: TestAccRDSCluster_pointInTimeRestore (371.96s)
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (409.05s)
--- PASS: TestAccRDSCluster_port (281.54s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (261.32s)
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1 (204.34s)
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (225.29s)
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (250.61s)
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (279.72s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (202.78s)
--- PASS: TestAccRDSCluster_scaling (450.69s)
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora (342.74s)
--- PASS: TestAccRDSCluster_engineLifecycleSupport_disabled (155.76s)
--- PASS: TestAccRDSCluster_storageTypeAuroraReturnsBlank (184.11s)
--- PASS: TestAccRDSCluster_identifierPrefix (185.49s)
--- PASS: TestAccRDSCluster_engineVersion (482.58s)
--- PASS: TestAccRDSCluster_tags (213.71s)
--- PASS: TestAccRDSCluster_disappears (223.24s)
--- PASS: TestAccRDSCluster_identifierGenerated (121.34s)
--- PASS: TestAccRDSCluster_engineMode (407.85s)
--- PASS: TestAccRDSCluster_availabilityZones (172.62s)
--- PASS: TestAccRDSCluster_minorVersion (957.46s)
--- PASS: TestAccRDSCluster_iops (1836.12s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1344.14s)
--- PASS: TestAccRDSCluster_onlyMajorVersion (1358.17s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately (1311.21s)
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (2116.11s)
--- PASS: TestAccRDSCluster_storageTypeIo2 (1671.52s)
--- PASS: TestAccRDSCluster_domain (2408.77s)
--- PASS: TestAccRDSCluster_storageTypeIo1 (1771.97s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (1911.69s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (2295.09s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (2806.58s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (2457.84s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (3192.36s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (3195.72s)

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. labels May 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 25, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label May 25, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Allow configuration of RDS EngineLifecycleSupport
2 participants