Increase limit for maximum concurrent executions beyond 1000

[prince310501]

Description

Fix a bug where the terraform fails to configure a lambda's maximum concurrency beyond 1000 with SQS as event source even though the service quota limit on number of concurrent executions is increased to beyond 1000 in AWS.

Relations

Closes #37975

References

Output from Acceptance Testing

% make testacc TESTS=TestAccLambdaEventSourceMapping_SQS_ PKG=lambda ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3 -run='TestAccLambdaEventSourceMapping_SQS_' -timeout 600m
=== RUN TestAccLambdaEventSourceMapping_SQS_basic
=== PAUSE TestAccLambdaEventSourceMapping_SQS_basic
=== RUN TestAccLambdaEventSourceMapping_SQS_batchWindow
=== PAUSE TestAccLambdaEventSourceMapping_SQS_batchWindow
=== RUN TestAccLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== PAUSE TestAccLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== RUN TestAccLambdaEventSourceMapping_SQS_filterCriteria
=== PAUSE TestAccLambdaEventSourceMapping_SQS_filterCriteria
=== RUN TestAccLambdaEventSourceMapping_SQS_scalingConfig
=== PAUSE TestAccLambdaEventSourceMapping_SQS_scalingConfig
=== CONT TestAccLambdaEventSourceMapping_SQS_basic
=== CONT TestAccLambdaEventSourceMapping_SQS_scalingConfig
=== CONT TestAccLambdaEventSourceMapping_SQS_filterCriteria
--- PASS: TestAccLambdaEventSourceMapping_SQS_basic (149.31s)
=== CONT TestAccLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== CONT TestAccLambdaEventSourceMapping_SQS_batchWindow
--- PASS: TestAccLambdaEventSourceMapping_SQS_scalingConfig (182.93s)
--- PASS: TestAccLambdaEventSourceMapping_SQS_filterCriteria (203.06s)
--- PASS: TestAccLambdaEventSourceMapping_SQS_changesInEnabledAreDetected (111.12s)
--- PASS: TestAccLambdaEventSourceMapping_SQS_batchWindow (89.36s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 331.792s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @prince310501 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[prabhavpawar]

Hi @justinretzolk,

Seems like the PR is ready to be merged with pending review approval.
Are we reviewing the change for any impact?

Thanks!

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_SQS_scalingConfig' PKG=lambda
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaEventSourceMapping_SQS_scalingConfig -timeout 360m
=== RUN   TestAccLambdaEventSourceMapping_SQS_scalingConfig
=== PAUSE TestAccLambdaEventSourceMapping_SQS_scalingConfig
=== CONT  TestAccLambdaEventSourceMapping_SQS_scalingConfig
--- PASS: TestAccLambdaEventSourceMapping_SQS_scalingConfig (138.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	143.521s

[ewbankkit]

@prince310501 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!