Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify attributes as additional to arguments #4685

Merged
merged 1 commit into from
Jun 2, 2018
Merged

docs: Clarify attributes as additional to arguments #4685

merged 1 commit into from
Jun 2, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 29, 2018 •
edited
Loading

Reference (among many others): #4624

Changes proposed in this pull request:

  • Change attributes section verbiage to clarify that these attributes are in addition to arguments

Output from acceptance testing: N/A

@bflad bflad added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels May 29, 2018
@bflad bflad requested a review from a team May 29, 2018 14:32
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels May 29, 2018
@bflad bflad requested a review from a team May 30, 2018 14:53
@bflad bflad added this to the v1.22.0 milestone Jun 2, 2018
@bflad
Copy link
Contributor Author

bflad commented Jun 2, 2018

Let's rip off the bandaid on this one 😄

@bflad bflad merged commit 27306c6 into master Jun 2, 2018
@bflad bflad deleted the d-attributes-clarification branch June 2, 2018 21:44
This was referenced Jun 3, 2018
Merged
Merged
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @paddycarver