Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pricing vendor and client #5017

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Add pricing vendor and client #5017

merged 1 commit into from
Jun 29, 2018

Conversation

julienduchesne
Copy link
Contributor

@julienduchesne julienduchesne commented Jun 28, 2018 •
edited
Loading

Will be used for #5009

Changes proposed in this pull request:

  • Adds the "pricing" vendor dependency
  • Adds a pricingconn
  • Adds a custom pricing endpoint (pricing only has an API in us-east-1 and ap-south-1)

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 28, 2018
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 28, 2018
@bflad bflad added this to the v1.26.0 milestone Jun 28, 2018
bflad
bflad reviewed Jun 28, 2018
View reviewed changes
aws/provider.go Outdated
@@ -835,6 +835,7 @@ func providerConfigure(d *schema.ResourceData) (interface{}, error) {
config.KinesisEndpoint = endpoints["kinesis"].(string)
config.KmsEndpoint = endpoints["kms"].(string)
config.LambdaEndpoint = endpoints["lambda"].(string)
config.PricingEndpoint = endpoints["pricing"].(string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like everything is setup to correctly support the custom endpoint here. There are a few additional things required as shown in #4716. To not setup the customized endpoint, you can simply add handling similar to #4049

@bflad bflad added waiting-response Maintainers are waiting on response from community or contributor. provider Pertains to the provider itself, rather than any interaction with AWS. service/pricing Issues and PRs that pertain to the pricing service. labels Jun 28, 2018
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 28, 2018
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 28, 2018
@julienduchesne
Copy link
Contributor Author

Oops, sorry about that. I actually just removed the custom endpoint option since the API just refused calls from a provider with region other than the endpoint's region and I don't see much use in anyone implementing their own pricing API.

bflad
bflad approved these changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @julienduchesne! 🚀

@bflad bflad merged commit cf870bf into hashicorp:master Jun 29, 2018
@julienduchesne julienduchesne deleted the add-pricing-vendor branch July 4, 2018 12:41
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. service/pricing Issues and PRs that pertain to the pricing service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julienduchesne @bflad @breathingdust