Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ses_identity_notification_topic: Prevent panic when API returns no attributes #5327

Merged

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 25, 2018

Fixes #5326

Changes proposed in this pull request:

  • Add nil/map checks for GetIdentityNotificationAttributes API call

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsSESIdentityNotificationTopic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAwsSESIdentityNotificationTopic -timeout 120m
=== RUN   TestAccAwsSESIdentityNotificationTopic_basic
--- PASS: TestAccAwsSESIdentityNotificationTopic_basic (23.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.573s

…returns no attributes

make testacc TEST=./aws TESTARGS='-run=TestAccAwsSESIdentityNotificationTopic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAwsSESIdentityNotificationTopic -timeout 120m
=== RUN   TestAccAwsSESIdentityNotificationTopic_basic
--- PASS: TestAccAwsSESIdentityNotificationTopic_basic (23.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.573s
@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/ses Issues and PRs that pertain to the ses service. labels Jul 25, 2018
@bflad bflad requested a review from a team July 25, 2018 11:56
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jul 25, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.29.0 milestone Jul 25, 2018
@bflad bflad merged commit 87ebd1c into master Jul 25, 2018
@bflad bflad deleted the b-aws_ses_identity_notification_topic-no-attributes-panic branch July 25, 2018 13:38
bflad added a commit that referenced this pull request Jul 25, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 26, 2018

This has been released in version 1.29.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/ses Issues and PRs that pertain to the ses service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash Report: terraform apply causes crash
2 participants