Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 18.04 added. DB tier added. #5388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vadim-Zenin
Copy link

Two-tier example's update

Changes proposed in this pull request:

  • Old Ubuntu AMIs replaced with Ubuntu 18.04
  • DB tier added
  • DB instance, Security Group added
  • ELB configuration fixed
  • variables.tf extended
  • README.md updated

Output from acceptance testing:

$ terraform apply

Apply complete! Resources: 12 added, 0 changed, 0 destroyed.

Outputs:

db_private_ip = 10.0.160.88
db_public_ip = 54.169.31.85
elb_dns_name = test02-elb-1339856605.ap-southeast-1.elb.amazonaws.com
web_private_ip = 10.0.0.42
web_public_ip = 52.77.209.127
...

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 30, 2018
@bflad bflad added the documentation Introduces or discusses updates to documentation. label Aug 8, 2018
@aeschright aeschright requested a review from a team June 25, 2019 21:25
Base automatically changed from master to main January 23, 2021 00:55
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:55
@gdavison gdavison self-assigned this Apr 29, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit ewbankkit added the examples Introduces or discusses updates to examples. label Jun 6, 2022
@gdavison gdavison removed their assignment Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants